From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D9FC433E0 for ; Thu, 21 May 2020 09:55:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38749204EC for ; Thu, 21 May 2020 09:55:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38749204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C3E0E80026; Thu, 21 May 2020 05:55:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C166A80007; Thu, 21 May 2020 05:55:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B039F80026; Thu, 21 May 2020 05:55:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 9503E80007 for ; Thu, 21 May 2020 05:55:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 55CD782499B9 for ; Thu, 21 May 2020 09:55:18 +0000 (UTC) X-FDA: 76840268316.15.jump66_8595875175000 X-HE-Tag: jump66_8595875175000 X-Filterd-Recvd-Size: 4962 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 09:55:17 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id x20so8008181ejb.11 for ; Thu, 21 May 2020 02:55:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3bYIDtSe0AYOWKep27yvyR4GhELIyYbRcGxHnYqpsNk=; b=k3dKyqseKcCYQs7n0KblqkiFSSZzVsxDpNNSCbovUm2khnsriVp7O8BNw8yZAI03ob 41qr4ivqzwwkbNINu/WYsROZ7X5BCzK49Wu/LkiTkFJFOQIgsT6gfG6biD8FaaGw2BI2 sQaplFwFkVqiYBxuKgL3ipZtT4F9Z8vu7fPBHBqszj4u9CutTbDQ6C/kNqWHLYm3osK4 TIM0AcNC21SGOJA385p8H2qfdmwbuuGZjMmZ2iYEoD7cXdK3AtfqBnZxXXRxqUaK/Hv+ inNmKNtsOSderL0iEm/WArc8aAxzKQ9MUlqIBTHH3rHnBsb2d9jAvJMuTO8C8QZk2RZ9 NbfQ== X-Gm-Message-State: AOAM531/QRdhCovkOESCufLWM5lUtQ5U+1tyaLwbOOlu1qOkYZfT+MVc wV0bzY7X0zzVC4e27TJ33w8= X-Google-Smtp-Source: ABdhPJwkPKl947oxLKA7srqAfs9xs94g1gTJJERLoHvA+HQQuyirxmJpvQaMulbG/+j+XCDL1aFAmA== X-Received: by 2002:a17:906:3a11:: with SMTP id z17mr2778167eje.460.1590054916702; Thu, 21 May 2020 02:55:16 -0700 (PDT) Received: from localhost (ip-37-188-180-112.eurotel.cz. [37.188.180.112]) by smtp.gmail.com with ESMTPSA id z12sm4507462edk.78.2020.05.21.02.55.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 02:55:15 -0700 (PDT) Date: Thu, 21 May 2020 11:55:15 +0200 From: Michal Hocko To: Naresh Kamboju , Chris Down Cc: Yafang Shao , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , cgroups@vger.kernel.org Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200521095515.GK6462@dhcp22.suse.cz> References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520190906.GA558281@chrisdown.name> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 20-05-20 20:09:06, Chris Down wrote: > Hi Naresh, > > Naresh Kamboju writes: > > As a part of investigation on this issue LKFT teammate Anders Roxell > > git bisected the problem and found bad commit(s) which caused this problem. > > > > The following two patches have been reverted on next-20200519 and retested the > > reproducible steps and confirmed the test case mkfs -t ext4 got PASS. > > ( invoked oom-killer is gone now) > > > > Revert "mm, memcg: avoid stale protection values when cgroup is above > > protection" > > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. > > > > Revert "mm, memcg: decouple e{low,min} state mutations from protection > > checks" > > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. > > Thanks Anders and Naresh for tracking this down and reverting. > > I'll take a look tomorrow. I don't see anything immediately obviously wrong > in either of those commits from a (very) cursory glance, but they should > only be taking effect if protections are set. Agreed. If memory.{low,min} is not used then the patch should be effectively a nop. Btw. do you see the problem when booting with cgroup_disable=memory kernel command line parameter? I suspect that something might be initialized for memcg incorrectly and the patch just makes it more visible for some reason. -- Michal Hocko SUSE Labs