* Re: [PATCH] lockdep: Use different indentation in print_lock_class_header/print_lock_trace
[not found] <b10a31d999addb474530afaca7b2d4929a8da474.camel@perches.com>
@ 2020-05-19 23:56 ` kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2020-05-19 23:56 UTC (permalink / raw)
To: Joe Perches, Peter Zijlstra
Cc: kbuild-all, clang-built-linux, Dmitry Vyukov, LKML,
Andrew Morton, Linux Memory Management List, Will Deacon
[-- Attachment #1: Type: text/plain, Size: 2791 bytes --]
Hi Joe,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/locking/core]
[also build test ERROR on v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Joe-Perches/lockdep-Use-different-indentation-in-print_lock_class_header-print_lock_trace/20200520-013024
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 23b5ae2e8e1326c91b5dfdbb6ebcd5a6820074ae
config: arm-randconfig-r002-20200519 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
kernel//locking/lockdep.c:687:4: warning: format specifies type 'short' but the argument has type 'int' [-Wformat]
class->wait_type_outer ?: class->wait_type_inner,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel//locking/lockdep.c:1965:41: error: expected ')'
depth + 3 + strlen(usage_str[bit]);
^
kernel//locking/lockdep.c:1964:20: note: to match this '('
print_lock_trace(class->usage_traces[bit],
^
1 warning and 1 error generated.
vim +1965 kernel//locking/lockdep.c
1949
1950 static void print_lock_class_header(struct lock_class *class, int depth)
1951 {
1952 int bit;
1953
1954 printk("%*s->", depth, "");
1955 print_lock_name(class);
1956 #ifdef CONFIG_DEBUG_LOCKDEP
1957 printk(KERN_CONT " ops: %lu", debug_class_ops_read(class));
1958 #endif
1959 printk(KERN_CONT " {\n");
1960
1961 for (bit = 0; bit < LOCK_USAGE_STATES; bit++) {
1962 if (class->usage_mask & (1 << bit)) {
1963 printk("%*s %s at:\n", depth, "", usage_str[bit]);
1964 print_lock_trace(class->usage_traces[bit],
> 1965 depth + 3 + strlen(usage_str[bit]);
1966 }
1967 }
1968 printk("%*s }\n", depth, "");
1969
1970 printk("%*s ... key at: [<%px>] %pS\n",
1971 depth, "", class->key, class->key);
1972 }
1973
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26677 bytes --]
^ permalink raw reply [flat|nested] only message in thread