From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0511C433E0 for ; Wed, 20 May 2020 21:08:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF470207E8 for ; Wed, 20 May 2020 21:08:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF470207E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5472080008; Wed, 20 May 2020 17:08:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F70B80007; Wed, 20 May 2020 17:08:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E79A80008; Wed, 20 May 2020 17:08:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 27C1380007 for ; Wed, 20 May 2020 17:08:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D8F358248047 for ; Wed, 20 May 2020 21:08:47 +0000 (UTC) X-FDA: 76838336694.16.teeth42_86f96217e214c X-HE-Tag: teeth42_86f96217e214c X-Filterd-Recvd-Size: 1985 Received: from shards.monkeyblade.net (shards.monkeyblade.net [23.128.96.9]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 May 2020 21:08:47 +0000 (UTC) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1EB0F1210A409; Wed, 20 May 2020 14:08:45 -0700 (PDT) Date: Wed, 20 May 2020 14:08:42 -0700 (PDT) Message-Id: <20200520.140842.1711606625827492143.davem@davemloft.net> To: jhubbard@nvidia.com Cc: syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com, akpm@linux-foundation.org, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH] rds: fix crash in rds_info_getsockopt() From: David Miller In-Reply-To: <20200520194147.127137-1-jhubbard@nvidia.com> References: <00000000000000d71e05a6185662@google.com> <20200520194147.127137-1-jhubbard@nvidia.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 May 2020 14:08:46 -0700 (PDT) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: John Hubbard Date: Wed, 20 May 2020 12:41:47 -0700 > The conversion to pin_user_pages() had a bug: it overlooked > the case of allocation of pages failing. Fix that by restoring > an equivalent check. > > Reported-by: syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com > Fixes: dbfe7d74376e ("rds: convert get_user_pages() --> pin_user_pages()") > Signed-off-by: John Hubbard Applied to net-next, thanks.