From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3A7C433DF for ; Tue, 19 May 2020 18:17:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A30F20674 for ; Tue, 19 May 2020 18:17:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M0B7KgpZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A30F20674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2C0858000B; Tue, 19 May 2020 14:17:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 271B7900002; Tue, 19 May 2020 14:17:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 188268000B; Tue, 19 May 2020 14:17:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 016CB900002 for ; Tue, 19 May 2020 14:17:17 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BC8275008 for ; Tue, 19 May 2020 18:17:17 +0000 (UTC) X-FDA: 76834275714.30.scale22_2289bc3ad6f27 X-HE-Tag: scale22_2289bc3ad6f27 X-Filterd-Recvd-Size: 5020 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 18:17:17 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id w7so406215wre.13 for ; Tue, 19 May 2020 11:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=9i8fE9UcQoMjC7gZk0f5UIj2Ufp+6XHlfmp4ao/4O3I=; b=M0B7KgpZsBQt4E5X8OxXyD2yTNZWolR2/f+H8u41fyIpqXTQ/IBkg+PIk5pQaf9vVM B7FvAhfWR1Ys+m0PgvW4bYZdhRkSN72vW+NPWuFXNjOut7tyAU1zAhCgo0t/tzzyScxo 7v428tVbz9c1onq0wHUsVOODP7mwAeG57d5EcWSgVjstv5AnNaRYDSg+IpUshqa4jCi0 ZY2uUsdYSopy9gG2dy9+JsJkNabpMVOrmLEYO8GpjMhHzvTmmQ5E1cffTvmnVK3bJfol dRf+5Rb+dfJpS7ZkbpmYXVwTnfBgs42KLrH5bAIpl7PIt9yglAJbH2e4ykXBWz8d9oL3 neqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=9i8fE9UcQoMjC7gZk0f5UIj2Ufp+6XHlfmp4ao/4O3I=; b=JwkLIZMLVw12YOgg16Ucrq8nOFu+v0p0liQYG2us8SSkEgRFAQKP+RmcxuXsED6pGk 87we/rb/Q0SEuCOLqF3hCK/+SdLtXBhsV4CH36MK+fNcqTTUXNq1D2V73+R2FtpLIrBZ 29nkbmVPLKfZxQJzGGFU71Xqo3oxb9Q2J1UgFD7BIGJLoTLJgXjxW/o8LjYVglZOHfMA k0xWtDHrsHTR2pkxJcUJnb6BQUv3CtezxxDcm/yI9pQfwKNbcfTCk2+qr18mmC4OkikM e7kiDRDLMcsMr1lKPrlO1f6H1eQDJCGUQnoJEhzF3Vtb+M7GKPla6P90rsHyFBiIXeNR Jowg== X-Gm-Message-State: AOAM533mvn+bM/HkA9ShBJDUz0/i8xabRPhD4zVJUqmmMX5y09Fhyr2L ZNMMUYRlXkEJuywBY1GjT1w= X-Google-Smtp-Source: ABdhPJyxXQek9kmfiklyRswq34puGT0/qkq70Y1A0X+1ql8Y7CIbt8KUIclIUmKsIVrJHd1bSQywiA== X-Received: by 2002:adf:b301:: with SMTP id j1mr148805wrd.221.1589912236198; Tue, 19 May 2020 11:17:16 -0700 (PDT) Received: from dumbo ([185.220.101.209]) by smtp.gmail.com with ESMTPSA id d4sm250548wre.22.2020.05.19.11.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 11:17:15 -0700 (PDT) Received: from cavok by dumbo with local (Exim 4.92) (envelope-from ) id 1jb6ni-0004ND-0s; Tue, 19 May 2020 20:17:14 +0200 Date: Tue, 19 May 2020 20:17:13 +0200 From: Domenico Andreoli To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , "Darrick J. Wong" , Pavel Machek , Christoph Hellwig , Al Viro , Ted Ts'o , Len Brown , Linux PM , Linux Memory Management List , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 1/1] hibernate: restrict writes to the snapshot device Message-ID: <20200519181713.GB1963@dumbo> Mail-Followup-To: "Rafael J. Wysocki" , "Rafael J. Wysocki" , "Darrick J. Wong" , Pavel Machek , Christoph Hellwig , Al Viro , Ted Ts'o , Len Brown , Linux PM , Linux Memory Management List , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List References: <20200507080456.069724962@linux.com> <20200507080650.439636033@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.035199, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 19, 2020 at 05:59:15PM +0200, Rafael J. Wysocki wrote: > It would be better to paste the patch instead of attaching it. Done with v2. > Anyway, note that the snapshot special device is not the target block > device for saving the image, so it would be good to avoid that > confusion in the naming. I realize that it was a bit hazy in my head as well. It should be fixed in v2. > > I.e. I would rename is_hibernate_snapshot_dev() to something like > is_hibernate_image_dev() or is_hibernate_resume_dev() (for consistency > with the resume= kernel command line parameter name). Done as well. > Thanks! Thank you! Dom -- rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13 ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05