From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=VgvJ=7B=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1EDDDC433DF
	for <linux-mm@archiver.kernel.org>; Tue, 19 May 2020 23:14:44 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 9D78420809
	for <linux-mm@archiver.kernel.org>; Tue, 19 May 2020 23:14:43 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CPvadw6o"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D78420809
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 07E338001F; Tue, 19 May 2020 19:14:43 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 00824900003; Tue, 19 May 2020 19:14:42 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id E37C08001F; Tue, 19 May 2020 19:14:42 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194])
	by kanga.kvack.org (Postfix) with ESMTP id C523B900003
	for <linux-mm@kvack.org>; Tue, 19 May 2020 19:14:42 -0400 (EDT)
Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay03.hostedemail.com (Postfix) with ESMTP id 860B18248076
	for <linux-mm@kvack.org>; Tue, 19 May 2020 23:14:42 +0000 (UTC)
X-FDA: 76835025204.27.cent33_bf770d41dc21
X-HE-Tag: cent33_bf770d41dc21
X-Filterd-Recvd-Size: 2445
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by imf21.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Tue, 19 May 2020 23:14:42 +0000 (UTC)
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPSA id 6B12C20578;
	Tue, 19 May 2020 23:14:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1589930081;
	bh=kFVmk07C+lCDPUldrdSqVB+RgnW09KwNynO8E7jgKP4=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=CPvadw6o4TkrMm6zhPGc/Fm7a62w+1BbAGeTO3S9haFDCVPS7RIna8lD5ssh74RjP
	 t+aMesV4qDTyelgVbrAZFZ5m76cba3pUP5ZgvDc+UiLt5BRCjEKdpmGFWbeBiBkng6
	 PD9W9jab6gryKkZMUotBU+FXCbEVp9YXN/5Ma6RA=
Date: Tue, 19 May 2020 16:14:38 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Linux MM
 <linux-mm@kvack.org>, Kernel Team <kernel-team@fb.com>, Tejun Heo
 <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>, Chris Down
 <chris@chrisdown.name>, Cgroups <cgroups@vger.kernel.org>, Michal Hocko
 <mhocko@kernel.org>
Subject: Re: [PATCH mm v4 3/4] mm: move cgroup high memory limit setting
 into struct page_counter
Message-ID: <20200519161438.4f11ddec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <CALvZod4i2sBWcbKe3MHMuSMV3ywWwQx1Xr-abEqPS6n8vioC7w@mail.gmail.com>
References: <20200519171938.3569605-1-kuba@kernel.org>
	<20200519171938.3569605-4-kuba@kernel.org>
	<CALvZod4i2sBWcbKe3MHMuSMV3ywWwQx1Xr-abEqPS6n8vioC7w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On Tue, 19 May 2020 15:15:41 -0700 Shakeel Butt wrote:
> > --- a/mm/page_counter.c
> > +++ b/mm/page_counter.c
> > @@ -198,6 +198,11 @@ int page_counter_set_max(struct page_counter *counter, unsigned long nr_pages)
> >         }
> >  }
> >
> > +void page_counter_set_high(struct page_counter *counter, unsigned long nr_pages)
> > +{
> > +       WRITE_ONCE(counter->high, nr_pages);
> > +}
> > +  
> 
> Any reason not to make this static inline like
> page_counter_is_above_high() and in page_counter.h?

My reason was consistency with other page_counter_set_xyz() helpers,
but obviously happy to change if needed...