From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55105C433E0 for ; Tue, 19 May 2020 00:42:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0DB4D20756 for ; Tue, 19 May 2020 00:42:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zZ1dJXEo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DB4D20756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A66DC900003; Mon, 18 May 2020 20:42:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A186C900002; Mon, 18 May 2020 20:42:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90659900003; Mon, 18 May 2020 20:42:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id 75E3F900002 for ; Mon, 18 May 2020 20:42:53 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 24B1B181AEF0B for ; Tue, 19 May 2020 00:42:53 +0000 (UTC) X-FDA: 76831618626.24.shop13_8d908f5262b49 X-HE-Tag: shop13_8d908f5262b49 X-Filterd-Recvd-Size: 3350 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 00:42:52 +0000 (UTC) Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 597772072C; Tue, 19 May 2020 00:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589848971; bh=qxboCEg4hi3CXOBVgmrK9TNH02/9r/BNCIXuD89A5Sw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zZ1dJXEoHkeudQYpl+ZCYadBNd3ECVvJt9fa5tm7bHJKpYFJ0cEHRzCZ6ZTWW4R82 IpjwI5a97klaxsC+8kgRLXKVuyQtAlQxOwqWoSXAXdio7I7RWBOh+JLEycI1cJDC6i FZWr8BmJDeTO3aSzoAedmHKYKgllbObVJYvUxMt0= Date: Mon, 18 May 2020 17:42:49 -0700 From: Jakub Kicinski To: Shakeel Butt Cc: Andrew Morton , Linux MM , Kernel Team , Tejun Heo , Johannes Weiner , Chris Down , Cgroups , Michal Hocko Subject: Re: [PATCH mm v3 3/3] mm: automatically penalize tasks with high swap use Message-ID: <20200518174249.745e66d1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20200515202027.3217470-1-kuba@kernel.org> <20200515202027.3217470-4-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 17 May 2020 06:44:52 -0700 Shakeel Butt wrote: > > @@ -2583,12 +2606,23 @@ static int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask, > > * reclaim, the cost of mismatch is negligible. > > */ > > do { > > - if (page_counter_read(&memcg->memory) > READ_ONCE(memcg->high)) { > > - /* Don't bother a random interrupted task */ > > - if (in_interrupt()) { > > + bool mem_high, swap_high; > > + > > + mem_high = page_counter_read(&memcg->memory) > > > + READ_ONCE(memcg->high); > > + swap_high = page_counter_read(&memcg->swap) > > > + READ_ONCE(memcg->swap_high); > > + > > + /* Don't bother a random interrupted task */ > > + if (in_interrupt()) { > > + if (mem_high) { > > schedule_work(&memcg->high_work); > > break; > > } > > + continue; > > break? On a closer look I think continue is correct. In irq we only care about mem_high, because there's nothing we can do in a work context to penalize swap. So the loop is shortened. > > + } > > + > > + if (mem_high || swap_high) { > > current->memcg_nr_pages_over_high += batch; > > set_notify_resume(current); > > break;