From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36137C433E1 for ; Mon, 18 May 2020 22:18:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EA24020829 for ; Mon, 18 May 2020 22:18:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zZ+klVAa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA24020829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A658900003; Mon, 18 May 2020 18:18:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6313C900002; Mon, 18 May 2020 18:18:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51DC1900003; Mon, 18 May 2020 18:18:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 376E8900002 for ; Mon, 18 May 2020 18:18:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E1DDA181AEF0B for ; Mon, 18 May 2020 22:18:30 +0000 (UTC) X-FDA: 76831254780.01.bag08_2d30c3d4f5003 X-HE-Tag: bag08_2d30c3d4f5003 X-Filterd-Recvd-Size: 3212 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 May 2020 22:18:30 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7BC62081A; Mon, 18 May 2020 22:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589840309; bh=GAsP72OzLRqNeGGIYQczDNH78GgALiPWljn3TChp7vo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zZ+klVAaZtV27MGlVb0LzirdC6IcRNdxtR8vdL8+p1v703lmi5J9HVBsa59wZfYS2 rcHhIFOwmI6Yc/w9iEWdmxMN/U7GWNm4qd9W6owTNY+8aCiuJZFmriA8jGFyro1lnf B2QLoucZDhxzU0xGGj8zNn76nXG71emZmJGgdURs= Date: Mon, 18 May 2020 15:18:28 -0700 From: Andrew Morton To: Joerg Roedel Cc: Joerg Roedel , x86@kernel.org, hpa@zytor.com, Dave Hansen , Andy Lutomirski , Peter Zijlstra , rjw@rjwysocki.net, Arnd Bergmann , Steven Rostedt , Vlastimil Babka , Michal Hocko , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v3 2/7] mm/vmalloc: Track which page-table levels were modified Message-Id: <20200518151828.ad3c714a29209b359e326ec4@linux-foundation.org> In-Reply-To: <20200516125641.GK8135@suse.de> References: <20200515140023.25469-1-joro@8bytes.org> <20200515140023.25469-3-joro@8bytes.org> <20200515130142.4ca90ee590e9d8ab88497676@linux-foundation.org> <20200516125641.GK8135@suse.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 16 May 2020 14:56:41 +0200 Joerg Roedel wrote: > Hi Andrew, > > On Fri, May 15, 2020 at 01:01:42PM -0700, Andrew Morton wrote: > > On Fri, 15 May 2020 16:00:18 +0200 Joerg Roedel wrote: > > Lots of collisions here with Christoph's "decruft the vmalloc API" series > > (http://lkml.kernel.org/r/20200414131348.444715-1-hch@lst.de). > > > > I attempted to fix things up. > > > > unmap_kernel_range_noflush() needed to be redone. > > > > map_kernel_range_noflush() might need the arch_sync_kernel_mappings() call? > > Yes, map_kernel_range_noflush() needs the arch_sync_kernel_mappings() > call as well. > This? --- a/mm/vmalloc.c~mm-vmalloc-track-which-page-table-levels-were-modified-fix +++ a/mm/vmalloc.c @@ -309,6 +309,9 @@ int map_kernel_range_noflush(unsigned lo return err; } while (pgd++, addr = next, addr != end); + if (mask & ARCH_PAGE_TABLE_SYNC_MASK) + arch_sync_kernel_mappings(start, end); + return 0; } It would be nice to get all this (ie, linux-next) retested before we send it upstream, please.