From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FD1AC433DF for ; Fri, 15 May 2020 13:24:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D37D420758 for ; Fri, 15 May 2020 13:24:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Y0Zf8seE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D37D420758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6724490000C; Fri, 15 May 2020 09:24:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 622308E0005; Fri, 15 May 2020 09:24:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5391A90000C; Fri, 15 May 2020 09:24:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 3C55D8E0005 for ; Fri, 15 May 2020 09:24:44 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F1B244995E3 for ; Fri, 15 May 2020 13:24:43 +0000 (UTC) X-FDA: 76819023246.28.linen04_c21466ade808 X-HE-Tag: linen04_c21466ade808 X-Filterd-Recvd-Size: 7112 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 May 2020 13:24:43 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id f13so2482584qkh.2 for ; Fri, 15 May 2020 06:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QaWgWrHuxPFWiLAhp4MGw0Ee13FyqS0FhmE2+InAr5c=; b=Y0Zf8seELSKB++cOysfnNke0Q1k76yTJbnwd9rRfJFzYLkxIfL9/nlC1CVvTkXY1r9 X237RzZx508nP1DQhXxUfM8ufYAA/sDlD7aXCy1RECkqi3B88KBqXqAgLfXdeea+JOKP sr2HNKzwKT7a/5CHP+mQyk4HPqmfnePuexg9SGO+XsHXBaYAmhb3LohQz8G652U4JNdY 435kJdjSIfXUjHSpqzxa2p+WSHdqN33IjL7oO0ZM4yziSaY7z58qoJOvFZhf5gANOz29 cJF7y8i/lutV2jpKNQPdSLpWfP9YWiF7zl3araZDTay9TmA9VA9SJMWWSaxODkYdbBr5 t/LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QaWgWrHuxPFWiLAhp4MGw0Ee13FyqS0FhmE2+InAr5c=; b=RYrgPs9ROINniGBykJhmUiIKy7EmeuileELBFugf2+TDA4ACxUy7GxDqhABKaRYPcO cYrlEJREwX9D5AvbRrbOZ6dDvpnqIQHjopACKcmD/bMp+xpaPD5/n392gVluSDApwBZR 1OTDatqlMEenaqAkI3BdOrgRrzCMEjkaST60vM9uXB0XzYX40qCzld9q7W/VCLupJGpz WONFzTZ0hahLcXtrZT3WaVYlLDchLCV6ovcuv2zibu9QOgML3TE+8WEDoY1rrWtQWQ6s gKAQc0qfoGy+pbT2smBJUIklpdw/VsOQu6UL0s/aOMbq6hw/R/T0/biol0nBVkydygxa qZNQ== X-Gm-Message-State: AOAM530Y+w2mUCDfHr+ZibQVRb3D/hfLYC9a4+liIgU//w9FgZ0ISGNe G2TsG5B9pb4dBceeapKMe/LP1Q== X-Google-Smtp-Source: ABdhPJyglpfBWXibDDxv4gJRiM6bCFQxrloF93IYOhe1B1YqX0LapZGO/P4tWM2dZqB+l9qK9jPRRQ== X-Received: by 2002:a37:9e06:: with SMTP id h6mr3248738qke.400.1589549082491; Fri, 15 May 2020 06:24:42 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:90a4]) by smtp.gmail.com with ESMTPSA id t67sm1516787qka.17.2020.05.15.06.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 06:24:41 -0700 (PDT) Date: Fri, 15 May 2020 09:24:21 -0400 From: Johannes Weiner To: Michal Hocko Cc: Shakeel Butt , Mel Gorman , Roman Gushchin , Andrew Morton , Yafang Shao , Linux MM , Cgroups , LKML Subject: Re: [PATCH] memcg: expose root cgroup's memory.stat Message-ID: <20200515132421.GC591266@cmpxchg.org> References: <20200508170630.94406-1-shakeelb@google.com> <20200508214405.GA226164@cmpxchg.org> <20200515082955.GJ29153@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515082955.GJ29153@dhcp22.suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 15, 2020 at 10:29:55AM +0200, Michal Hocko wrote: > On Sat 09-05-20 07:06:38, Shakeel Butt wrote: > > On Fri, May 8, 2020 at 2:44 PM Johannes Weiner wrote: > > > > > > On Fri, May 08, 2020 at 10:06:30AM -0700, Shakeel Butt wrote: > > > > One way to measure the efficiency of memory reclaim is to look at the > > > > ratio (pgscan+pfrefill)/pgsteal. However at the moment these stats are > > > > not updated consistently at the system level and the ratio of these are > > > > not very meaningful. The pgsteal and pgscan are updated for only global > > > > reclaim while pgrefill gets updated for global as well as cgroup > > > > reclaim. > > > > > > > > Please note that this difference is only for system level vmstats. The > > > > cgroup stats returned by memory.stat are actually consistent. The > > > > cgroup's pgsteal contains number of reclaimed pages for global as well > > > > as cgroup reclaim. So, one way to get the system level stats is to get > > > > these stats from root's memory.stat, so, expose memory.stat for the root > > > > cgroup. > > > > > > > > from Johannes Weiner: > > > > There are subtle differences between /proc/vmstat and > > > > memory.stat, and cgroup-aware code that wants to watch the full > > > > hierarchy currently has to know about these intricacies and > > > > translate semantics back and forth. > > Can we have those subtle differences documented please? > > > > > > > > > Generally having the fully recursive memory.stat at the root > > > > level could help a broader range of usecases. > > > > > > The changelog begs the question why we don't just "fix" the > > > system-level stats. It may be useful to include the conclusions from > > > that discussion, and why there is value in keeping the stats this way. > > > > > > > Right. Andrew, can you please add the following para to the changelog? > > > > Why not fix the stats by including both the global and cgroup reclaim > > activity instead of exposing root cgroup's memory.stat? The reason is > > the benefit of having metrics exposing the activity that happens > > purely due to machine capacity rather than localized activity that > > happens due to the limits throughout the cgroup tree. Additionally > > there are userspace tools like sysstat(sar) which reads these stats to > > inform about the system level reclaim activity. So, we should not > > break such use-cases. > > > > > > Signed-off-by: Shakeel Butt > > > > Suggested-by: Johannes Weiner > > > > > > Acked-by: Johannes Weiner > > > > Thanks a lot. > > I was quite surprised that the patch is so simple TBH. For some reason > I've still had memories that we do not account for root memcg (likely > because mem_cgroup_is_root(memcg) bail out in the try_charge. But stats > are slightly different here. Yep, we skip the page_counter for root, but keep in mind that cgroup1 *does* have a root-level memory.stat, so (for the most part) we've been keeping consumer stats for the root level the whole time. > counters because they are not really all the same. E.g. > - mem_cgroup_charge_statistics accounts for each memcg Yep, that's heritage from cgroup1. > - memcg_charge_kernel_stack relies on pages being associated with a > memcg and that in turn relies on __memcg_kmem_charge_page which bails > out on root memcg You're right. It should only bypass the page_counter, but still set page->mem_cgroup = root_mem_cgroup, just like user pages. This counter also doesn't get exported on cgroup1, so it would indeed be a new bug. It needs to be fixed before this patch here. > - memcg_charge_slab (NR_SLAB*) skips over root memcg as well Same thing with these two.