From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51763C433E0 for ; Fri, 15 May 2020 07:22:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 18CE420767 for ; Fri, 15 May 2020 07:22:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18CE420767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9583090000C; Fri, 15 May 2020 03:22:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E1F68E0005; Fri, 15 May 2020 03:22:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7821390000C; Fri, 15 May 2020 03:22:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 5E2398E0005 for ; Fri, 15 May 2020 03:22:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1A40B40CD for ; Fri, 15 May 2020 07:22:13 +0000 (UTC) X-FDA: 76818109746.09.slope50_306e8b2adeb25 X-HE-Tag: slope50_306e8b2adeb25 X-Filterd-Recvd-Size: 3497 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 May 2020 07:22:12 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id 50so2214880wrc.11 for ; Fri, 15 May 2020 00:22:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wWbNW8kbMyNjSXbBam4c4gSY4otg46mxe59LKoz0OF8=; b=nJeMJPJb8/UGBfNFkZkj8yMam4v8f77sa2UJiIhtKau3dQHmes1JPPA6KQBppIPmB4 miambFei2+zLHXzyUbCWO9tKSDA2Q6LxdtnpOImsluiNhMYdeT3GqELXWf804Ges0ZxK EPbnPbpHz54wp9JXehtbEKeFt4W9HBlIjGYULZ99YMLVDl2LxDbeQMGngslYqD1XTOMN RzoWmmIaa33B5ifaRYjjy3fmebqS7OqkW28I4O3bOhsywevFcGx3Evr+h+c8aaenNKwa ZdvPRFuMv2p9/Ydir+A//8cmXJEccXIHEPS5N7s38s8PP/gBY+8DleV4vw1MrQDHpdvt 9I9w== X-Gm-Message-State: AOAM532ywijH8YibdlatONVNCPr8SJU8VDumeIY/MhCxFaER/FISCeSb H6fBFy3C7t+WtI1V3TlKoGk= X-Google-Smtp-Source: ABdhPJwNTmCMUmKiYMOk+Ml322N9pT1hmc/pcQdWgRnBrHGVidmJLilnZQwB3PGJVF+EXOHBLeyM7g== X-Received: by 2002:a5d:6705:: with SMTP id o5mr2746406wru.426.1589527331467; Fri, 15 May 2020 00:22:11 -0700 (PDT) Received: from localhost (ip-37-188-249-36.eurotel.cz. [37.188.249.36]) by smtp.gmail.com with ESMTPSA id z18sm2109678wmk.46.2020.05.15.00.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 00:22:10 -0700 (PDT) Date: Fri, 15 May 2020 09:22:09 +0200 From: Michal Hocko To: Feng Tang Cc: Andrew Morton , Johannes Weiner , Matthew Wilcox , Mel Gorman , Kees Cook , Luis Chamberlain , Iurii Zaikin , andi.kleen@intel.com, tim.c.chen@intel.com, dave.hansen@intel.com, ying.huang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] proc/meminfo: avoid open coded reading of vm_committed_as Message-ID: <20200515072209.GF29153@dhcp22.suse.cz> References: <1588922717-63697-1-git-send-email-feng.tang@intel.com> <1588922717-63697-2-git-send-email-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588922717-63697-2-git-send-email-feng.tang@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 08-05-20 15:25:15, Feng Tang wrote: > Use the existing vm_memory_committed() instead, which is also > convenient for future change. > > Signed-off-by: Feng Tang Acked-by: Michal Hocko > --- > fs/proc/meminfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > index 8c1f1bb..578c0b8 100644 > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -42,7 +42,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > > si_meminfo(&i); > si_swapinfo(&i); > - committed = percpu_counter_read_positive(&vm_committed_as); > + committed = vm_memory_committed(); > > cached = global_node_page_state(NR_FILE_PAGES) - > total_swapcache_pages() - i.bufferram; > -- > 2.7.4 -- Michal Hocko SUSE Labs