From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46261C433E0 for ; Thu, 14 May 2020 10:37:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D488206B6 for ; Thu, 14 May 2020 10:37:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="lPkCbxeM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D488206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 92D4290013E; Thu, 14 May 2020 06:37:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DDD68E0005; Thu, 14 May 2020 06:37:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F2D090013E; Thu, 14 May 2020 06:37:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 64D9D8E0005 for ; Thu, 14 May 2020 06:37:41 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1CEA9180AD806 for ; Thu, 14 May 2020 10:37:41 +0000 (UTC) X-FDA: 76814973522.30.juice33_6023f3a369647 X-HE-Tag: juice33_6023f3a369647 X-Filterd-Recvd-Size: 3854 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 May 2020 10:37:40 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id j2so2356938qtr.12 for ; Thu, 14 May 2020 03:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oQGuvng4zGGv5wxqMi1jZPorRLuXoaTainTjhtEgYIQ=; b=lPkCbxeMo7dsvFXTJg0O7IFp8a4XUMtflfpaw4jJsj34jpWrE7nR4OtRrG/OHB1V8j clSkW03wJM/LcoIo9aLEGmLWH5MymBRcWQng8UEd1YI0Qc0DLfhVql6UETwJUUq0M4UZ I68gS+DIMYU1xqH1eGpRsXq9Sda4RI4fmrq3d1y7myiVHD6sNyUenFBS7XucShvteUqh FWQuIcCzrqANHmgxDtH8lnnj/BWq2BPEqKQ5qiTVoP0wchnJCkH8GCZUysQ4E4jqX0UQ PDaqJnZeKrdM92YNItffMp9M5t4VvaA7UFTrODdfaQ2xaH8t9lOpsi/+tnsv7QnXlsCc ySBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oQGuvng4zGGv5wxqMi1jZPorRLuXoaTainTjhtEgYIQ=; b=fF5pbKVW526Qk4h1Y60VgZQ04w2T5XigRFUS9xK2dntunKItgnjijmATYumozIyHMa YI55nBXNUKbQvWM0gHqbU2iC0G0xJjFEXW7UVUfVEf+DsL/fgV8ZjSmB5NJBkDR1rBtq p4FLAcibZnjlT2cEk38HUBWb3Zn6WBCEIp5dCzmm8L5f4OGLFBs5txp2CsxIVYyA9oI1 S2iEVa6KYcu9IkvqV1esVirUIR+tgz8msf1QWCngUfwye3/n/YoG8x4mi/ZyzS8FJHkv OMs+7hS1kB+oyQuWYBL0QuKa10gRf+RPk3bZFUKH6QuHVSNaGf0VcWj87OQh600CvQ4p JB5Q== X-Gm-Message-State: AOAM5313NLYedfcKrDdqLfrmHTppU9vmatVN1UG0nJnfrrqe1r5qRhEj VnIVBhoJM07+98DO43Wgeb73VQ== X-Google-Smtp-Source: ABdhPJyDqNvFIRfBk7tlS98FRZ3FzokDDKiYSA1d0AeNz9UYvOdmQl1YlcVymLO7LJYmuo1SKTaFtQ== X-Received: by 2002:ac8:6055:: with SMTP id k21mr2150455qtm.294.1589452659861; Thu, 14 May 2020 03:37:39 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id h3sm2346327qkf.15.2020.05.14.03.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 03:37:39 -0700 (PDT) Date: Thu, 14 May 2020 06:37:20 -0400 From: Johannes Weiner To: Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner , Yafang Shao , Michal Hocko , Roman Gushchin , Linus Torvalds , Al Viro , kernel-team@fb.com Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU Message-ID: <20200514103720.GA544269@cmpxchg.org> References: <20200211175507.178100-1-hannes@cmpxchg.org> <20200512212936.GA450429@cmpxchg.org> <20200513192410.157747af4dee2da5aa0a50b1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513192410.157747af4dee2da5aa0a50b1@linux-foundation.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 13, 2020 at 07:24:10PM -0700, Andrew Morton wrote: > On Tue, 12 May 2020 17:29:36 -0400 Johannes Weiner wrote: > > > + inode_pages_clear(mapping->inode); > > + else if (populated == 1) > > + inode_pages_set(mapping->inode); > > mapping->host... I'll fix that. > I have to assume this version wasn't runtime tested, so I'll drop it. It was, but I don't have DAX-suitable hardware so that config option isn't enabled anywhere. I'll try to test this with a brd. Sorry about that.