From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7079FC2D0F7 for ; Tue, 12 May 2020 20:00:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2922C206D6 for ; Tue, 12 May 2020 20:00:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="WP/bUxOu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2922C206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B61709000F0; Tue, 12 May 2020 16:00:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B137A900036; Tue, 12 May 2020 16:00:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A289F9000F0; Tue, 12 May 2020 16:00:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 8A5EB900036 for ; Tue, 12 May 2020 16:00:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2AEF3180AD811 for ; Tue, 12 May 2020 20:00:03 +0000 (UTC) X-FDA: 76809133086.11.seat84_57bb27f62025a X-HE-Tag: seat84_57bb27f62025a X-Filterd-Recvd-Size: 3847 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 May 2020 20:00:02 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id c64so14975721qkf.12 for ; Tue, 12 May 2020 13:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hph7m+QWM+PUvHgFd6P1tSDWqCEm+ZM+VGd8EVir3aw=; b=WP/bUxOuH3O5G7JSrqrmQrrF0fMfSTYjDrTlDz2RvaMD6vs1v1g+fZk7mi/S01vDXN pfINNoqHpAfxVVQfu2kToT1A4Y2XVLZPFiULT+s0FUYfcOr+pvuzXYoBMRcRmNeNUQi/ 7XMOn/3orRnviOHNR/5gAeVdhfKA91T3vN8pBZ8hx+ZTf1YuYvpyaKvUJd1oL0o/Q+WZ 7Kc27m/AcgUZHMvq65WVxdHOn1wP/ut/dkIphA2NjUqt4dJfF6S8R8d0JvSlsNAUyhWv oXf2+K3AmMc0uj6b52ag0hJ1U53T72eIpSkQ+aVTIZ0yH2m78oM9BXdtKIj+RbLB3o3L 2b+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hph7m+QWM+PUvHgFd6P1tSDWqCEm+ZM+VGd8EVir3aw=; b=PIq3MHk0BGiJ6eVOPzXDQEWZivmNav7CDJo6nWsPGhVeGHDDMqPuaHlskHFkV+8aJm qO9bu2HbChOwU7TJJVehS83vPSDm7wXbsLUw7ZRTButaTvfo4xqkaz5FNnhHwHO6n6s7 A123PqFohEQFm+hEbc4dcj1rTQzLWGpKiIsjt7y3L/ydL8pINXwoKGuJQRCyPe85/q2k 2DvIU8BkI+s9Qm4DYWelDNx6z19Wu8MijBqknDyX+WdjT10M/W/tK7d9XXy8/IadcdbR gOjnILBOBvPaHobd+v5JjG6ap7pTOv5QFJOSWvTspglTmvuOQIX6TbGTCOe0VnNrVxsQ vN3Q== X-Gm-Message-State: AGi0PuaJ0O7LqlLo27hCwIWIwyVsn8xKomE+uNxrC2wVfTw5ZOqRr5tb YKxElhHi/wwhiGrN40SL+XvUGg== X-Google-Smtp-Source: APiQypJHPzfJAlIPmc2g23wMQ1YKV//K5WdTr4V6Hc5ZeYs71sdMaWrQNWo5kCI8va4xh9o/rSCNXA== X-Received: by 2002:a37:b847:: with SMTP id i68mr15348735qkf.431.1589313602178; Tue, 12 May 2020 13:00:02 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id z18sm12799888qti.47.2020.05.12.13.00.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 May 2020 13:00:01 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jYb4L-0002PS-BY; Tue, 12 May 2020 17:00:01 -0300 Date: Tue, 12 May 2020 17:00:01 -0300 From: Jason Gunthorpe To: Dan Carpenter Cc: =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ralph Campbell , linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm/hmm/test: Fix some copy_to_user() error handling Message-ID: <20200512200001.GC9154@ziepe.ca> References: <20200511183704.GA225608@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200511183704.GA225608@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 11, 2020 at 09:37:04PM +0300, Dan Carpenter wrote: > The copy_to_user() function returns the number of bytes which weren't > copied but we want to return negative error codes. Also in dmirror_write() > if the copy_from_user() fails then there is some cleanup needed before > we can return so I fixed that as well. > > Fixes: 5d5e54be8a1e3 ("mm/hmm/test: add selftest driver for HMM") > Signed-off-by: Dan Carpenter > --- > lib/test_hmm.c | 41 +++++++++++++++++++++++++---------------- > 1 file changed, 25 insertions(+), 16 deletions(-) Thank you, I squashed this into the original commit. Jason