From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC54C2D0F7 for ; Tue, 12 May 2020 19:59:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26E5220731 for ; Tue, 12 May 2020 19:59:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="RvG9v0Od" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26E5220731 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A028F9000EE; Tue, 12 May 2020 15:59:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B41B900036; Tue, 12 May 2020 15:59:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A1C99000EE; Tue, 12 May 2020 15:59:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 71BE9900036 for ; Tue, 12 May 2020 15:59:15 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 315B02C9D for ; Tue, 12 May 2020 19:59:15 +0000 (UTC) X-FDA: 76809131070.13.dress81_50bdf3e96c254 X-HE-Tag: dress81_50bdf3e96c254 X-Filterd-Recvd-Size: 3778 Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 May 2020 19:59:14 +0000 (UTC) Received: by mail-qv1-f66.google.com with SMTP id g20so4036315qvb.9 for ; Tue, 12 May 2020 12:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G0E+aRa/ZtrphMMA9D9NE7f6TBwYO8PfcdNUKK6vjxM=; b=RvG9v0Odg6qBR62ASTwz6eXPTa5d3e3jqj23LRj7mYiCspx8Lhv9J/F9/GU+RSWJQL S0KhpwyTD4SiCgCUZexbjIUqlPzB98A4q/sXuskbTx2ffJscPBmP0cZkBCA2y5RDLikg aD+zWPSUqEyeqDKtwhDXrB0ww6O9xn5elj19OD526q57VO4JrHUU8wHEr/TiYHz8QZOn zN6slqAJXqTj5IrE2+Rl+5b+SR6WrLwx3uGncejjsI6RsKekMylec3MPlvEUSgiFI4eB 5pBCSr24/IjOGNt03rY6lioDEieojUiD9SLmPGjJxZPeFXk1hhij+bkjvr8LyRx4RMOB kRxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G0E+aRa/ZtrphMMA9D9NE7f6TBwYO8PfcdNUKK6vjxM=; b=pHgGdK84PdBFg2DW9HhIG6aQRd8F2/w0meO3c3x1uafwOqcOgg+MOR/qe53KI7zh2K tPY9EgTvPI4YbhUOfdXw6jI0pBUrbF7RUprbzZVvpbSzlaa61XvJRIeJR4iHbB+k+/xM 7PuiSuS3CwUhstvAneY/XS6aLLbyTGSEL6efyNEiHBIF7cy9AkgEAmVQ2ntoeSKKV4Ue /fu/NPOY1GfNfPQKWA53ndN4q6m9ur8o8Q1iQKN+Ak+UJp4evqKK4jsIO0nD0CQWKMG3 eqrpUUpPntOxrvUVUt0jai5/hhPDhiVUCM2qc+9RH18KH2R2ZcdspRH3aZ4tYTuoTQtv XqkA== X-Gm-Message-State: AGi0PuaxzKnK+hw/KJSZmlrNym+bVr7+KuWOB8BLN3kG7dmU9nSL+JZn LY4+X09ugHU65/NYfnmq0yUGNw== X-Google-Smtp-Source: APiQypI4djh3JsPTXr1ZWOiJGKRTthks1rzNkpnJFW1YgbpflsyktHQNnCWGxvpkoWENatD9+/5s9Q== X-Received: by 2002:a0c:9002:: with SMTP id o2mr22007639qvo.3.1589313554114; Tue, 12 May 2020 12:59:14 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id h18sm5904214qkh.3.2020.05.12.12.59.13 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 May 2020 12:59:13 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jYb3X-0002ON-Vr; Tue, 12 May 2020 16:59:11 -0300 Date: Tue, 12 May 2020 16:59:11 -0300 From: Jason Gunthorpe To: Wei Yongjun Cc: jglisse@redhat.com, Ralph Campbell , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map() Message-ID: <20200512195911.GA9154@ziepe.ca> References: <20200509030225.14592-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200509030225.14592-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.008933, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 09, 2020 at 03:02:25AM +0000, Wei Yongjun wrote: > Add the missing unlock before return from function > dmirror_migrate_finalize_and_map() in the error > handling case. > > Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > lib/test_hmm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thank you, I squashed this into the original commit Jason