From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B45C47255 for ; Mon, 11 May 2020 15:11:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A24820736 for ; Mon, 11 May 2020 15:11:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A24820736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 91E5890005B; Mon, 11 May 2020 11:11:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CEBF900036; Mon, 11 May 2020 11:11:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80BC790005B; Mon, 11 May 2020 11:11:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id 67F95900036 for ; Mon, 11 May 2020 11:11:25 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 27BD7180AD811 for ; Mon, 11 May 2020 15:11:25 +0000 (UTC) X-FDA: 76804776930.04.side21_80b7099a1685e X-HE-Tag: side21_80b7099a1685e X-Filterd-Recvd-Size: 2773 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 May 2020 15:11:24 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2865568BFE; Mon, 11 May 2020 17:11:21 +0200 (CEST) Date: Mon, 11 May 2020 17:11:20 +0200 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel , Jessica Yu , Michal Simek , the arch/x86 maintainers , alpha , Linux Kernel Mailing List , Linux ARM , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , sparclinux , Linux-Arch , Linux MM , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Linux FS Devel Subject: Re: [PATCH 31/31] module: move the set_fs hack for flush_icache_range to m68k Message-ID: <20200511151120.GA28634@lst.de> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-32-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 11, 2020 at 09:40:39AM +0200, Geert Uytterhoeven wrote: > On Sun, May 10, 2020 at 9:57 AM Christoph Hellwig wrote: > > > > flush_icache_range generally operates on kernel addresses, but for some > > reason m68k needed a set_fs override. Move that into the m68k code > > insted of keeping it in the module loader. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Geert Uytterhoeven > Acked-by: Geert Uytterhoeven Btw, do you know what part of flush_icache_range relied on set_fs? Do any of the m68k maintainers have an idea how to handle that in a nicer way when we can split the implementations?