From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F1CC47255 for ; Mon, 11 May 2020 21:11:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 533BE20882 for ; Mon, 11 May 2020 21:11:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IiLcHFYc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 533BE20882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D1B78900082; Mon, 11 May 2020 17:11:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA330900036; Mon, 11 May 2020 17:11:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B444D900082; Mon, 11 May 2020 17:11:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 99023900036 for ; Mon, 11 May 2020 17:11:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4FA8C181AEF0B for ; Mon, 11 May 2020 21:11:24 +0000 (UTC) X-FDA: 76805684088.06.pan35_466b4658d482a X-HE-Tag: pan35_466b4658d482a X-Filterd-Recvd-Size: 2144 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 May 2020 21:11:23 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 90A0720836; Mon, 11 May 2020 21:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589231483; bh=UTbTm++8n1i5+8gpoyrj8bjLx9n97J0BhZSZ+eXg4SM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IiLcHFYcraLjJV+Jzc7qEmx+NomfJ1/WNEHXIAbI+dvzxN9fKuHJW9K5G/xidO805 yRDXie7P68uvY0/eLWqwriQp0s5iaWqj2m2xgqggx63FqK1UZegLOkEgSqG/6+rwCu WCMU4TRu46XTINcJTUDHls7QegV9BBOQTMzEzugQ= Date: Mon, 11 May 2020 14:11:22 -0700 From: Andrew Morton To: Shakeel Butt Cc: Mel Gorman , Johannes Weiner , Roman Gushchin , Michal Hocko , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix LRU balancing effect of new transparent huge pages Message-Id: <20200511141122.9b03e2f0852b57b224eab066@linux-foundation.org> In-Reply-To: <20200509141946.158892-1-shakeelb@google.com> References: <20200509141946.158892-1-shakeelb@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 9 May 2020 07:19:46 -0700 Shakeel Butt wrote: > Currently, THP are counted as single pages until they are split right > before being swapped out. However, at that point the VM is already in > the middle of reclaim, and adjusting the LRU balance then is useless. > > Always account THP by the number of basepages, and remove the fixup > from the splitting path. Confused. What kernel is this applicable to?