From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD392C54E4B for ; Mon, 11 May 2020 08:39:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A0B9208DB for ; Mon, 11 May 2020 08:39:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A0B9208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BD25900019; Mon, 11 May 2020 04:39:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16D7D900006; Mon, 11 May 2020 04:39:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 084C3900019; Mon, 11 May 2020 04:39:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id E58A6900006 for ; Mon, 11 May 2020 04:39:07 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A4C7F181AEF10 for ; Mon, 11 May 2020 08:39:07 +0000 (UTC) X-FDA: 76803788334.08.book53_328f6e359643c X-HE-Tag: book53_328f6e359643c X-Filterd-Recvd-Size: 4782 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 May 2020 08:39:07 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id w7so9794982wre.13 for ; Mon, 11 May 2020 01:39:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FvpNgO4al8rrIK8WSxp3SMkvIJuIwqja3bw4ZHXrWYo=; b=DNfyxKGshNZy9CvgXqAqvtur+MnsrQx6JNzpSC/EObG8GgfNamtaZKabBnMxjD+5Zv O3WEVO4wTabFHbuNWvRIwlqVvLteBo2iMRC0glaJkCI+8Ubrr6i2GTYAOcz9QAXBXPmK TrwohxKB9JqkgZ1kwLdPuqFtRvpCrWDB2LRk5cDSPJNT2FhxK0YzOj1xqiehJJhm3San foDAtadAEEGYXK9WmuGSaa1DbNXAPk1VkTD7SGCyeL686hm0WHxfuzHAhBgtpc6lvBlt zfNhb395F9Fcb5tyoRemK1mql0bMqIGTK9iQBgL5U/86s4V2J6oQ/hN6LhZWCkDIrJlW VK4g== X-Gm-Message-State: AGi0PubOIbWaoFx5mnIuSKjcrXk6Zt6A/qk0+YLVSx1wIJtHBQrxCCZf RQlKMif/ECIODbkw7yW6mp8= X-Google-Smtp-Source: APiQypIQpwTFkabbZL1uF+YtruIWqkdDkGAaVl3JWB4S4P9pWHgVyfF5FMY7zlh26GTwUoVsZH0JPQ== X-Received: by 2002:a5d:61c3:: with SMTP id q3mr15869696wrv.405.1589186346279; Mon, 11 May 2020 01:39:06 -0700 (PDT) Received: from localhost (ip-37-188-228-19.eurotel.cz. [37.188.228.19]) by smtp.gmail.com with ESMTPSA id n7sm7415677wro.94.2020.05.11.01.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 01:39:05 -0700 (PDT) Date: Mon, 11 May 2020 10:39:04 +0200 From: Michal Hocko To: Konstantin Khlebnikov Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , cgroups@vger.kernel.org, Roman Gushchin Subject: Re: [PATCH] doc: cgroup: update note about conditions when oom killer is invoked Message-ID: <20200511083904.GB29153@dhcp22.suse.cz> References: <158894738928.208854.5244393925922074518.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158894738928.208854.5244393925922074518.stgit@buzz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 08-05-20 17:16:29, Konstantin Khlebnikov wrote: > Starting from v4.19 commit 29ef680ae7c2 ("memcg, oom: move out_of_memory > back to the charge path") cgroup oom killer is no longer invoked only from > page faults. Now it implements the same semantics as global OOM killer: > allocation context invokes OOM killer and keeps retrying until success. > > Signed-off-by: Konstantin Khlebnikov Acked-by: Michal Hocko > --- > Documentation/admin-guide/cgroup-v2.rst | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index bcc80269bb6a..1bb9a8f6ebe1 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1172,6 +1172,13 @@ PAGE_SIZE multiple when read back. > Under certain circumstances, the usage may go over the limit > temporarily. > > + In default configuration regular 0-order allocation always > + succeed unless OOM killer choose current task as a victim. > + > + Some kinds of allocations don't invoke the OOM killer. > + Caller could retry them differently, return into userspace > + as -ENOMEM or silently ignore in cases like disk readahead. I would probably add -EFAULT but the less error codes we document the better. > + > This is the ultimate protection mechanism. As long as the > high limit is used and monitored properly, this limit's > utility is limited to providing the final safety net. > @@ -1228,17 +1235,9 @@ PAGE_SIZE multiple when read back. > The number of time the cgroup's memory usage was > reached the limit and allocation was about to fail. > > - Depending on context result could be invocation of OOM > - killer and retrying allocation or failing allocation. > - > - Failed allocation in its turn could be returned into > - userspace as -ENOMEM or silently ignored in cases like > - disk readahead. For now OOM in memory cgroup kills > - tasks iff shortage has happened inside page fault. > - > This event is not raised if the OOM killer is not > considered as an option, e.g. for failed high-order > - allocations. > + allocations or if caller asked to not retry attempts. > > oom_kill > The number of processes belonging to this cgroup -- Michal Hocko SUSE Labs