From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B85FC28CBC for ; Sat, 9 May 2020 16:01:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A55921582 for ; Sat, 9 May 2020 16:01:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A55921582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB3F290000A; Sat, 9 May 2020 12:01:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A631D8E0003; Sat, 9 May 2020 12:01:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 950CC90000A; Sat, 9 May 2020 12:01:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 7B68C8E0003 for ; Sat, 9 May 2020 12:01:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 334972497 for ; Sat, 9 May 2020 16:01:47 +0000 (UTC) X-FDA: 76797646254.13.train96_f8796e20a056 X-HE-Tag: train96_f8796e20a056 X-Filterd-Recvd-Size: 4894 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sat, 9 May 2020 16:01:46 +0000 (UTC) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 049FWvqu114878; Sat, 9 May 2020 12:01:45 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 30wrvwyef3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 May 2020 12:01:45 -0400 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 049FtnMw156874; Sat, 9 May 2020 12:01:44 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 30wrvwyee9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 May 2020 12:01:44 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 049FUeq4008946; Sat, 9 May 2020 16:01:42 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03ams.nl.ibm.com with ESMTP id 30wm55gyyx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 May 2020 16:01:42 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 049G1eOV30081142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 9 May 2020 16:01:40 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63054AE04D; Sat, 9 May 2020 16:01:40 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D517AAE045; Sat, 9 May 2020 16:01:39 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.202.219]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sat, 9 May 2020 16:01:39 +0000 (GMT) Date: Sat, 9 May 2020 19:01:37 +0300 From: Mike Rapoport To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH] mm: memblock: fix minor typo and unclear comment Message-ID: <20200509160137.GA801504@linux.ibm.com> References: <1588846952-32166-1-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588846952-32166-1-git-send-email-qiwuchen55@gmail.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676 definitions=2020-05-09_05:2020-05-08,2020-05-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 clxscore=1011 mlxscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 suspectscore=3 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005090138 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 07, 2020 at 06:22:32PM +0800, qiwuchen55@gmail.com wrote: > From: chenqiwu > > Fix a minor typo "usabe->usable" for the current discription > of member variable "memory" in struct memblock. > > BTW, I think it's unclear the member variable "base" in > struct memblock_type is currently described as the physical > address of memory region, change it to base address of the > region is clearer since the variable is decorated as phys_addr_t. > > Signed-off-by: chenqiwu Reviewed-by: Mike Rapoport > --- > include/linux/memblock.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 6bc37a7..b594e0b 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -41,7 +41,7 @@ enum memblock_flags { > > /** > * struct memblock_region - represents a memory region > - * @base: physical address of the region > + * @base: base address of the region > * @size: size of the region > * @flags: memory region attributes > * @nid: NUMA node id > @@ -75,7 +75,7 @@ struct memblock_type { > * struct memblock - memblock allocator metadata > * @bottom_up: is bottom up direction? > * @current_limit: physical address of the current allocation limit > - * @memory: usabe memory regions > + * @memory: usable memory regions > * @reserved: reserved memory regions > * @physmem: all physical memory > */ > -- > 1.9.1 > -- Sincerely yours, Mike.