From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B9CC47255 for ; Fri, 8 May 2020 21:56:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50A0A21974 for ; Fri, 8 May 2020 21:56:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="rVWxHIzD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50A0A21974 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DBBDD900020; Fri, 8 May 2020 17:56:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6A6C90001C; Fri, 8 May 2020 17:56:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C595A900020; Fri, 8 May 2020 17:56:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id ADE4290001C for ; Fri, 8 May 2020 17:56:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6A3658248068 for ; Fri, 8 May 2020 21:56:34 +0000 (UTC) X-FDA: 76794911508.17.shoe36_90ab81f1aed47 X-HE-Tag: shoe36_90ab81f1aed47 X-Filterd-Recvd-Size: 3680 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 May 2020 21:56:34 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id b188so3369377qkd.9 for ; Fri, 08 May 2020 14:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8zne5kD9U815Qp7lQoOfSkfWPnKdq4UH7l4ACZ1laQI=; b=rVWxHIzDFvif9rrgKfKEzuzUqpug84jgH+pn6g2K+if7ys4WCpoBTPfsO3vQPvKAhN yVfFa2Lp+fBa+5PTkzDejJhE9e4mKzNB4oFie8Fb4O99NmTGN8QvA+xTxmSSZnk3ibBc HY2i6VFZUdjANcY0MDN1d4b9v0m8v8op+VhiOv7vwRUaW0FVadyL0QI7pMaOVKtzkkDK eICt41IJctDdTY3MUPL17fid7XHKjjKefy0raEReMlnpRuJoXM9b+XyKVFxobwnSPF9F Mh/uSrnjUReBhhaHgRTzE7vs/YNfmZ2ip7aKqPqWJrOr4nWGMCvhk2K4BK7cIVcztiM7 Ocsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8zne5kD9U815Qp7lQoOfSkfWPnKdq4UH7l4ACZ1laQI=; b=sEg7GtF2qxNfT1vgl38ncZqfm63GrPxHuIidXYSiLqZ+2NM5ehH3BemCe3JXDlWr3N 5sSxHNk87Hq3swmbSp3x/UImT9S6t9D9NE3Um01HqRgfStYcw94GqQRuAKKyrb85AcTc qLr+MICprafFrnUyAQqe58Q2lgh7tKUJuEd3ZqFrLaOYLm0LkkIpXQ6jjwoSS5Kia5z3 qYtDtU+Q5tWNXyXzyOi6HGWbNLF3P94X8otwzEO3ha6UJmufZdcodFTtf5QF8LZhHX33 vnpkEHP+ZofqNA5A/sDaDIN8s9KUp4efDhw6LBX7X9CRby8vgLD8iaC43vqsS4EqKiRY X8Hw== X-Gm-Message-State: AGi0PuYKsDdb3UcecxJsvoiPj4xlsxbK4QDhCc/A2jG4n+3fPecQMyIV nw34Wxo39hcM1qNytM56uRyHnQ== X-Google-Smtp-Source: APiQypLlrrLFKBShNnNVF90buqGFklh0fnoXQOu7te0s+VgmO3xy05UxmrY5DdaE5ky534ULac25jA== X-Received: by 2002:a37:ac08:: with SMTP id e8mr4618592qkm.439.1588974993311; Fri, 08 May 2020 14:56:33 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:2627]) by smtp.gmail.com with ESMTPSA id x8sm2438260qti.51.2020.05.08.14.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:56:32 -0700 (PDT) Date: Fri, 8 May 2020 17:56:16 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Mel Gorman , Roman Gushchin , Michal Hocko , Andrew Morton , Yafang Shao , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: swap: memcg: fix memcg stats for huge pages Message-ID: <20200508215616.GD226164@cmpxchg.org> References: <20200508212215.181307-1-shakeelb@google.com> <20200508212215.181307-2-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508212215.181307-2-shakeelb@google.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 08, 2020 at 02:22:14PM -0700, Shakeel Butt wrote: > The commit 2262185c5b28 ("mm: per-cgroup memory reclaim stats") added > PGLAZYFREE, PGACTIVATE & PGDEACTIVATE stats for cgroups but missed > couple of places and PGLAZYFREE missed huge page handling. Fix that. > Also for PGLAZYFREE use the irq-unsafe function to update as the irq is > already disabled. > > Fixes: 2262185c5b28 ("mm: per-cgroup memory reclaim stats") > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner