From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CADC2C38A2A for ; Fri, 8 May 2020 21:52:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8983321655 for ; Fri, 8 May 2020 21:52:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="1rm4qMVb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8983321655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 24C1890001F; Fri, 8 May 2020 17:52:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FB2F90001C; Fri, 8 May 2020 17:52:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 138AA90001F; Fri, 8 May 2020 17:52:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id F08D990001C for ; Fri, 8 May 2020 17:52:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B29398248068 for ; Fri, 8 May 2020 21:52:46 +0000 (UTC) X-FDA: 76794901932.14.sink46_6f80f7830f60f X-HE-Tag: sink46_6f80f7830f60f X-Filterd-Recvd-Size: 3479 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 May 2020 21:52:46 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id r3so1591401qvm.1 for ; Fri, 08 May 2020 14:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/Bg23MpwaLt5ES1Q90+CSXO9u0G+8VEy9TthqACk8pE=; b=1rm4qMVbcyKhgRbqDol38rBrkbyaZbxpfkXsQfwESaWUofm9FQVmK/wxaUfeIUZygo HsGYt09Ll+D1Q0/NDvGuVng7N+gAh0575gb8z6n8u+dxMoQHoC1vfOYVhf68hgZoLvhb LvTWV94B9ObgkjWuVKW+yxNPICHdMTrcOc92uPtwZpCy5PSiU0iklgWmIEx1+ny+Lmdp r8n9oZQHT856fp9eRfvxZU5UPwlEyFophlObXiv3bFFtElwVs1Cw9q3D149s40LMK8a/ ZWmePp2TvUuF/ICL2KJQ7+1+jY2pq+wlkDiMsN/8bp0c8W/1W2ZxCweHg7a/K6x7WB9D NnLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/Bg23MpwaLt5ES1Q90+CSXO9u0G+8VEy9TthqACk8pE=; b=C7wCHNbA8YjkUL+dg1JqpXWJg1kTTKNwnaHwIOzW0nkgo6Ov5HF9fcBUB9yw8CZfmt Xs6c/RN4WfW1wtmtvuI0yI6NbKx7uQ0SavDUMDcMR6+Ot2T6qzMTrihKHYX+1ac+vn/f 4ybMAC/kxu1hI0Zs52b42K/pPIAJHU3DiXGnMSIgLjQNH0S9bgrbOy/nHKQ82abPO0aJ b/L/J2ncBCJ4hVBFjIQzMXuF44HPN5rzntwnElmH778+gB3xxCOKau2BVEXQR8qjrsuE 6sLum3UrLSksG3HfHmtiGP/95IP06W/Igs82aCZ23MlzAhjc9OFHzGSrpnxm8hzyRO+E gr8Q== X-Gm-Message-State: AGi0PubokxOFfywXNKxS7GIcGPnICmHOKTogQD+Ks5GSSx55b9HsvsK+ D/MfiixVD41VyQo1LqXF41XQlg== X-Google-Smtp-Source: APiQypKmtl+1oHPPWXjPwav7h15WBhj4HMNp31tMAisZWuYqEd91uBiMzUO1EmthvbIEeETVN6J6bg== X-Received: by 2002:a0c:f8c4:: with SMTP id h4mr4924155qvo.15.1588974765599; Fri, 08 May 2020 14:52:45 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:2627]) by smtp.gmail.com with ESMTPSA id m7sm2547075qti.6.2020.05.08.14.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:52:45 -0700 (PDT) Date: Fri, 8 May 2020 17:52:28 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Mel Gorman , Roman Gushchin , Michal Hocko , Andrew Morton , Yafang Shao , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: swap: fix vmstats for huge pages Message-ID: <20200508215228.GC226164@cmpxchg.org> References: <20200508212215.181307-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508212215.181307-1-shakeelb@google.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 08, 2020 at 02:22:13PM -0700, Shakeel Butt wrote: > Many of the callbacks called by pagevec_lru_move_fn() do not correctly > update the vmstats for huge pages. Fix that. Also __pagevec_lru_add_fn() > use the irq-unsafe alternative to update the stat as the irqs are > already disabled. > > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner