From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F5DC47257 for ; Thu, 7 May 2020 17:34:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F172020735 for ; Thu, 7 May 2020 17:34:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qd+juih3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F172020735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4867D900004; Thu, 7 May 2020 13:34:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 436B7900002; Thu, 7 May 2020 13:34:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FEEA900004; Thu, 7 May 2020 13:34:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 18183900002 for ; Thu, 7 May 2020 13:34:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D174A180ACF75 for ; Thu, 7 May 2020 17:34:49 +0000 (UTC) X-FDA: 76790623098.30.jelly85_816cbb9930c13 X-HE-Tag: jelly85_816cbb9930c13 X-Filterd-Recvd-Size: 4503 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 May 2020 17:34:49 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id u15so7249510ljd.3 for ; Thu, 07 May 2020 10:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JblqVDATbZ3VyIvCxA3kiBa3Vh0aMkYFRj7d4ibwanQ=; b=Qd+juih32c1McgBhlvcJ2zTUWqnpu3lhRsglBhog+dnClNU9YdNIfNNRv28DVjhEXW ev/++sR1sVi6W6dzuunGz4k4nQCt2AZML6YrVQkuvXX09nGoPtD9Qj4EYOk3Cf+ytlkL jnpVTg0Hr+MU0yTuCZccX29G/3pxt4BeD8x+ymUe6VilPzUq7vCc/m7eGgdBlPiSEHpl iskCWvu/D/8jJCPyKCygywV+KtotbPCmXpMxBsoEd5nvF/utgJuFmqyPTJHDvudyx8o6 rasH6PrgKDbK2pyAP5DWo1u6F9iDtrudIew76gE9w72MR7A6Dnc2/LRqRJLuWb9lZptm VRdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JblqVDATbZ3VyIvCxA3kiBa3Vh0aMkYFRj7d4ibwanQ=; b=lHlUAhkgGJfcGYSsHZHjf7HkkoLb9bY7WpAOz8PjyjpY45XpG6kcF2kMPfNvPeRYPi ZrhVub2wB2yLu1mXUioRUjNjBy4A01rQ2po7ruYO7ykn14mbP74rI5kS4g3GHTxvN6Md 48UnSJxB0Du55KwcJozCuQotM95DpuVswqSV5A/8nuZKrs5EHznmnw8PYl1sAwLhKy1l d4ebiqZgW4x36+zn+3QVGs/8ZGoHePzqFgY0i2xvKrkclQVZm/c8eE7rChcqSULnFwkJ nD8k5/BZqf1V/kWUKRdeLDDPfcKZ0IxtRW98NIm/bAadPbUNDRZUBY0Pi4BA3+QzAzY3 GajA== X-Gm-Message-State: AGi0Pua4tCj2sWwRUrYH0K9FTbTzUV1hgi0AmPnsmHOuuaQYBtptXebs OSzzWVKB1njzGRIc0cdUsr8= X-Google-Smtp-Source: APiQypKqpQXM/zFtg4moCRPqI6xRMf3DiK/mjpH/2Y+LT9h9tt/th8WCm3OO36y1LBZY0aJkUaR0hg== X-Received: by 2002:a2e:a365:: with SMTP id i5mr8938424ljn.293.1588872887741; Thu, 07 May 2020 10:34:47 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id i3sm3650533ljg.82.2020.05.07.10.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 10:34:46 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 7 May 2020 19:34:44 +0200 To: "Paul E. McKenney" Cc: Uladzislau Rezki , Joel Fernandes , LKML , linux-mm@kvack.org, Andrew Morton , "Theodore Y . Ts'o" , Matthew Wilcox , RCU , Oleksiy Avramchenko Subject: Re: [PATCH 21/24] rcu/tiny: move kvfree_call_rcu() out of header Message-ID: <20200507173444.GA12883@pc636> References: <20200428205903.61704-1-urezki@gmail.com> <20200428205903.61704-22-urezki@gmail.com> <20200501230359.GH7560@paulmck-ThinkPad-P72> <20200506182902.GA2570@pc636> <20200506184548.GE2869@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506184548.GE2869@paulmck-ThinkPad-P72> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > > Please see full log here: ftp://vps418301.ovh.net/incoming/include_mm_h_output.txt > > > > I can fix it by adding the kvfree() declaration to the rcutiny.h also: > > extern void kvfree(const void *addr); > > > > what seems wired to me? Also it can be fixed if i move it to the tiny.c > > so it will be aligned with the way how it is done for tree-RCU. > > If the mm guys are OK with the kvfree() declaration, that is the way > to go. With the addition of a comment saying something like "Avoid > #include hell". > > The compiler will complain if the definition changes given that there > has to be somewhere that sees both the above and the real declaration, > so this should not cause too much trouble. > > > Any valuable proposals? > > Otherwise, yes, the function would need to move to tiny.c and thus add > bloat. :-( > OK. I will declare it one more time. Indeed if it is changed, the compiler will emit some errors. Also, i will add some comments why it is done. Thanks! -- Vlad Rezki