From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64642C38A2A for ; Thu, 7 May 2020 17:52:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A6E320643 for ; Thu, 7 May 2020 17:52:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UhhAvyj4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A6E320643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D2C23900005; Thu, 7 May 2020 13:52:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB615900002; Thu, 7 May 2020 13:52:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5667900005; Thu, 7 May 2020 13:52:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 9787A900002 for ; Thu, 7 May 2020 13:52:25 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4E57C180ACF61 for ; Thu, 7 May 2020 17:52:25 +0000 (UTC) X-FDA: 76790667450.13.woman32_8986840d3ee0c X-HE-Tag: woman32_8986840d3ee0c X-Filterd-Recvd-Size: 3257 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 May 2020 17:52:24 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id hi11so2963614pjb.3 for ; Thu, 07 May 2020 10:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4xL4qCa/9s26UIoiJohUrv19oF5tpl0O53OyxD/cm4Y=; b=UhhAvyj4mHH32QJxuxUMjF/7MBpTbO2V7BzXH+drxAqVU1Cet9Uwtddk0wRtR7B3qy hW65DgYVJ3haf0tOlCt/8wA8qTXRjt59PXiOxIHBFtZ6u9y02NHuz92XK5UsZvX6yCgm hBznr/OMaqrgWU78lPZVqJ2RiFBL4KCAywVYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4xL4qCa/9s26UIoiJohUrv19oF5tpl0O53OyxD/cm4Y=; b=jeTUJhunriWSOZoGu7BlOnmoO77MrqmP5sm9PvEsu7TYSFOoSyor0G9S7Bk1ySaGIP 3w74wqR2OvnUVm0TLJlj5naR/N8onsA0vy9mdeZhgkjX96hDoJ92OknQnaeC4FXJdKzS viTAGcr4afb5KhehZ9dS7+eNnXARVtYFbqkf+RXI//jVdyZaXMDP4IDTJYeWKBoDbxFb q2iOLwVc3nlLl8qfgi1oyDXdZMbDbIy0IfmAty/2FJj5gLWKf3nSX/D+7W8Xem/IWFCp lhzEnJ0FNqdH0+8nPDmWB0QXQPEVZTkKVIhFqnj6F0Mlz68QnZaCa8SqiQmORWCUZDmP kCmw== X-Gm-Message-State: AGi0PuZcCs4CEXyCNYMPabk1mkUP5VBpb874wFOo99P8oL4NEau2icKP rcv0IaPA1Alhq0PVRNg1p9rnjA== X-Google-Smtp-Source: APiQypIVFtu6ODMFqOmgpEGjuYzYeF05nLLy0dHAEVQxFjNwaL8oFcXIYIe3aR74PKDZ/kzfd4UcUQ== X-Received: by 2002:a17:902:5996:: with SMTP id p22mr13840844pli.153.1588873943970; Thu, 07 May 2020 10:52:23 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b9sm5429988pfp.12.2020.05.07.10.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 10:52:23 -0700 (PDT) Date: Thu, 7 May 2020 10:52:22 -0700 From: Kees Cook To: Luis Chamberlain Cc: cl@linux.com, akpm@linux-foundation.org, arnd@arndb.de, willy@infradead.org, aquini@redhat.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: expand documentation over __read_mostly Message-ID: <202005071052.1522C624@keescook> References: <20200507161424.2584-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507161424.2584-1-mcgrof@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 07, 2020 at 04:14:24PM +0000, Luis Chamberlain wrote: > __read_mostly can easily be misused by folks, its not meant for > just read-only data. There are performance reasons for using it, but > we also don't provide any guidance about its use. Provide a bit more > guidance over its use. > > Acked-by: Christoph Lameter > Signed-off-by: Luis Chamberlain Reviewed-by: Kees Cook -- Kees Cook