From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD19EC28CBC for ; Wed, 6 May 2020 16:18:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C66C206DB for ; Wed, 6 May 2020 16:18:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="CDYYUXVy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C66C206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B96A8E0005; Wed, 6 May 2020 12:18:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 991948E0003; Wed, 6 May 2020 12:18:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87FEC8E0005; Wed, 6 May 2020 12:18:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 6E2E98E0003 for ; Wed, 6 May 2020 12:18:27 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1F454180AD806 for ; Wed, 6 May 2020 16:18:27 +0000 (UTC) X-FDA: 76786801854.16.kitty31_83f4163edac5a X-HE-Tag: kitty31_83f4163edac5a X-Filterd-Recvd-Size: 5139 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 May 2020 16:18:26 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id o16so1450646qtb.13 for ; Wed, 06 May 2020 09:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dI/8k01wqNtPsEMN3JryPuexKMUAM9GFAPsiKlMJOgs=; b=CDYYUXVytFKURB46DxLbtSQhLKEUVHOamKg4N6ws/VeYuZqe48aW2fVU4DY/h9Bp0C oxPsar9OJVyyfKYewl2b61UAK/iYMJhUOEztf6FyAWUPWMHx6K52Ms3zjFawc0T82Nl1 7Xt+P1aPijxMvudfHiyJNFg5C9ZFGxb7Xq5W8dbwJ21FJwxC/q1Blc/Rw7qi4EBtZ7QU QsgB9ERVVjUURncAAw80TIEnHnDpJ9Brzd9+PloSZTbvOPoos60r/CIiiaGLTHr18jlp z1hKejvJ2XMgEhTqjmxxET3DODSbvUQWlTA4t/TK35N6seBmGymATrWanur938yEOAM8 A/+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dI/8k01wqNtPsEMN3JryPuexKMUAM9GFAPsiKlMJOgs=; b=TpI29QgWJknCjJfJpzuS4/9QNgwuWGPRONXYUu/g41WVZXBSoj3SvXIiPVx1oj5JvZ e7ZPZxWMq489e21ZhpDkMdaKzWhC848FlEGUm7RjPNfaLM4T4fGlYK9usB9dQ8fbB2D4 zEFf7pH+4EQ8x3jgqbKRAruEqrmnKC6ZMKE4rxJ6RX6KQPBijUmv2y7MDLLmYYcJc86K gkLlXElkS8Emt14Ue4n2RnTEzm7lNh2CKFYA3NRcpsgyjfNHNql478GwrCwbRWv0DY5M 3Mgo3ubP6KAoUeMS3kfCWdCIEnAz28X5KCbsZ5/0HmgDxoD1t3IynNQNDdZcOXYCU2/m B4yg== X-Gm-Message-State: AGi0PuaWWf0OktbeeuTyX+zMidLOis96tbCRVVasx9dQsgbvmmAecToP irz2cgFR41gT941MJYYKCUQSSA== X-Google-Smtp-Source: APiQypKyDRDNEzprm+gsfACpH0aQyfocl+/L2XhuNJKEuZItD8tyLPJ84MVvdGkrVM9/6D8550tNkg== X-Received: by 2002:aed:2e83:: with SMTP id k3mr9101168qtd.2.1588781906015; Wed, 06 May 2020 09:18:26 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id h13sm1895261qti.32.2020.05.06.09.18.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 May 2020 09:18:25 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jWMka-0002ut-Lq; Wed, 06 May 2020 13:18:24 -0300 Date: Wed, 6 May 2020 13:18:24 -0300 From: Jason Gunthorpe To: Ralph Campbell Cc: linux-mm@kvack.org, Alex Deucher , amd-gfx@lists.freedesktop.org, Ben Skeggs , Christian =?utf-8?B?S8O2bmln?= , "David (ChunMing) Zhou" , dri-devel@lists.freedesktop.org, Felix Kuehling , Christoph Hellwig , intel-gfx@lists.freedesktop.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , John Hubbard , linux-kernel@vger.kernel.org, Niranjana Vishwanathapura , nouveau@lists.freedesktop.org, "Yang, Philip" Subject: Re: [PATCH hmm v2 5/5] mm/hmm: remove the customizable pfn format from hmm_range_fault Message-ID: <20200506161824.GG26002@ziepe.ca> References: <5-v2-b4e84f444c7d+24f57-hmm_no_flags_jgg@mellanox.com> <3c06a94c-c17f-dc31-537e-f3f6e1ace9a2@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c06a94c-c17f-dc31-537e-f3f6e1ace9a2@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 01, 2020 at 05:53:26PM -0700, Ralph Campbell wrote: > > Acked-by: Felix Kuehling > > Tested-by: Ralph Campbell > > Signed-off-by: Jason Gunthorpe > > Signed-off-by: Christoph Hellwig > > Documentation/vm/hmm.rst | 26 ++-- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 35 ++---- > > drivers/gpu/drm/nouveau/nouveau_dmem.c | 27 +--- > > drivers/gpu/drm/nouveau/nouveau_dmem.h | 3 +- > > drivers/gpu/drm/nouveau/nouveau_svm.c | 87 ++++++++----- > > include/linux/hmm.h | 99 ++++++--------- > > mm/hmm.c | 160 +++++++++++------------- > > 7 files changed, 192 insertions(+), 245 deletions(-) > > > > ...snip... > > > +static void nouveau_hmm_convert_pfn(struct nouveau_drm *drm, > > + struct hmm_range *range, u64 *ioctl_addr) > > +{ > > + unsigned long i, npages; > > + > > + /* > > + * The ioctl_addr prepared here is passed through nvif_object_ioctl() > > + * to an eventual DMA map in something like gp100_vmm_pgt_pfn() > > + * > > + * This is all just encoding the internal hmm reprensetation into a > > s/reprensetation/representation/ > > Looks good and still tests OK with nouveau. Got it, thanks Jason