From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 639A3C47257 for ; Wed, 6 May 2020 15:15:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2828121582 for ; Wed, 6 May 2020 15:15:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="j02Wa7Yl"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="Zza1lo/8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2828121582 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=fb.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C2FA8E0005; Wed, 6 May 2020 11:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94B978E0003; Wed, 6 May 2020 11:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8132F8E0005; Wed, 6 May 2020 11:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6579E8E0003 for ; Wed, 6 May 2020 11:15:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 22FF814527 for ; Wed, 6 May 2020 15:15:24 +0000 (UTC) X-FDA: 76786642968.02.berry01_11f0f5d85265a X-HE-Tag: berry01_11f0f5d85265a X-Filterd-Recvd-Size: 8734 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 May 2020 15:15:23 +0000 (UTC) Received: from pps.filterd (m0109334.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 046FFGmX012551; Wed, 6 May 2020 08:15:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=facebook; bh=tYBzfX23110uOo0lEuSDqe1eLFlWnw71AxbUalix7zw=; b=j02Wa7YlpqCMB69+YvOy8Jnz+uKVgMNIWsOGuFyLrruh1I1qmjOno7NNIcH3VK12r0Wm jTR5GIPLwMM/xaApr6TA88Zb6PXEahynh99JczVk0yON9P/bdceV7G6MdS1hh4KMdVLT BViOaxKC66KsWPldrN3z/Dbg+e7U/8rt5qs= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 30srw01uhv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 06 May 2020 08:15:14 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (100.104.98.9) by o365-in.thefacebook.com (100.104.94.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Wed, 6 May 2020 08:14:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SV/JDS9GzOhUhE+anabtE5OZp9mOUG+rBwqYzd6OYuLd5q2Izj1xe/n8k5omVMeSiHVaDrm7yXiAd9Qa0RvtH4IZTJWKO7SRkJhuFscBXWNYP+L0yuWQARhftZtyfz2r/ZVX69khfqcmQt9jiq3I1DHihbXTo5gnXZ5ZhMyv3FDCGTKbx2Wq7+kgZWLa0iIkUeEuI87bsWwFK0TcSFZUE2iqGrf9jgoh+4uWSbupecgT/Nx5ELmvFkc435TYAzc42bbEqiOuTnehBIMuVondtyNEErkVViwQlqrEzefaNiInAlcoCCnRGbrJ0JDqbLXVMseIZsSfq/wsbJi+8PF+0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYBzfX23110uOo0lEuSDqe1eLFlWnw71AxbUalix7zw=; b=GHfq438oWMUkFS8nQ6naRsRjQ3ubI0AT+1F7E4lFqCyeTf7t0AiqUYilB++GdwQxVtK9Ef9I5KYkjazsu7kpAiXf4NMxl+rGXx7IOCjRFlagSKImaWoZl1XCvbAu2IwVdftP6TTfWJehEm/e6lX02Rtx1dkKf/xJJEmejiJqtfor4oSgcq2B+/r11Sow4G7m0tEuLGb5Nky2IX/AhUtB9QdaTjnXYpZvav+Q3DKreQUThsVkaAVY+bgM05SdkTyatuE1z55XU3vxpkrLJnCrnzEdEj2RlTLVUfoBYHPA+KBqt4/v3iIcXgFwVEad2rOKZIYlXzPcy8uh33F3Ahq8Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector2-fb-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYBzfX23110uOo0lEuSDqe1eLFlWnw71AxbUalix7zw=; b=Zza1lo/8mLqcCWLspTQECs2ZklkwvlWlY/4hY1+p97dDFjcmXIbO3/gAhJSDe3eUUFWDMYh37Qb6yNfakgI/N+tjMpe9DCtKD0GrYL2CDey5Nrg0ot7NfJiNNApObp7ueQS59lWLqc5FbfswyrT99ye/zg7jaZ1ASTu/v090DSA= Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=fb.com; Received: from BYAPR15MB4136.namprd15.prod.outlook.com (2603:10b6:a03:96::24) by BYAPR15MB2741.namprd15.prod.outlook.com (2603:10b6:a03:156::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Wed, 6 May 2020 15:14:37 +0000 Received: from BYAPR15MB4136.namprd15.prod.outlook.com ([fe80::bdf9:6577:1d2a:a275]) by BYAPR15MB4136.namprd15.prod.outlook.com ([fe80::bdf9:6577:1d2a:a275%7]) with mapi id 15.20.2979.028; Wed, 6 May 2020 15:14:37 +0000 Date: Wed, 6 May 2020 08:14:34 -0700 From: Roman Gushchin To: Shakeel Butt CC: Michal Hocko , Johannes Weiner , Andrew Morton , Linux MM Subject: Re: Query on PGREFILL, PGSCAN and PGSTEAL Message-ID: <20200506151434.GB4687@carbon.lan> References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BYAPR07CA0041.namprd07.prod.outlook.com (2603:10b6:a03:60::18) To BYAPR15MB4136.namprd15.prod.outlook.com (2603:10b6:a03:96::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from carbon.lan (2620:10d:c090:400::5:5157) by BYAPR07CA0041.namprd07.prod.outlook.com (2603:10b6:a03:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Wed, 6 May 2020 15:14:37 +0000 X-Originating-IP: [2620:10d:c090:400::5:5157] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4e7b0fa-c6c6-47b8-0b94-08d7f1d0311d X-MS-TrafficTypeDiagnostic: BYAPR15MB2741: X-Microsoft-Antispam-PRVS: X-FB-Source: Internal X-MS-Oob-TLC-OOBClassifiers: OLM:626; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3FbfmedG+KfBEBy93dhRP2dq1ntlDT+yS4IJag1/0ROrCw+pxXuaDPsh2F/XioRjauRLv4A4wmc8SblP/IAFnc8s7Whudu1yc07Qhf7TQTjMvI+5tGDAV2ZGmeQpdfjjkMg+p5WeWY644IJFlxx/6xlmXlbPtnt3JU1Xx4r+n2nw/jeAGYWa8Li6rmqSMmDdGPmAHrS8M7NSgy6/HxlodBgakR6WZn0IcHLWlsgRyvqRTljWoHB9wzVXeMZ80G2tuo9jwO+5diSjfdVH6LAB0ZqDkUCoAIxEA57NDDHVTBYJRxFrvf2UdWrI0/sslMpru5Oy9XGogGmhGInxwq/3RU8SIobiYHzUtQtB82Ig+UBvzE8tjK6XWj1H6fo85qQpz4h5absYZb5KmHbaOAk4AGlCpVnOqxoRNTdCf25KXqcblsYjgZWAMvGmEciP19ZmWeK/76LvC/Z9XNmm7d5T3L6U9NhJRA3qxnki8f+PcAryUY8UJIZWqTob+8uUPWbWiRq4r0XGCZRgh0wkoo0s1A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(396003)(136003)(39860400002)(366004)(376002)(33430700001)(16526019)(8936002)(5660300002)(7696005)(6666004)(86362001)(54906003)(52116002)(4326008)(4744005)(186003)(33440700001)(9686003)(1076003)(55016002)(36756003)(2906002)(6506007)(66476007)(66946007)(33656002)(8676002)(8886007)(6916009)(478600001)(66556008)(316002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 4jLv324hkIAcPB9NILkZbQ2L8gvoXwvjpOw3oEk7zd0Ckg7aYPEKwoq0XAt5MdP+XDIwE62KE0vfbOuj71k8sL3fydS36HVHf3J6kJlehwalP0tQDOnyMs34uJYTflBQROsZaJMqH4ISf5yCF59jRTcEekruHNockeV2G78WPYdJLMILTm6YksJE7OCacCLuwJoFXlvS+4+FJAohgnnSkT6K9ItOBdtye6H6wwbETZuL8FEP3U/Z3QSCaKxVC6oqzWHfG0DwRFRaECz+MrpQqIuFIImp3TOIicdepRbB7X3Bq8nMn9VR8F+Ikw3a5BCfd6gSiPmhIr31CKbtenRg77fNx6lLCsLRZmdVQgO9CKGvMymOa9FN4UW59reWnUHtMPGqcS8+mYDkGU39FlMhmANMCUgRT/Q3SfwmTGVRVRwkA+irx6lqarnBJtGmSlb5RFlZiWBzsEmmhzbI6yXIEMszJ5kkwB+UV4ZrsHaTrcYLk1MNM5pd07On4GU6PeNEsetbZ98BJWkEnipy9G/lMg3J5idRx+/NM3B/g2NaZnP1/RU6hrIPZTVWYYPXYZ8cIhNeqrEzLlDN7TAi5P4KjUtUkpeSJT1DqavZSiZzuRQIj+vQgbO7UoPHVXbVE7RPLrsLT+NZMtdZCYHBkV6MGgsrxclOJzhPnZEMK91niJK8gW4iUfTS/SX4oH2xKZHMypJnJg12nxy+eRoa2YXqWT9MVekjr+/69TxafxtT8wiI/mfw32b/fFVOEhXQp9TXKz9E7UImrv85XV3dXxT1EP1sSLo5P7XW/wK+8bYM/kF7q5Brzo6NrCl5T3qrBIBt/9sF7Q8UuTJ+Wio96h2LtQ== X-MS-Exchange-CrossTenant-Network-Message-Id: d4e7b0fa-c6c6-47b8-0b94-08d7f1d0311d X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 15:14:37.7702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LQFvw6Yn+7DIyndPZXkICM888DLih/gIU2JrlQGrOJGHHHxdoU8Xcsr8Bo9azHdA X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2741 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-05-06_08:2020-05-05,2020-05-06 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 adultscore=0 malwarescore=0 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 suspectscore=1 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005060124 X-FB-Internal: deliver X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 06, 2020 at 07:34:16AM -0700, Shakeel Butt wrote: > Hi Roman, > > The commit 2262185c5b28 ("mm: per-cgroup memory reclaim stats") added > the memcg reclaim stats. However for the global PGSCAN and PGSTEAL > counters it restricts them to be updated only for global reclaim while > the PGREFILL global counter is updated for both global and cgroup > reclaim. Is that intentional? Hello, Shakeel! It looks like it was so long before 2262185c5b28. And I don't know any particular reason for it. I guess it was unintentional. Thanks!