From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D5EC47247 for ; Tue, 5 May 2020 12:10:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D56B9206A4 for ; Tue, 5 May 2020 12:10:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XofyCUGf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D56B9206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C63458E00C5; Tue, 5 May 2020 08:10:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEC158E00C0; Tue, 5 May 2020 08:10:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADB058E00C5; Tue, 5 May 2020 08:10:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 931208E00C0 for ; Tue, 5 May 2020 08:10:51 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5616A18EED for ; Tue, 5 May 2020 12:10:51 +0000 (UTC) X-FDA: 76782549102.17.space24_5ebcf4ca5303d X-HE-Tag: space24_5ebcf4ca5303d X-Filterd-Recvd-Size: 2620 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 May 2020 12:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1l+GyMaj5ngxaPJrqDJo+9L5X5yBFW27xzweVKqFpAY=; b=XofyCUGf4B51GP0D9K0P/MUgA7 UGOcsycb32rFn1/tzyeuK2C5kl5aYTYhR1hdA34qBj/CdaW8k9iixBLYFY1sMvapHKF7iCI/n9hMd u0SRCb5VsvLPvl0vktX+FILSgqLXmyjjSJT0X7kFECt0s5Y3ROakGlMBwvc4P3ejUTKHEf5Qn5REw UjcgW3pE4VET0u7df/2+upNK6NoXV7hFAItPFqhsWfLrAle0s4jgm4Z48lwsDDt5LLxQ8o7EkIocX ROnL+X96xrqizbaX5XyQd5YVngRdYa9+0I2meVfsRw9wy3/Nb3qmzTPy4QOe0awkhVC2cQ2wZzu7v YIbh/Rag==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVwPL-0004tR-Mq; Tue, 05 May 2020 12:10:43 +0000 Date: Tue, 5 May 2020 05:10:43 -0700 From: Matthew Wilcox To: Zhen Lei Cc: Minchan Kim , Nitin Gupta , Sergey Senozhatsky , Jens Axboe , linux-block , Andrew Morton , linux-mm , Alasdair Kergon , Mike Snitzer , dm-devel , Song Liu , linux-raid , linux-kernel Subject: Re: [PATCH 1/4] block: Move SECTORS_PER_PAGE and SECTORS_PER_PAGE_SHIFT definitions into Message-ID: <20200505121043.GG16070@bombadil.infradead.org> References: <20200505115543.1660-1-thunder.leizhen@huawei.com> <20200505115543.1660-2-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505115543.1660-2-thunder.leizhen@huawei.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 05, 2020 at 07:55:40PM +0800, Zhen Lei wrote: > +#ifndef SECTORS_PER_PAGE_SHIFT > +#define SECTORS_PER_PAGE_SHIFT (PAGE_SHIFT - SECTOR_SHIFT) > +#endif > +#ifndef SECTORS_PER_PAGE > +#define SECTORS_PER_PAGE (1 << SECTORS_PER_PAGE_SHIFT) > #endif I find SECTORS_PER_PAGE_SHIFT quite hard to read. I had a quick skim of your other patches, and it seems to me that we could replace '<< SECTORS_PER_PAGE_SHIFT' with '* SECTORS_PER_PAGE' and it would be more readable in every case.