From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A67CC3A5A9 for ; Mon, 4 May 2020 15:51:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDE74206B9 for ; Mon, 4 May 2020 15:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="WoJd9vGx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDE74206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8A1758E0054; Mon, 4 May 2020 11:51:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 878E18E0024; Mon, 4 May 2020 11:51:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 790208E0054; Mon, 4 May 2020 11:51:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 5E4838E0024 for ; Mon, 4 May 2020 11:51:20 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2017C1269 for ; Mon, 4 May 2020 15:51:20 +0000 (UTC) X-FDA: 76779475920.24.sign00_45d37151d6052 X-HE-Tag: sign00_45d37151d6052 X-Filterd-Recvd-Size: 3200 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 15:51:19 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id x18so21587807wrq.2 for ; Mon, 04 May 2020 08:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BDtWVUXPt3frFkYBTLTW7Ug2yxO9rVQDt3L/y+xwZuw=; b=WoJd9vGxvyhoMGsM5gtjLbvSwgL3wNNk8avihDqBCSJ8tk3B/bDJEdolWyJviBRw9y dyWRbcays2xQDPGpddLRhTIpM3iAFaW3LzbyuGxi7uimg6rWu4CKWmVMA3AqYt7ZzToJ 0ivfpmh2TJQyAouaniuesyNQCqJX4Ne1SgcD0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BDtWVUXPt3frFkYBTLTW7Ug2yxO9rVQDt3L/y+xwZuw=; b=rEXYOCO42oew8c0cBoT8r+GxUM3A3wcfrln86LJbdfccs9X+4sI9ZYmRYBG24y5Fqj yaxc0PhFSS9PNT7vR6lQFvQ3TNAL0MvzONwBpEGctY5OqNE/NKtDLc2uxd5GXXPbHrak dtgXcBBy57OIF/qdmjAZBK5bgEBFtx2vwGM36/pF9NVh98MKtCyP7dQ6gzvT2e7v1QwM 5XD79h2Dz9TkbyGqhR8KMmfUcp7K+Sf/ieDfkCvUb4eExgs0ZNCNdYplrkZQJ3psF3za QS9znRJDIzt3RdgWi/LDoY3y2Z+3iz9rOZvVfrPjaD2Xx7E0hBBuN11fmrVJ/geFYL3S riCA== X-Gm-Message-State: AGi0Pua2K0nvTOfzDWw/j4JfgdMw356fNlXUyshVpijHWPsxczPu7CLT F9GGsG7igXWOL3B/YRb5AvvrOg== X-Google-Smtp-Source: APiQypKxvXZGJ208ttIpkp5LQh0psXa1iWT0est+r28WzCQ5GbvSTF/82ZDcY5qNiNlKeEw8pd20XA== X-Received: by 2002:adf:d0d1:: with SMTP id z17mr7421146wrh.295.1588607478669; Mon, 04 May 2020 08:51:18 -0700 (PDT) Received: from localhost ([2620:10d:c092:180::1:2028]) by smtp.gmail.com with ESMTPSA id n21sm6081961wra.15.2020.05.04.08.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 08:51:18 -0700 (PDT) Date: Mon, 4 May 2020 16:51:17 +0100 From: Chris Down To: Yafang Shao Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm, memcg: add workingset_restore in memory.stat Message-ID: <20200504155117.GB271310@chrisdown.name> References: <20200504153522.11553-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200504153522.11553-1-laoar.shao@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yafang Shao writes: >There's a new workingset counter introduced in commit 1899ad18c607 ("mm: >workingset: tell cache transitions from workingset thrashing"). With the >help of this counter we can know the workingset is transitioning or >thrashing. To leverage the benifit of this counter to memcg, we should >introduce it into memory.stat. Then we could know the workingset of the >workload inside a memcg better. Looks fine, thanks! Acked-by: Chris Down