From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CFBFC3A5A9 for ; Mon, 4 May 2020 12:44:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 395B12071C for ; Mon, 4 May 2020 12:44:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 395B12071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BEC318E0008; Mon, 4 May 2020 08:44:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9CE78E0003; Mon, 4 May 2020 08:44:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB43B8E0008; Mon, 4 May 2020 08:44:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 934BE8E0003 for ; Mon, 4 May 2020 08:44:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5D46910EF6 for ; Mon, 4 May 2020 12:44:14 +0000 (UTC) X-FDA: 76779004428.13.cup42_24e24b50ae821 X-HE-Tag: cup42_24e24b50ae821 X-Filterd-Recvd-Size: 3445 Received: from outbound-smtp58.blacknight.com (outbound-smtp58.blacknight.com [46.22.136.242]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 12:44:13 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp58.blacknight.com (Postfix) with ESMTPS id 51B15FACCC for ; Mon, 4 May 2020 13:44:11 +0100 (IST) Received: (qmail 21279 invoked from network); 4 May 2020 12:44:11 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.18.57]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 4 May 2020 12:44:11 -0000 Date: Mon, 4 May 2020 13:44:09 +0100 From: Mel Gorman To: Andrew Morton Cc: Henry Willard , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Limit boost_watermark on small zones. Message-ID: <20200504124409.GB3758@techsingularity.net> References: <1588294148-6586-1-git-send-email-henry.willard@oracle.com> <20200501155729.a479c4b27f127d9aa866bd8e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20200501155729.a479c4b27f127d9aa866bd8e@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 01, 2020 at 03:57:29PM -0700, Andrew Morton wrote: > On Thu, 30 Apr 2020 17:49:08 -0700 Henry Willard wrote: > > > Commit 1c30844d2dfe ("mm: reclaim small amounts of memory when an external > > fragmentation event occurs") adds a boost_watermark() function which > > increases the min watermark in a zone by at least pageblock_nr_pages or > > the number of pages in a page block. On Arm64, with 64K pages and 512M > > huge pages, this is 8192 pages or 512M. It does this regardless of the > > number of managed pages managed in the zone or the likelihood of success. > > This can put the zone immediately under water in terms of allocating pages > > from the zone, and can cause a small machine to fail immediately due to > > OoM. Unlike set_recommended_min_free_kbytes(), which substantially > > increases min_free_kbytes and is tied to THP, boost_watermark() can be > > called even if THP is not active. The problem is most likely to appear > > on architectures such as Arm64 where pageblock_nr_pages is very large. > > > > It is desirable to run the kdump capture kernel in as small a space as > > possible to avoid wasting memory. In some architectures, such as Arm64, > > there are restrictions on where the capture kernel can run, and therefore, > > the space available. A capture kernel running in 768M can fail due to OoM > > immediately after boost_watermark() sets the min in zone DMA32, where > > most of the memory is, to 512M. It fails even though there is over 500M of > > free memory. With boost_watermark() suppressed, the capture kernel can run > > successfully in 448M. > > > > This patch limits boost_watermark() to boosting a zone's min watermark only > > when there are enough pages that the boost will produce positive results. > > In this case that is estimated to be four times as many pages as > > pageblock_nr_pages. > > > > Let's Cc Mel. > Seems reasonable. Acked-by: Mel Gorman -- Mel Gorman SUSE Labs