From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB73C3A5A9 for ; Mon, 4 May 2020 10:26:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A1432054F for ; Mon, 4 May 2020 10:26:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A1432054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 884F68E0005; Mon, 4 May 2020 06:26:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80F038E0003; Mon, 4 May 2020 06:26:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FDE28E0005; Mon, 4 May 2020 06:26:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 545E08E0003 for ; Mon, 4 May 2020 06:26:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 17AA6EFE7 for ; Mon, 4 May 2020 10:26:35 +0000 (UTC) X-FDA: 76778657550.17.glass66_90c0c6b0e210b X-HE-Tag: glass66_90c0c6b0e210b X-Filterd-Recvd-Size: 2242 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 10:26:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 97482AB7D; Mon, 4 May 2020 10:26:34 +0000 (UTC) Date: Mon, 4 May 2020 12:26:31 +0200 From: Michal Hocko To: Sandipan Das Cc: akpm@linux-foundation.org, linux-mm@kvack.org, khlebnikov@yandex-team.ru, kirill@shutemov.name, aneesh.kumar@linux.ibm.com, srikar@linux.vnet.ibm.com Subject: Re: [PATCH] mm: vmstat: Use zeroed stats for unpopulated zones Message-ID: <20200504102441.GM22838@dhcp22.suse.cz> References: <20200504070304.127361-1-sandipan@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200504070304.127361-1-sandipan@linux.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 04-05-20 12:33:04, Sandipan Das wrote: > For unpopulated zones, the pagesets point to the common > boot_pageset which can have non-zero vm_numa_stat counts. > Because of this memory-less nodes end up having non-zero > NUMA statistics. This can be observed on any architecture > that supports memory-less NUMA nodes. > > E.g. > > $ numactl -H > available: 2 nodes (0-1) > node 0 cpus: 0 1 2 3 > node 0 size: 0 MB > node 0 free: 0 MB > node 1 cpus: 4 5 6 7 > node 1 size: 8131 MB > node 1 free: 6980 MB > node distances: > node 0 1 > 0: 10 40 > 1: 40 10 > > $ numastat > node0 node1 > numa_hit 108 56495 > numa_miss 0 0 > numa_foreign 0 0 > interleave_hit 0 4537 > local_node 108 31547 > other_node 0 24948 > > Hence, return zero explicitly for all the stats of an > unpopulated zone. I hope I am not just confused but I would expect that at least numa_foreign and other_node to be non zero. -- Michal Hocko SUSE Labs