From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E0FC47247 for ; Mon, 4 May 2020 00:41:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91EEC206F0 for ; Mon, 4 May 2020 00:41:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="eiIirED3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91EEC206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3AC468E0005; Sun, 3 May 2020 20:41:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 365B38E0001; Sun, 3 May 2020 20:41:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224408E0005; Sun, 3 May 2020 20:41:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 035F78E0001 for ; Sun, 3 May 2020 20:41:37 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BFF2710F6C for ; Mon, 4 May 2020 00:41:37 +0000 (UTC) X-FDA: 76777183434.16.verse63_8298915603551 X-HE-Tag: verse63_8298915603551 X-Filterd-Recvd-Size: 5280 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 May 2020 00:41:37 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id b1so12761695qtt.1 for ; Sun, 03 May 2020 17:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PhoRsdVUpxSefTN3nA18NxBE6Bc3GIrO3qESKoaBeLw=; b=eiIirED3qHhOWipGjeDdkfgS6x9vBM5QEEOf5fRffYbj9YWUhCyermSfNDb9pxgsaL RIsNfefUqTcEkuOc2GNAnhFoEyZOcoLG8zd6vtNEyf3FvwpXOyxGMNGw9P3XhM3utgRr nOGkEiElDA/CQ+ecaVClVdNWF9en8Q5WFMcZs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PhoRsdVUpxSefTN3nA18NxBE6Bc3GIrO3qESKoaBeLw=; b=kjtIX0SY5SO52jSwPuB/gx5t1f2nDrJf3eRZd3KWWS34t9FrhpPFkJ35cinYmCSfi4 1HyfmYJ+g1ISFGPJpAo4ORw8M9GBhBi98/eU1g0NDFIfOWC5XDC1DMSdIZFbnRWTD3iG OE3c+VDX7wCFN6hMWOQCMjZxHv+cPj61DGZnc17yhy0nTmTiG4gFdBHhzyFg4V65xI+V M0h3mznoh2Rgbo6qNB1yjCegUjThhQgCeM/AmhNAJ83me9zQ19I8UJvs29OGYZQqmdj6 cePbfJ4tdZWLF6y5f2Sq14lNmLcK5DJDNIE+URguqM4UQkpIKMXufWGGeVhycFn6nY3k FR0Q== X-Gm-Message-State: AGi0PuYF7gvYdmt+tWZSQERfcGf218ujJQTQZHovzMLDB5PjRnSynKtq CT/cUTxz+4rgBZBOsrnMyJYPfQ== X-Google-Smtp-Source: APiQypLm9DWQtztLxl8yVs7UxAPvJPkNvWCOEKzw7QaqkrVjpn0b8WccC6XYYNBsMVi9l03kwIDEVw== X-Received: by 2002:ac8:44aa:: with SMTP id a10mr15083681qto.230.1588552896694; Sun, 03 May 2020 17:41:36 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id t14sm9407295qtj.71.2020.05.03.17.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2020 17:41:36 -0700 (PDT) Date: Sun, 3 May 2020 20:41:35 -0400 From: Joel Fernandes To: "Paul E. McKenney" Cc: Joe Perches , "Uladzislau Rezki (Sony)" , LKML , linux-mm@kvack.org, Andrew Morton , "Theodore Y . Ts'o" , Matthew Wilcox , RCU , Oleksiy Avramchenko Subject: Re: [PATCH 03/24] rcu/tree: Use consistent style for comments Message-ID: <20200504004135.GF212435@google.com> References: <20200428205903.61704-1-urezki@gmail.com> <20200428205903.61704-4-urezki@gmail.com> <20200501190555.GB7560@paulmck-ThinkPad-P72> <93f764ad743082f2bbab4595eb892c2004e61b44.camel@perches.com> <20200503234400.GB197097@google.com> <20200504002309.GD2869@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200504002309.GD2869@paulmck-ThinkPad-P72> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 03, 2020 at 05:23:09PM -0700, Paul E. McKenney wrote: > On Sun, May 03, 2020 at 07:44:00PM -0400, Joel Fernandes wrote: > > On Fri, May 01, 2020 at 01:52:46PM -0700, Joe Perches wrote: > > > On Fri, 2020-05-01 at 12:05 -0700, Paul E. McKenney wrote: > > > > On Tue, Apr 28, 2020 at 10:58:42PM +0200, Uladzislau Rezki (Sony) wrote: > > > > > Simple clean up of comments in kfree_rcu() code to keep it consistent > > > > > with majority of commenting styles. > > > [] > > > > on /* */ style? > > > > > > > > I am (slowly) moving RCU to "//" for those reasons. ;-) > > > > > > I hope c99 comment styles are more commonly used soon too. > > > checkpatch doesn't care. > > > > > > Perhaps a change to coding-style.rst > > > --- > > > Documentation/process/coding-style.rst | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst > > > index acb2f1b..fee647 100644 > > > --- a/Documentation/process/coding-style.rst > > > +++ b/Documentation/process/coding-style.rst > > > @@ -565,6 +565,11 @@ comments is a little different. > > > * but there is no initial almost-blank line. > > > */ > > > > > > +.. code-block:: c > > > + > > > + // Single line and inline comments may also use the c99 // style > > > + // Block comments as well > > > + > > > It's also important to comment data, whether they are basic types or derived > > > types. To this end, use just one data declaration per line (no commas for > > > multiple data declarations). This leaves you room for a small comment on each > > > > Yeah that's fine with me. This patch just tries to keep it consistent. I am > > Ok with either style. > > My approach has been gradual change. Big-bang changes of this sort > cause quite a bit of trouble. So I use "//" in new code and (sometimes) > convert nearby ones when making a change. Ok thanks for the guidance on that, will follow similar conversion strategy as well. thanks, - Joel