From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 033A4C3A5A9 for ; Sat, 2 May 2020 15:23:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B494C216FD for ; Sat, 2 May 2020 15:23:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="Lar/yK+e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B494C216FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4A3378E0005; Sat, 2 May 2020 11:23:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42B828E0001; Sat, 2 May 2020 11:23:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F43E8E0005; Sat, 2 May 2020 11:23:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 128858E0001 for ; Sat, 2 May 2020 11:23:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C73433A87 for ; Sat, 2 May 2020 15:23:44 +0000 (UTC) X-FDA: 76772148768.15.trick54_39196a40892e X-HE-Tag: trick54_39196a40892e X-Filterd-Recvd-Size: 3424 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Sat, 2 May 2020 15:23:44 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id u127so3532282wmg.1 for ; Sat, 02 May 2020 08:23:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vRyV4YGAwNKdvCO2sao495a7IGDDJJ/M+QQHiEO1Olw=; b=Lar/yK+eE4s8kJKL2vpRnVfx6nBXfqjZENT1dfChydMqV6F5r1ydW0EuRrnP/2fLCk VKdNLzJkMf5UBJcKJLJUGtKBd0OvJU7Lh4NmyAkcIM5klQf7VgU/zove9IIN8GecBI48 IUoG6cjeVVFu2qDv5ktUkkhjV3/QKhy7XK3+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vRyV4YGAwNKdvCO2sao495a7IGDDJJ/M+QQHiEO1Olw=; b=ui6R0FUwgmYHUfHsqb0qDqWXzSdVp+RQuqiZCaencxO78kJAFx73VaE2r9PKLOiyfZ +5KUwZQruHmSzZAp7w4xhc4y4WlEFDffVYRSsxy8UcNVLYHOQSbbaP8icYkMWE/LiOP8 mF6qmzX9hwdJ2BQYYf7t6I8OOelcLXyFIGEndL7Oy9/sAbviX0rfVjlrJbKZTPTQ7YMl moPulu60rcePXbDTc9ZOnPe5XOmWxHCJ0UMTzA1RoUfFg8jd+LABAP5bAhi+XWRIfY/2 vlkMBw0XUKJwagYSbe1mGCmpVcFfnHOnnNQJ/hTNm1N43UvyUJHm5VRwdKmErWDkUn6o /gCw== X-Gm-Message-State: AGi0PuaOpuRlzEf37v63Rf74s83DvxF9E5RGohVKoUbtRI48475vTIsK SfvdaoHeE3psAOWdD4tNYMK9Fw== X-Google-Smtp-Source: APiQypJPoOo1mi4RQAZ4sDdT3EVq2o5szCbQxWxIoh+Lar7O14dy7IK8R+mg96EseQnpeVvw/MSQ9A== X-Received: by 2002:a1c:1d92:: with SMTP id d140mr4989716wmd.67.1588433022799; Sat, 02 May 2020 08:23:42 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:56e1:adff:fe3f:49ed]) by smtp.gmail.com with ESMTPSA id e13sm8172012wrw.88.2020.05.02.08.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 May 2020 08:23:42 -0700 (PDT) Date: Sat, 2 May 2020 16:23:42 +0100 From: Chris Down To: Yafang Shao Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Michal Hocko , Johannes Weiner Subject: Re: [PATCH resend] mm, memcg: fix inconsistent oom event behavior Message-ID: <20200502152342.GB1973@chrisdown.name> References: <20200502141055.7378-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200502141055.7378-1-laoar.shao@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yafang Shao writes: >A recent commit 9852ae3fe529 ("mm, memcg: consider subtrees in >memory.events") changes the behavior of memcg events, which will >consider subtrees in memory.events. But oom_kill event is a special one >as it is used in both cgroup1 and cgroup2. In cgroup1, it is displayed >in memory.oom_control. The file memory.oom_control is in both root memcg >and non root memcg, that is different with memory.event as it only in >non-root memcg. That commit is okay for cgroup2, but it is not okay for >cgroup1 as it will cause inconsistent behavior between root memcg and >non-root memcg. Thanks! Acked-by: Chris Down