From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D16C3A5A9 for ; Sat, 2 May 2020 13:41:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E332921835 for ; Sat, 2 May 2020 13:41:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iVv54Rhs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E332921835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 676FF8E0005; Sat, 2 May 2020 09:41:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6272D8E0001; Sat, 2 May 2020 09:41:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EDA18E0005; Sat, 2 May 2020 09:41:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 34A1D8E0001 for ; Sat, 2 May 2020 09:41:41 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E9A695847 for ; Sat, 2 May 2020 13:41:40 +0000 (UTC) X-FDA: 76771891560.16.knife18_83100a4f7655a X-HE-Tag: knife18_83100a4f7655a X-Filterd-Recvd-Size: 4719 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Sat, 2 May 2020 13:41:40 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id l18so4475511wrn.6 for ; Sat, 02 May 2020 06:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sF7Mbr7u0j8a1zCroJsnWHqSQU0Nk3Dl8GARa1TmLgU=; b=iVv54RhsTAX8YW8uEm7HffxQIFP8R6uKH+WiakJjPVmvh3Ok+LvRMWsLCpS41MagNA O2j/b1oDTRG1GTPqWbec5MvgYkUf1kSQK1Rl/fqRndj7GUrbcfXsj4Vui3SxdeaOPomi IBFuIxMmdOBl6zQLwRtG9VZZK4tYrA3VxiviEFrveqGARfpcbrjq440Yw0D/PSJkJm1X a2l1pyAVxPg8DBNEWq0leBhLg5KncJMKnnvidn07SJMMWDnpWiCgPkMlNFfNlUGmnCxJ bahtESTyTnXH6fP3VSCE2mscrp0mJmiBHgtXjYOg5Xb9G31YfcEOSjFYZSMESMT3bfK2 D6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=sF7Mbr7u0j8a1zCroJsnWHqSQU0Nk3Dl8GARa1TmLgU=; b=TmZR7yraQqgoOK85pb9ZOkV3hfcpCMGD7Icg81PuT/dzlCugy1jBRyRwQM2nG+zdi+ 8bC3BiMK2mtccTzoR3BsvkJ4Lx52mtJ1PqQy895XxGPCuiL/hyK2jIkv/Nd2eg0/IYqE Q02s57ICkeis5OowDRlozcAwmlKk9d/HWsI4rHYSXv6efbJOtwnBaxXJVd0LYr+tP7Vu deXpEtEJmW3IF16Xbt/Sz/ib0/RgmrBuUoU0TrhxAi741xMQx2WBOvNDC1fNIEnJHm0t oJgcgzznTm3hI7wRAPxXdLWhAcjqlGFALxP4FpWl+2XYFzuDMn9Yzn7cSPxDyKME/s/h H/fQ== X-Gm-Message-State: AGi0Pua+VIibnP23st05TZCdoAQuE3JzxxeZZ7Xabw0hl+xGKbEdlQEY 2xvZBH/XPWrh6GwdNnfSPAQ= X-Google-Smtp-Source: APiQypIjbZjGH51Gca7iovZ7Scb7BUaWy4caXx9f7B0nZ38xqnChWouJpslsRZxDJjyzHoqfcvEqEQ== X-Received: by 2002:adf:b344:: with SMTP id k4mr9039440wrd.76.1588426899434; Sat, 02 May 2020 06:41:39 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id v16sm4315372wml.30.2020.05.02.06.41.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 May 2020 06:41:38 -0700 (PDT) Date: Sat, 2 May 2020 13:41:38 +0000 From: Wei Yang To: Wei Yang Cc: Andrew Morton , ying.huang@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] mm/swapfile.c: count won't be bigger than SWAP_MAP_MAX Message-ID: <20200502134138.ycm26jnxc55rimgj@master> Reply-To: Wei Yang References: <20200501015259.32237-1-richard.weiyang@gmail.com> <20200501015259.32237-3-richard.weiyang@gmail.com> <20200501154853.bca4cfb7b2558bd43a4942f3@linux-foundation.org> <20200502132911.u6y6hkh56ik4ojne@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200502132911.u6y6hkh56ik4ojne@master> User-Agent: NeoMutt/20170113 (1.7.2) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000408, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 02, 2020 at 01:29:11PM +0000, Wei Yang wrote: >On Fri, May 01, 2020 at 03:48:53PM -0700, Andrew Morton wrote: >>On Fri, 1 May 2020 01:52:59 +0000 Wei Yang wrote: >> >>> When the condition is true, there are two possibilities: >> >>I'm struggling with this one. >> >>> 1. count == SWAP_MAP_BAD >>> 2. count == (SWAP_MAP_MAX & COUNT_CONTINUED) == SWAP_MAP_SHMEM >> >>I'm not sure what 2. is trying to say. For a start, (SWAP_MAP_MAX & >>COUNT_CONTINUED) is zero. I guess it meant "|"? > >Oops, you are right. It should be (SWAP_MAP_MAX | COUNT_CONTINUED). > >Sorry for the confusion. > Hmm... I made a mistake again, the two cases should be * SWAP_MAP_BAD * (SWAP_MAP_BAD | COUNT_CONTINUED) == SWAP_MAP_SHMEM What a shame. >> >>Also, the return value documentation says we return EINVAL for migration >>entries. Where's that happening, or is the comment out of date? >> > >Not paid attention to this. > >Take look into the code, I don't find a relationship between the swap count >and migration. Seems we just make a migration entry but not duplicate it. >If my understanding is correct. > >>> The first case would be filtered by the first if in __swap_duplicate(). >>> >>> And the second case means this swap entry is for shmem. Since we never >>> do another duplication for shmem swap entry. This won't happen neither. >> > >-- >Wei Yang >Help you, Help me -- Wei Yang Help you, Help me