From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23868C47257 for ; Fri, 1 May 2020 15:40:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5D0E20731 for ; Fri, 1 May 2020 15:40:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5D0E20731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 809178E0006; Fri, 1 May 2020 11:40:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 793BC8E0001; Fri, 1 May 2020 11:40:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6331E8E0006; Fri, 1 May 2020 11:40:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 4A7828E0001 for ; Fri, 1 May 2020 11:40:54 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 05062485F for ; Fri, 1 May 2020 15:40:54 +0000 (UTC) X-FDA: 76768563228.28.drink76_5f21a46250951 X-HE-Tag: drink76_5f21a46250951 X-Filterd-Recvd-Size: 3682 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 15:40:53 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id q124so4693450pgq.13 for ; Fri, 01 May 2020 08:40:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EZb14EGk3wI78w7Kr9UulRwJ6g15wvU8vvLNiIxNBjg=; b=aFE6LKSggNVxNvyK7I4SKBpB7jyaDlqmgIXf66r3TT6c9ao0FnoC0X3HemK10qZILQ C4ckxZV347cwypU5jBzB4ejOfi9GenCLsPvaC+JeygtM+F1mgYM56J7KhioMK2vOZX+5 DNUGKArh67vCK0JxibDHPSz2UR/mWcaIQLWRzRT4pgoDwY2FgwHg/GNSdBXlkgkucsc4 1+jqKXlEU4PGsCGerwTJrBv98wWEqIt3IhDGWauF0WIS+RTE1b4CP503n2TQP9FrfFKh fqOB+BDhD8G+xvsatdI9M713V+fviYFBt4Br/07hcyVrfdk5oe/n8UKTQDfUQZYkKJW2 8v8w== X-Gm-Message-State: AGi0PubxnXD0C2OkjHimx8pjvpjL/YvQc4q7Ut1i720ZNCd/siW5nkrD nazAmYsJUH42KhF9iSo1qIM= X-Google-Smtp-Source: APiQypIKENGcjQ8wEJnG/jVN4jklP+/LYCHW7WJrZ1nUigoylvteSvXK0XEmW6rptAeYZk2lCgDJWg== X-Received: by 2002:a63:3d05:: with SMTP id k5mr4023956pga.302.1588347652702; Fri, 01 May 2020 08:40:52 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id p65sm2305859pgp.51.2020.05.01.08.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2020 08:40:51 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id D6D414046C; Fri, 1 May 2020 15:40:50 +0000 (UTC) Date: Fri, 1 May 2020 15:40:50 +0000 From: Luis Chamberlain To: Christoph Hellwig Cc: Greg KH , axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/6] blktrace: break out of blktrace setup on concurrent calls Message-ID: <20200501154050.GO11244@42.do-not-panic.com> References: <20200429074627.5955-1-mcgrof@kernel.org> <20200429074627.5955-6-mcgrof@kernel.org> <20200429094937.GB2081185@kroah.com> <20200501150626.GM11244@42.do-not-panic.com> <20200501153423.GA12469@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200501153423.GA12469@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000099, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 01, 2020 at 08:34:23AM -0700, Christoph Hellwig wrote: > On Fri, May 01, 2020 at 03:06:26PM +0000, Luis Chamberlain wrote: > > > You have access to a block device here, please use dev_warn() instead > > > here for that, that makes it obvious as to what device a "concurrent > > > blktrace" was attempted for. > > > > The block device may be empty, one example is for scsi-generic, but I'll > > use buts->name. > > Is blktrace on /dev/sg something we intentionally support, or just by > some accident of history? Given all the pains it causes I'd be tempted > to just remove the support and see if anyone screams. >From what I can tell I think it was a historic and brutal mistake. I am more than happy to remove it. Re-adding support would just be a symlink. Luis