From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BD5C4724C for ; Fri, 1 May 2020 12:34:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1542520708 for ; Fri, 1 May 2020 12:34:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TZFNVyLm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1542520708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BDC78E0005; Fri, 1 May 2020 08:34:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86E158E0001; Fri, 1 May 2020 08:34:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75C9B8E0005; Fri, 1 May 2020 08:34:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 5CCD78E0001 for ; Fri, 1 May 2020 08:34:32 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 132048249980 for ; Fri, 1 May 2020 12:34:32 +0000 (UTC) X-FDA: 76768093584.04.event32_44a5d5b12265a X-HE-Tag: event32_44a5d5b12265a X-Filterd-Recvd-Size: 3371 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 12:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OFdEjkK9jwgd0OlQdpKQakLpH/7u8tRK6UnJTEvP0yE=; b=TZFNVyLmvaFYCPmOoBQtCT8LbO KtKzjwYT3U74sRbqJs/Z1oBAzhMS/kd6rAH3tl7VxdFTJeIMAur6Yj+mZ85A4krspgMQy3rWsH6qo HusitmEyOqEqd0kgFe6dLVdM7TMD+lRvDuN+OUsa6o+/JR+C0yK6xftYg6vh89a3f6nTKJwEmKwca 78UrEHxNth3LG15agZHExbxpowRrDLJzWTduaQ3YDfej9H7lIPyOU2RBVPE1ugVKsSVkX59dkby4B +mKvFK1Bla71Q/8523zGvGK9xtYDeEix7V0D2qeZDEItMJxtYiSp25ByXhADkdTVm2P1CGGeY3+Hm /pCJqLew==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUUs9-0007mt-MI; Fri, 01 May 2020 12:34:29 +0000 Date: Fri, 1 May 2020 05:34:29 -0700 From: Christoph Hellwig To: Joonsoo Kim Cc: Christoph Hellwig , Andrew Morton , Linux Memory Management List , LKML , Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , kernel-team@lge.com, Joonsoo Kim Subject: Re: [PATCH v2 00/10] change the implementation of the PageHighMem() Message-ID: <20200501123429.GA26861@infradead.org> References: <1588130803-20527-1-git-send-email-iamjoonsoo.kim@lge.com> <20200429184711.9d603da097fdea80f574f1f1@linux-foundation.org> <20200501105545.GA29460@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 01, 2020 at 09:15:30PM +0900, Joonsoo Kim wrote: > I think that PageHighMemZone() is long and complicated enough to have > a macro. It is. But then again it also shouldn't really be used by anything but MM internals. > > PageHighMemZone(page) = is_highmem_idx(zone_idx(page_zone(page)) > > Instead of open-code, how about changing the style of macro like as > page_from_highmem()? What PageHighMemZone() represent is derivated > attribute from the page so PageXXX() style may not be appropriate. Maybe page_is_highmem_zone() with a big kerneldoc comment explaining the use case? Bonus points of killing enough users that it can be in mm/internal.h.