From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41933C47253 for ; Fri, 1 May 2020 12:22:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CADE82051A for ; Fri, 1 May 2020 12:22:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iP7OpWY8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CADE82051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 607C38E0005; Fri, 1 May 2020 08:22:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B8688E0001; Fri, 1 May 2020 08:22:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4803F8E0005; Fri, 1 May 2020 08:22:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 315968E0001 for ; Fri, 1 May 2020 08:22:50 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D9246181AC9CB for ; Fri, 1 May 2020 12:22:49 +0000 (UTC) X-FDA: 76768064058.14.corn66_6ff8704660419 X-HE-Tag: corn66_6ff8704660419 X-Filterd-Recvd-Size: 3586 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 12:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=MhFhYw6pM9dJG//E1anenCrCOzgRlPNRTV2E13gtbCM=; b=iP7OpWY8G0QNFycCHZo3TxaaL5 W3pZ0Z3wnygKzNhIOsXaDmaOcEIBCyB2ZgunksUXJoz6dpqEoMCgUfEHaYhv5vqbfQGObs1B5gvLI uY7E69BdlvSB582PmRj5pZevMxkOfcQ6jZhxSBnP0S0QnDAJPP0IAuYsN/ROB9j3Y7CQ4aCnfheYq 7MmE584/Xyb3z6W8vwlmYmgTbSFcqg6X5HwDaWZ0qES+VUQ6YxkLfvu5mDMuB7ON3kCDSv2G5YFFG DyzWDVaezMecPmGKuJbnq/uNn6AoaTb0wI6cM6LcuGds9oqsBFnBBTzll/pHuHX87tJZJshAwuHbW 7UAAt+8w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUUgn-0000q8-S9; Fri, 01 May 2020 12:22:45 +0000 Date: Fri, 1 May 2020 05:22:45 -0700 From: Christoph Hellwig To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , kernel-team@lge.com, Christoph Hellwig , Joonsoo Kim Subject: Re: [PATCH v2 04/10] power: separate PageHighMem() and PageHighMemZone() use case Message-ID: <20200501122245.GA21897@infradead.org> References: <1588130803-20527-1-git-send-email-iamjoonsoo.kim@lge.com> <1588130803-20527-5-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1588130803-20527-5-git-send-email-iamjoonsoo.kim@lge.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 29, 2020 at 12:26:37PM +0900, js1304@gmail.com wrote: > index 6598001..be759a6 100644 > --- a/kernel/power/snapshot.c > +++ b/kernel/power/snapshot.c > @@ -1227,7 +1227,7 @@ static struct page *saveable_highmem_page(struct = zone *zone, unsigned long pfn) > if (!page || page_zone(page) !=3D zone) > return NULL; > =20 > - BUG_ON(!PageHighMem(page)); > + BUG_ON(!PageHighMemZone(page)); The above check already checks for the highmem zone. So if we want to keep the BUG_ON it needs stay PageHighMem to make sense. That being said I'd rather remove it entirel=E1=BA=8F. > - BUG_ON(PageHighMem(page)); > + BUG_ON(PageHighMemZone(page)); Same here. > @@ -1529,7 +1529,7 @@ static unsigned long preallocate_image_pages(unsi= gned long nr_pages, gfp_t mask) > if (!page) > break; > memory_bm_set_bit(©_bm, page_to_pfn(page)); > - if (PageHighMem(page)) > + if (PageHighMemZone(page)) > alloc_highmem++; > else > alloc_normal++; I don't fully understand the log here. Can Pavel or Rafael clarify why swsupst would care about the exact zone?