From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CFE4C4724C for ; Thu, 30 Apr 2020 21:59:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 13BA2206F0 for ; Thu, 30 Apr 2020 21:59:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="fc/Q95Yr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13BA2206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8A738E0005; Thu, 30 Apr 2020 17:59:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3A908E0001; Thu, 30 Apr 2020 17:59:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 929A88E0005; Thu, 30 Apr 2020 17:59:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 77C868E0001 for ; Thu, 30 Apr 2020 17:59:23 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4281A180AD811 for ; Thu, 30 Apr 2020 21:59:23 +0000 (UTC) X-FDA: 76765888206.30.wrist11_8c22a83d1fe1e X-HE-Tag: wrist11_8c22a83d1fe1e X-Filterd-Recvd-Size: 4558 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Apr 2020 21:59:22 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id b20so2262800lff.2 for ; Thu, 30 Apr 2020 14:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/pudPj9Z3XDin0S0F3QD/0p7qf5audyl1OfeTF2rX2k=; b=fc/Q95YrYrYUFOA9a9LZRPKWlYtrdG/4WUSQYHdvOUGlmrgqhbNEi9tbXm1L/69Cr+ 434cWf0TQ2YAaczpTW6CnEE5si+Wl8AZVpne/5WLW8MqGfI8YHPyP40WUVjOQWGKd7dW qjqOB/cFIpBrahYQFHsrBgxnvEaxcIiqt5m3D9B3bSjtanhJ14qG7siZyVf1dxhYldq8 SuLH3j0PaqLE8RUUqy9DEGxoK5Mi2ozcYBXM9aAM8eEO8DICHX2NGjWspp7rCXc9atAp UKIECgFctXH/W7giyd9AI6PJNmIAfuyonJ6TFwCM8u3Ec2MT6U/IXtv8Ihmj3fTngGJH M0xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/pudPj9Z3XDin0S0F3QD/0p7qf5audyl1OfeTF2rX2k=; b=CIJP/vCcZftKxVp/o6oe0+vjol9gIAWGPELUPXYC89tNf2LjC46rHLCCrVTLsZSIrj YEPQ3scTo04h9de63s0m0Ox94Z5MT6H6+TzRx8z7sz3RTasU1EKwI4UTh/QCI2h0078x /za37sdOAmRyDezWn1tVxdm5Kl29XQX1Iqlr5QVfN91QOL98Li/Nv5LBx8Wxc+MwU1tk DV6rwHtxLpdGZG/mgBwm8t83muSbUzpTatEbavPbF2dvHncv4CvWhq2r9193WXNknBts ClIfUWly+rov97OexppTOGPciXO0dbnhIK9ZHcgQoXv7DnvCqDYAK5DaFTKrV8YXWyuD /BcQ== X-Gm-Message-State: AGi0PuakjGxk5X56tPyPaoO+2dOblHGdzdDzlocwycWdAjixcgrNpXQd OjtKlHiSAvz08jrFMkzjXyEZ+g== X-Google-Smtp-Source: APiQypJcF2oB/bxZG/9cCepQYZUv7yHEvh5RW/0cskhQgJ0uGU/iHFvu++BRFRg5m4DlrDDJLICyeg== X-Received: by 2002:ac2:4257:: with SMTP id m23mr448779lfl.141.1588283961342; Thu, 30 Apr 2020 14:59:21 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id c2sm706801ljk.97.2020.04.30.14.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 14:59:20 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 84161102776; Fri, 1 May 2020 00:59:32 +0300 (+03) Date: Fri, 1 May 2020 00:59:32 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: kirill.shutemov@linux.intel.com, hughd@google.com, aarcange@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [linux-next PATCH 1/2] mm: khugepaged: add exceed_max_ptes_* helpers Message-ID: <20200430215932.5w5dck3rnieppzqa@box> References: <1588200982-69492-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588200982-69492-1-git-send-email-yang.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 30, 2020 at 06:56:21AM +0800, Yang Shi wrote: > The max_ptes_{swap|none|shared} are defined to tune the behavior of > khugepaged. The are checked at a couple of places with open coding. > Replace the opencoding to exceed_pax_ptes_{swap|none_shared} helpers to > improve the readability. > > Cc: Kirill A. Shutemov > Cc: Hugh Dickins > Cc: Andrea Arcangeli > Signed-off-by: Yang Shi > --- > mm/khugepaged.c | 27 +++++++++++++++++++++------ > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index a02a4c5..0c8d30b 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -339,6 +339,21 @@ struct attribute_group khugepaged_attr_group = { > }; > #endif /* CONFIG_SYSFS */ > > +static inline bool exceed_max_ptes_none(unsigned int *nr_ptes) > +{ > + return (++(*nr_ptes) > khugepaged_max_ptes_none); > +} > + > +static inline bool exceed_max_ptes_swap(unsigned int *nr_ptes) > +{ > + return (++(*nr_ptes) > khugepaged_max_ptes_swap); > +} > + > +static inline bool exceed_max_ptes_shared(unsigned int *nr_ptes) > +{ > + return (++(*nr_ptes) > khugepaged_max_ptes_shared); > +} > + Frankly, I find this ugly and confusing. Open-coded version is more readable to me. -- Kirill A. Shutemov