From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E13F0C83003 for ; Wed, 29 Apr 2020 13:09:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB7192074A for ; Wed, 29 Apr 2020 13:09:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB7192074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35A508E0005; Wed, 29 Apr 2020 09:09:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30A5C8E0001; Wed, 29 Apr 2020 09:09:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2278C8E0005; Wed, 29 Apr 2020 09:09:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id 06BD68E0001 for ; Wed, 29 Apr 2020 09:09:17 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B4CE1180AD807 for ; Wed, 29 Apr 2020 13:09:16 +0000 (UTC) X-FDA: 76760923512.05.door17_6e12eee555535 X-HE-Tag: door17_6e12eee555535 X-Filterd-Recvd-Size: 3033 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 13:09:16 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id b11so2446683wrs.6 for ; Wed, 29 Apr 2020 06:09:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bH0bbqVQbeUY5It5xqT1zYzIFKuvRYaWvNIr4hXMeAE=; b=J9s2mQKXZf438fB1PVJz1/DC4MU9zLQ2z+v2ULRhFwdF0nzE468jT9MYP1VN7mIAmH kqmZ61QpikJOvYhqLLzoEPa6erb/pVNjgIUKXoDV1EFKhLsoENU3be4oWIbl6RcvFFxJ z+jjhh+bzVJVH3+nYj9pk6eh8n77wF16t1dJVvxhM+Uxatp4W7n3MfttFO4YI7EpBUm2 vlTQpzC4t+3jeWFdYlcAIP9SEcwyQLZ5cXhrFECHj4UAWtMXvYSZeJOOICTMxCN5EIrK puA7Z8GeXNRq0K9PX53DV7X8IZtf1nOiBDQh0GAwlH8zC0TadRKc9rg3H9XohXwXcg9z 2FmQ== X-Gm-Message-State: AGi0PuY74MDTeHCR9Sb3xjLgx+wG0Pla02EyF0Q7YOBnZKqo8E7Se8uf DVb4iJZXgyT/n4xVGohjWmA= X-Google-Smtp-Source: APiQypJkDxrRS6EsgUtBFz8WMEi0Jgs+THobIMxefSCsUFprNNyWNSEjL+uraVhlwtSj/oRYvvDRIQ== X-Received: by 2002:a5d:42cf:: with SMTP id t15mr38561028wrr.354.1588165755294; Wed, 29 Apr 2020 06:09:15 -0700 (PDT) Received: from localhost (ip-37-188-130-62.eurotel.cz. [37.188.130.62]) by smtp.gmail.com with ESMTPSA id n2sm30894945wrq.74.2020.04.29.06.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 06:09:14 -0700 (PDT) Date: Wed, 29 Apr 2020 15:09:12 +0200 From: Michal Hocko To: Maninder Singh Cc: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , AMIT SAHRAWAT , Vaneet Narang Subject: Re: [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list Message-ID: <20200429130912.GE28637@dhcp22.suse.cz> References: <20200429120951.GC28637@dhcp22.suse.cz> <1588139967-19012-1-git-send-email-maninder1.s@samsung.com> <20200429125323epcms5p67a539511c573cd598d78b726503e3204@epcms5p6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429125323epcms5p67a539511c573cd598d78b726503e3204@epcms5p6> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 29-04-20 18:23:23, Maninder Singh wrote: > > Hi, > > > > >Acked-by: Michal Hocko > > > >Is there any reason to move declarations here? > > > > "unsigned int ret" was changed mistakenely, sending V2. > and "unsigned int nr_reclaimed" is changed to remove hole. Could you be more specific? Have you seen a better stack allocation footprint? -- Michal Hocko SUSE Labs