From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 806BBC83003 for ; Wed, 29 Apr 2020 12:09:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B6D02087E for ; Wed, 29 Apr 2020 12:09:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B6D02087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9A0988E0007; Wed, 29 Apr 2020 08:09:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 951318E0001; Wed, 29 Apr 2020 08:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8667E8E0007; Wed, 29 Apr 2020 08:09:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 6BC998E0001 for ; Wed, 29 Apr 2020 08:09:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 29D8E3D13 for ; Wed, 29 Apr 2020 12:09:55 +0000 (UTC) X-FDA: 76760773950.23.light82_1c5b998e53026 X-HE-Tag: light82_1c5b998e53026 X-Filterd-Recvd-Size: 4244 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 12:09:54 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id x25so1764302wmc.0 for ; Wed, 29 Apr 2020 05:09:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0KFJsuweAsy2po8J04xM3JEaLOIdNb8hu1GHvhSVb/U=; b=az0e9ey5Cr3HzlseTJZBbN7L/v/S687BOZkSSQMovgMJu4/MFV9cEm22v/PlsR0w9M +PfmGAB/UzrSMwYxe2bcMi7Z8ta23mWn1dHUr+jjTbPUUyyl5P0nXrcbizuvAFy6NDW+ otQLCvpoL0MZ7A8t2QYj7U+OBH4xJb3MgEp4mZ2p0joPddgPI+7vXkGtbs0kg1xS+lOB Bh+HlJ01gn5kj9fejeBkk1C8yY+T4DttjU4Y7KwDVuFrLe7YOe8wOh4OpgaInM2Te8UW DyMe0XY1kLtZju4HFrzjrQhAL5yTRkPfk47P2Ld9ANqedFcw3iaCFNnEA162hTVZcm2N 0g+Q== X-Gm-Message-State: AGi0PubxSQ0kh//MXKmdt1vAtXHos8NSb7U3hAy+/+Z9esbCijlUgRcR rHHCMm1M7AlXGVkJ5H9pUz/TIFmt X-Google-Smtp-Source: APiQypKmAnDJcnzt1C2af24ekvd9u/E7junmh2qliw3xx+9V/UpmGC9xbL7/FuC1yhAiswiD7ohNQQ== X-Received: by 2002:a7b:c4d1:: with SMTP id g17mr2920096wmk.158.1588162193667; Wed, 29 Apr 2020 05:09:53 -0700 (PDT) Received: from localhost (ip-37-188-130-62.eurotel.cz. [37.188.130.62]) by smtp.gmail.com with ESMTPSA id h6sm7373995wmf.31.2020.04.29.05.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 05:09:52 -0700 (PDT) Date: Wed, 29 Apr 2020 14:09:51 +0200 From: Michal Hocko To: Maninder Singh Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, a.sahrawat@samsung.com, v.narang@samsung.com Subject: Re: [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list Message-ID: <20200429120951.GC28637@dhcp22.suse.cz> References: <1588139967-19012-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588139967-19012-1-git-send-email-maninder1.s@samsung.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 29-04-20 11:29:27, Maninder Singh wrote: > 'commit 3c710c1ad11b ("mm, vmscan: > extract shrink_page_list reclaim counters into a struct")' > > changed data type for the function, > so changing return type for funciton and its caller. > > Signed-off-by: Vaneet Narang > Signed-off-by: Maninder Singh Acked-by: Michal Hocko Is there any reason to move declarations here? > -unsigned long reclaim_clean_pages_from_list(struct zone *zone, > +unsigned int reclaim_clean_pages_from_list(struct zone *zone, > struct list_head *page_list) > { > + unsigned int ret; > struct scan_control sc = { > .gfp_mask = GFP_KERNEL, > .priority = DEF_PRIORITY, > .may_unmap = 1, > }; > struct reclaim_stat dummy_stat; > - unsigned long ret; > struct page *page, *next; > LIST_HEAD(clean_pages); > > @@ -1900,13 +1900,13 @@ static int current_may_throttle(void) > { > LIST_HEAD(page_list); > unsigned long nr_scanned; > - unsigned long nr_reclaimed = 0; > unsigned long nr_taken; > struct reclaim_stat stat; > int file = is_file_lru(lru); > enum vm_event_item item; > struct pglist_data *pgdat = lruvec_pgdat(lruvec); > struct zone_reclaim_stat *reclaim_stat = &lruvec->reclaim_stat; > + unsigned int nr_reclaimed = 0; > bool stalled = false; > > while (unlikely(too_many_isolated(pgdat, file, sc))) { > @@ -2096,7 +2096,7 @@ static void shrink_active_list(unsigned long nr_to_scan, > unsigned long reclaim_pages(struct list_head *page_list) > { > int nid = NUMA_NO_NODE; > - unsigned long nr_reclaimed = 0; > + unsigned int nr_reclaimed = 0; > LIST_HEAD(node_page_list); > struct reclaim_stat dummy_stat; > struct page *page; > -- > 1.9.1 -- Michal Hocko SUSE Labs