From: Chris Down <chris@chrisdown.name>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@lists.01.org, Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
kbuild test robot <lkp@intel.com>
Subject: Re: [hnaz-linux-mm:master 80/408] include/linux/memcontrol.h:863:9: warning: 'return' with a value, in function returning void
Date: Wed, 29 Apr 2020 10:37:31 +0100 [thread overview]
Message-ID: <20200429093731.GA2386944@chrisdown.name> (raw)
In-Reply-To: <202004291630.FQPgxZlG%lkp@intel.com>
Huh, somehow the !CONFIG_MEMCG case got mangled in the final version sent
upstream...
Andrew, can you please apply this fixup to
mm-memcg-decouple-elowmin-state-mutations-from-protection-checks.patch? Thank
you! :-)
diff --git include/linux/memcontrol.h include/linux/memcontrol.h
index 200693484afe..277c8a6a1c38 100644
--- include/linux/memcontrol.h
+++ include/linux/memcontrol.h
@@ -847,18 +847,13 @@ static inline void memcg_memory_event_mm(struct mm_struct *mm,
{
}
-static inline unsigned long mem_cgroup_protection(struct mem_cgroup *memcg,
- bool in_low_reclaim)
-{
-
-
static inline void mem_cgroup_calculate_protection(struct mem_cgroup *root,
- struct mem_cgroup *memcg);
+ struct mem_cgroup *memcg)
{
}
-static inline void mem_cgroup_protection(struct mem_cgroup *memcg,
- bool in_low_reclaim)
+static inline unsigned long mem_cgroup_protection(struct mem_cgroup *memcg,
+ bool in_low_reclaim)
{
return 0;
}
prev parent reply other threads:[~2020-04-29 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 8:32 kbuild test robot
2020-04-29 9:37 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429093731.GA2386944@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox