From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9DB1C83000 for ; Wed, 29 Apr 2020 00:52:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75921206F0 for ; Wed, 29 Apr 2020 00:52:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="2PRDAe4j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75921206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF9E48E0005; Tue, 28 Apr 2020 20:52:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E82B58E0001; Tue, 28 Apr 2020 20:52:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D491E8E0005; Tue, 28 Apr 2020 20:52:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id B917F8E0001 for ; Tue, 28 Apr 2020 20:52:13 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 806665836 for ; Wed, 29 Apr 2020 00:52:13 +0000 (UTC) X-FDA: 76759066146.15.grade42_4d97b6d14f61b X-HE-Tag: grade42_4d97b6d14f61b X-Filterd-Recvd-Size: 4049 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 00:52:13 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id t11so222305lfe.4 for ; Tue, 28 Apr 2020 17:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YuT/xOY+th6eK/rHxIuv+OueW2AvaS5G3o5QXDKsWZk=; b=2PRDAe4jqELbkHosMLEoi906nCbFHQSecbav0lfwR6eYYgY372mGh4nRfMuvEOOvED +qC50YnVtwF2whxzMWxyiLVqPdHwVXn31hDhFL87VDzoFhZ/nvkx4/SqLEKvoZMUFN5K HhJjhBfKPgi3E/6odf0mDQKF4mfgdtELBlpF756FPWVu45nwdkJX2u3wqne0avMiiLtw Dd1h5P0BM1Jtm3jCVDvTZoOE9a7x5oCOB7dyl2GuZ0RhnVSDro6aJnu42uwtQat9E7rN OQsXlPpjUuZJCCGhxW0ayBVzlPBMlcvRaboDp8fJfxr4FG8JmzD7ZkfSiYObk8qvfwFG 1rmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YuT/xOY+th6eK/rHxIuv+OueW2AvaS5G3o5QXDKsWZk=; b=ZRQhXe41RjYuDk8FxLf1/rfzlRDMhVlftH6z3KWHMgXqViXqnPCezLoLM+z6e9MF07 5rqDFm3ONkTywISHw8k2mmAyQb53TCJReFvfiyfNjPSrG3qoxld7Mh+pX016trHVHhum P8h205FbC3HYt4ZK/AIA3BA0q6HoTyxGNBFFSJX54Cm7ClqXBARe4Gan4+wc8k6eT7aH HvwbIzr5Q/PkiirBw/d4ieu1dbN/BXsaqklGNajk6jTMT70BkEbdAHd4g//P5buaP5x6 bbqWQMxxXlR+6Efce8uXm5yyprng3hX7aG3QXiUuashkXpCykl0EZUEIBnSFLzXYSlBL wu/g== X-Gm-Message-State: AGi0Puak1Nq9H5kKJkzHEoc68kA7HpQ1ccCK0rVwGADfbHQMfhangqIK RDzEd6rXJQLLXO7UfajFCuLhVg== X-Google-Smtp-Source: APiQypJR3g8SZEsvHcVIdxhOYxzG8T71U5sfYmc5ejCyTx1rQPoRNFqAuJxd38JO5R75Jsx+a0tnlA== X-Received: by 2002:ac2:5611:: with SMTP id v17mr20733406lfd.137.1588121531721; Tue, 28 Apr 2020 17:52:11 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id j15sm803395lji.18.2020.04.28.17.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 17:52:11 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 20CC910235A; Wed, 29 Apr 2020 03:52:22 +0300 (+03) Date: Wed, 29 Apr 2020 03:52:22 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Catalin Marinas , Russell King , Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org Subject: Re: [PATCH 7/7] mm: Set pt_mm in PMD constructor Message-ID: <20200429005222.3hwe73qsp7l4rxah@box> References: <20200428194449.22615-1-willy@infradead.org> <20200428194449.22615-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428194449.22615-8-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 28, 2020 at 12:44:49PM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > By setting pt_mm for pages in use as page tables, we can help with > debugging and lay the foundation for handling hardware errors in page > tables more gracefully. It also opens up the possibility for adding > more sanity checks in the future. > > Also set and clear the PageTable bit so that we know these are page tables. As far as I can see you don't yet introduce any checks. It makes patchset somewhat pointless. I'm not entirely sure how such checks would look like. The single page table tree would have at least two pt_mm: the owner and init_mm. Hugetlb shared page tables would make a mess here. Hm? -- Kirill A. Shutemov