From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11833C83000 for ; Wed, 29 Apr 2020 00:38:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C64DC20731 for ; Wed, 29 Apr 2020 00:38:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="MsvnquY+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C64DC20731 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5DB508E0005; Tue, 28 Apr 2020 20:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58B948E0001; Tue, 28 Apr 2020 20:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47AF88E0005; Tue, 28 Apr 2020 20:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 2D23C8E0001 for ; Tue, 28 Apr 2020 20:38:36 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id ED13752DD for ; Wed, 29 Apr 2020 00:38:35 +0000 (UTC) X-FDA: 76759031790.05.chair58_68259075de64a X-HE-Tag: chair58_68259075de64a X-Filterd-Recvd-Size: 5027 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 00:38:35 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id m2so196244lfo.6 for ; Tue, 28 Apr 2020 17:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=I/x8An6SXti07R7+/Bt1kXKVbp/TozSLPGc5SfRA9G4=; b=MsvnquY+sc2qn97UftFa4ZLSl1tmvl2rSpnwcYZimqt1fJ9ljPT1NLQSHBpVdqUg+k dFnavPNnuy5FQ2TRPGYQUCWQ2UF9qTbIUyVg4pOQdjrC8uuYuDVYvUQG+3Ki6KLryV0P BgT0uCYzSDkNVEPrqrj8Njx7hXEGvwbuZaFMULAU1a6A0j9qk35t6AzWxRNa8ZWLsbDW VIuMe9H8dDAwuvvvXepoU0hypWxNsDn+Nx5XVJvTsMaJn8FE2mvFN15hy1/ovllQFve1 UeC3ErYEGSaqBKHVspcyptsQJ3T5i+hFq9v7j/lC/+fNiNh3P9cKVM3HDmMX1uXudnV6 toBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I/x8An6SXti07R7+/Bt1kXKVbp/TozSLPGc5SfRA9G4=; b=a2/1svsQp0zxtleKqoN90ipD0vVOM2+hb589zq86D7QAfvO2YpKOi16WKOb8ln07Kl kry1rxAZHBIUXANmhKuZMWwi1pVgwRaeHd5HAWhByE9NfSApkAdC0G4ktAO3ibZBG7Fh Ge+W/0g/l5hgBb4Vpnzu+JhyA6uwnubt+GFD5VuAHU+VszzkVFAk1YaO/aioAazLIbw6 fUbX/ZjSPaaswASfphMfa26mQjgL2CpmtGLqZWzH/cAu88JRBrxBAYCLm8PblcdMuIxe r767WMHvBnWIdj2U8K28w58tn61vKGBZVQPG8Ny5fkmmMeSLJHmafchVAQF01fTYaEED 9pIg== X-Gm-Message-State: AGi0Pub/g+MMXQl7mBor00ZAdIFXcqrK+9KTteN1g/lO0GLtZwoXazem gmhSAyE5xy5gqqxqti7VmxXIFw== X-Google-Smtp-Source: APiQypLMyc9iXIT2gOmeK2EqbCOl+Idkd9uEjvQ42TnYWs5shRvqnUQruptet0p/7dvmK2mQzPSLqg== X-Received: by 2002:a05:6512:46d:: with SMTP id x13mr830338lfd.56.1588120714064; Tue, 28 Apr 2020 17:38:34 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id o23sm770668ljh.63.2020.04.28.17.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 17:38:33 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id D887C10235A; Wed, 29 Apr 2020 03:38:43 +0300 (+03) Date: Wed, 29 Apr 2020 03:38:43 +0300 From: "Kirill A. Shutemov" To: Jesper Dangaard Brouer Cc: netdev@vger.kernel.org, linux-mm@kvack.org, Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , Ilias Apalodimas , willy@infradead.org, Saeed Mahameed , Alexander Duyck , Andrew Morton , mgorman@techsingularity.net, "David S. Miller" , Tariq Toukan Subject: Re: [net-next PATCH V3 1/3] mm: add dma_addr_t to struct page Message-ID: <20200429003843.rh2pasek7v5o3h63@box> References: <155002290134.5597.6544755780651689517.stgit@firesoul> <155002294008.5597.13759027075590385810.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155002294008.5597.13759027075590385810.stgit@firesoul> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 13, 2019 at 02:55:40AM +0100, Jesper Dangaard Brouer wrote: > The page_pool API is using page->private to store DMA addresses. > As pointed out by David Miller we can't use that on 32-bit architectures > with 64-bit DMA > > This patch adds a new dma_addr_t struct to allow storing DMA addresses > > Signed-off-by: Jesper Dangaard Brouer > Signed-off-by: Ilias Apalodimas > Acked-by: Andrew Morton > --- > include/linux/mm_types.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 2c471a2c43fa..0a36a22228e7 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -95,6 +95,13 @@ struct page { > */ > unsigned long private; > }; > + struct { /* page_pool used by netstack */ > + /** > + * @dma_addr: might require a 64-bit value even on > + * 32-bit architectures. > + */ > + dma_addr_t dma_addr; > + }; [ I'm slow, but I've just noticed this change into struct page. ] Is there a change that the dma_addr would have bit 0 set? If yes it may lead to false-positive PageTail() and really strange behaviour. I think it's better to put some padding into the struct to avoid aliasing to compound_head. See commit 1d798ca3f164 ("mm: make compound_head() robust") for context. > struct { /* slab, slob and slub */ > union { > struct list_head slab_list; /* uses lru */ > -- Kirill A. Shutemov