From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D806C8300A for ; Tue, 28 Apr 2020 21:00:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F23F02072A for ; Tue, 28 Apr 2020 21:00:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQtUZub7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F23F02072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5E0678E0017; Tue, 28 Apr 2020 16:59:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 595A78E0007; Tue, 28 Apr 2020 16:59:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 457FB8E0017; Tue, 28 Apr 2020 16:59:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 28CB18E0007 for ; Tue, 28 Apr 2020 16:59:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DEDA052AE for ; Tue, 28 Apr 2020 20:59:52 +0000 (UTC) X-FDA: 76758480624.07.hate18_563ec80929d13 X-HE-Tag: hate18_563ec80929d13 X-Filterd-Recvd-Size: 5244 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Apr 2020 20:59:52 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id g4so258176ljl.2 for ; Tue, 28 Apr 2020 13:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5ldgJ4636CVVH5K09ieY2CjYskH7FkK4YIkv15ewvcg=; b=CQtUZub7pmYCoM9rgBDRF8mOSsdyPuWwmd58ngg3Hlx0WWJBUPyU6nMUtnNSnjSvFi 9PcXKfbggKYCYRv4M2BI1ivQVzjcHHOwxvfjfZv1cqmGM5J25fNWUENTN5J+ek9erpbJ SvkSqmrZut59DzXc+ag223V9aWC3r1f9IWUbXfRi3ACwJp5mu9xU0KxkgDSNH83xyk8x QLhcYVe1OvpcztTL865V1jatwBmH3vn/pkqoIJ7Jxj4NSloLaTRUzsuxaBjRsh1xXLeN hQVUWmQlPqcZEL4nguD8c7Vlkry1FfBNwpumcnUWV6vISLulSNYtcvhuKkiQPO6HLKG6 S9FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ldgJ4636CVVH5K09ieY2CjYskH7FkK4YIkv15ewvcg=; b=niJbGJBTF21QoUgxMIXz5UDCD/GtdpqZDrXqL8y5TMxDLiyt+no+pdpJh38HiuhVGQ MKfWlEShkGQpC5SMBJHu5cYGrrvr3G0ITIgnsA/4THdMlpllNZDfOsRYa7RZatXrSbY6 bV6LoWSypl6q8G1hdlPHbVo+Go8o6dY8ujBb0+YX5aZNLFWMj38c0EU9wys5YxS1h+Pb jwDrjDVPUIi1ZKLGz8RBUUPk+VGzNwk8cb6B9UtxxjmL7m9MnepnB7FVhRTUDXaBU4Z8 JBtAmLEDjKLwUGOvTZC0uGC0bZipVtG127QPed7OMYOYbQDjB+oYnnm9oMw/CciCWsjj TQIw== X-Gm-Message-State: AGi0PuakohZW6BkDZuYOTNt8QPVa+8fK88QZQg8azY+bULaQ8Wh6NBkk KR4HmDxVB7ce9m8OYa/IhPI= X-Google-Smtp-Source: APiQypI7Q10ox7ABU0RMMw3dY9sgNyJEZcaL1fC+sRAcqhh5hwFSEZtLMIISQ2ZVDZMjGMbpQT614Q== X-Received: by 2002:a05:651c:545:: with SMTP id q5mr14996061ljp.57.1588107591349; Tue, 28 Apr 2020 13:59:51 -0700 (PDT) Received: from pc638.lan (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id z21sm295483ljh.42.2020.04.28.13.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 13:59:50 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: LKML , linux-mm@kvack.org Cc: Andrew Morton , "Paul E . McKenney" , "Theodore Y . Ts'o" , Matthew Wilcox , Joel Fernandes , RCU , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 18/24] mm/list_lru.c: Remove kvfree_rcu_local() function Date: Tue, 28 Apr 2020 22:58:57 +0200 Message-Id: <20200428205903.61704-19-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200428205903.61704-1-urezki@gmail.com> References: <20200428205903.61704-1-urezki@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since there is newly introduced kvfree_rcu() API, there is no need in queuing and using call_rcu() to kvfree() an object after the GP. Remove kvfree_rcu_local() function and replace call_rcu() by new kvfree_rcu() API that does the same but in more efficient way. Cc: linux-mm@kvack.org Cc: Andrew Morton Cc: rcu@vger.kernel.org Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Joel Fernandes (Google) Signed-off-by: Joel Fernandes (Google) --- mm/list_lru.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index 42c95bcb53ca..a0b08b27a9b9 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -12,6 +12,7 @@ #include #include #include +#include #include "slab.h" =20 #ifdef CONFIG_MEMCG_KMEM @@ -373,21 +374,13 @@ static void memcg_destroy_list_lru_node(struct list= _lru_node *nlru) struct list_lru_memcg *memcg_lrus; /* * This is called when shrinker has already been unregistered, - * and nobody can use it. So, there is no need to use kvfree_rcu_local(= ). + * and nobody can use it. So, there is no need to use kvfree_rcu(). */ memcg_lrus =3D rcu_dereference_protected(nlru->memcg_lrus, true); __memcg_destroy_list_lru_node(memcg_lrus, 0, memcg_nr_cache_ids); kvfree(memcg_lrus); } =20 -static void kvfree_rcu_local(struct rcu_head *head) -{ - struct list_lru_memcg *mlru; - - mlru =3D container_of(head, struct list_lru_memcg, rcu); - kvfree(mlru); -} - static int memcg_update_list_lru_node(struct list_lru_node *nlru, int old_size, int new_size) { @@ -419,7 +412,7 @@ static int memcg_update_list_lru_node(struct list_lru= _node *nlru, rcu_assign_pointer(nlru->memcg_lrus, new); spin_unlock_irq(&nlru->lock); =20 - call_rcu(&old->rcu, kvfree_rcu_local); + kvfree_rcu(old, rcu); return 0; } =20 --=20 2.20.1