From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A07C4CECC for ; Mon, 27 Apr 2020 19:26:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 97F1D214AF for ; Mon, 27 Apr 2020 19:26:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sqav9Y/S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97F1D214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1FA668E0005; Mon, 27 Apr 2020 15:26:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AA7D8E0001; Mon, 27 Apr 2020 15:26:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BFE98E0005; Mon, 27 Apr 2020 15:26:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id E3EF68E0001 for ; Mon, 27 Apr 2020 15:26:08 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 971AE8248047 for ; Mon, 27 Apr 2020 19:26:08 +0000 (UTC) X-FDA: 76754615616.10.duck73_52b171364bb62 X-HE-Tag: duck73_52b171364bb62 X-Filterd-Recvd-Size: 2245 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Apr 2020 19:26:08 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 176BE20775; Mon, 27 Apr 2020 19:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588015567; bh=78FSdmryfDcWh8nNrKD1ELHe02HQDSNEuFChSLKV3Ug=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sqav9Y/SwqxoyMEJHzu5dvSUIyn0Vx3vDrhV3FcKsRgGmHkKuwcQuSEiZMKHMaHde lqyR6D58PWaB7QVenVZajXB6HZIiqDGwICxWLKYkP4txppp3SdKAMA9GB6B+6w0fdG u0yE+tV3X0WZ3eoVJSpK6wuJKPtFKYlI5oLfW9RU= Date: Mon, 27 Apr 2020 12:26:06 -0700 From: Andrew Morton To: Souptick Joarder Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/gup.c: Updating the documentation Message-Id: <20200427122606.dc29c381f6da47831a40d365@linux-foundation.org> In-Reply-To: <1588013630-4497-1-git-send-email-jrdr.linux@gmail.com> References: <1588013630-4497-1-git-send-email-jrdr.linux@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 28 Apr 2020 00:23:50 +0530 Souptick Joarder wrote: > This patch is an attempt to update the documentation. > > * Adding / removing extra * based on type of function > static / global. I don't think so, unless this is a new kerneldoc convention? > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -722,7 +722,7 @@ static struct page *follow_p4d_mask(struct vm_area_struct *vma, > return follow_pud_mask(vma, address, p4d, flags, ctx); > } > > -/** > +/* > * follow_page_mask - look up a page descriptor from a user-virtual address > * @vma: vm_area_struct mapping @address > * @address: virtual address to look up /** indicates that the comment is in kerneldoc form, not that it has static scope?