From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=FAKE_REPLY_C, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7C5C55199 for ; Sun, 26 Apr 2020 07:44:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 13FC32070A for ; Sun, 26 Apr 2020 07:44:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13FC32070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9A5EC8E0005; Sun, 26 Apr 2020 03:44:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956178E0003; Sun, 26 Apr 2020 03:44:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 844B58E0005; Sun, 26 Apr 2020 03:44:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 6A76A8E0003 for ; Sun, 26 Apr 2020 03:44:00 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0E9E0180AD811 for ; Sun, 26 Apr 2020 07:44:00 +0000 (UTC) X-FDA: 76749217440.30.plant46_5c39c67bc212 X-HE-Tag: plant46_5c39c67bc212 X-Filterd-Recvd-Size: 2941 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Sun, 26 Apr 2020 07:43:59 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2558868C65; Sun, 26 Apr 2020 09:43:56 +0200 (CEST) Date: Sun, 26 Apr 2020 09:43:55 +0200 From: Christoph Hellwig To: Andrew Morton Cc: kbuild test robot , Christoph Hellwig , kbuild-all@lists.01.org, Linux Memory Management List , Alexei Starovoitov , Daniel Borkmann Subject: Re: [linux-next:master 4466/4894] kernel/bpf/syscall.c:305:58: error: 'VMALLOC_END' undeclared; did you mean 'VM_LOCKED'? Message-ID: <20200426074355.GB31501@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200425170909.dfa87562035f3f9d0abbf417@linux-foundation.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 25, 2020 at 05:09:09PM -0700, Andrew Morton wrote: > On Sun, 26 Apr 2020 04:25:54 +0800 kbuild test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 8bdabd09ec86a993419c8c98a4f34c12bc902c6c > > commit: d4493a599f1aa34153b047da482cf6419f3c79dc [4466/4894] mm: remove vmalloc_user_node_flags > > config: riscv-randconfig-a001-20200426 (attached as .config) > > compiler: riscv64-linux-gcc (GCC) 9.3.0 > > reproduce: > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > git checkout d4493a599f1aa34153b047da482cf6419f3c79dc > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv > > > > kernel/bpf/syscall.c: In function '__bpf_map_area_alloc': > > >> kernel/bpf/syscall.c:305:58: error: 'VMALLOC_END' undeclared (first use in this function); did you mean 'VM_LOCKED'? > > 305 | return __vmalloc_node_range(size, align, VMALLOC_START, VMALLOC_END, > > CONFIG_MMU=n. > > I guess this will suffice? It should. But I wonder if BPF actually even has a chance of working on nommu configs.. > > --- a/arch/riscv/include/asm/pgtable.h~mm-switch-the-test_vmalloc-module-to-use-__vmalloc_node-fix-fix > +++ a/arch/riscv/include/asm/pgtable.h > @@ -472,9 +472,9 @@ static inline int ptep_clear_flush_young > > #define PAGE_KERNEL __pgprot(0) > #define swapper_pg_dir NULL > +#define TASK_SIZE 0xffffffffUL > #define VMALLOC_START 0 > - > -#define TASK_SIZE 0xffffffffUL > +#define VMALLOC_END TASK_SIZE > > #endif /* !CONFIG_MMU */ > > > It could be any value, really - we just need VMALLOC_END there to make > the compiler happy. ---end quoted text---