From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B110C2BA1A for ; Sat, 25 Apr 2020 00:30:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3BE9820748 for ; Sat, 25 Apr 2020 00:30:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R9Qpzj/q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BE9820748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C39C58E0005; Fri, 24 Apr 2020 20:30:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE9248E0003; Fri, 24 Apr 2020 20:30:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFF5C8E0005; Fri, 24 Apr 2020 20:30:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 952AA8E0003 for ; Fri, 24 Apr 2020 20:30:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 43E7C180AD81D for ; Sat, 25 Apr 2020 00:30:15 +0000 (UTC) X-FDA: 76744495590.23.chain51_597c007128924 X-HE-Tag: chain51_597c007128924 X-Filterd-Recvd-Size: 4153 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Apr 2020 00:30:14 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id b11so13473241wrs.6 for ; Fri, 24 Apr 2020 17:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y7OSUUlX1RAKYJlkMObxl1MgLKnZif1MLfSHlBdua08=; b=R9Qpzj/qsrg1RgIMyKxMuRZqV0VSAH97oK37CFZM5ozt5vphDVIFHcl2Uy/gvoC+DJ Y2KD1LTYctrrCf5mmK39OhbpSqNTfsX08slzpnSDkq17KRsDx4Tps6t16gl9HBUs4eFP NQO7s4VHZdG9saXIe3O9HYXUSsD6DD76ZdmuLvEwj0PiY+SwsvkJxKETZgfaEKETmIGs MFU1IhyH5IkiHGJmcPWw8amU30qfBUMi9j8ReiCvaNwDKY0IwwWJTkIbu9tdSM0/lBLm JBrWhMFv3wFNM6YsWvUlZLUN+MlQ8sh4uWUC/lpb3uhHoe3C4ilQcgcxAI8hC4bi0/Oz gRIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=y7OSUUlX1RAKYJlkMObxl1MgLKnZif1MLfSHlBdua08=; b=M4yBGjiNLgLvaGJ5sD1lYMELKEIJDtDaY/XiLs2x07+eZH/T6R5zIrgMnK/uJcmw15 xUBUCInkW1BjHssPnlwhcYCVuFz7ll5V4Lpth5OOhpr4/HlBL8NslmBFnQwLV1aTOWSg yZWayiwH7vbSqc4X+GRxClFITqzHSpqzTOPgwd1H02mATwH7bmLn4JswdJgyVT66XFTb ArfZTLdUBfb9WaXOc6ym/wUNaMCghx7PWhI/ezRfKCKwLEvZWfE8majz65yISG0zi+IT EWXXW37H4muysof/pRG5K3sojvcR9xOSQSlzsH5b8tJ8sCRS/bdaDzck5Cc/bwzUW09o ITSA== X-Gm-Message-State: AGi0PuZN5yndDCdZvPaYmfaYwc8GYUXmdcCCgEM/vuxMeYEMqKjK48y8 g9fWIiMQWp2Lgsjsd7rypUY= X-Google-Smtp-Source: APiQypJe/RyviRQ0Arjdjlyd8vAASJTdfNB3Qjqis+cugV3WpQ+RlbOTL4FAJYn5Yn1+8C+Goz+KLg== X-Received: by 2002:a5d:4a4b:: with SMTP id v11mr13587375wrs.32.1587774613609; Fri, 24 Apr 2020 17:30:13 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id k17sm5000384wmi.10.2020.04.24.17.30.12 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Apr 2020 17:30:12 -0700 (PDT) Date: Sat, 25 Apr 2020 00:30:12 +0000 From: Wei Yang To: "Huang, Ying" Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v2] mm/swapfile.c: simplify the scan loop in scan_swap_map_slots() Message-ID: <20200425003012.uuqh547feq3kz4y5@master> Reply-To: Wei Yang References: <20200422214111.19370-1-richard.weiyang@gmail.com> <87d07y2181.fsf@yhuang-dev.intel.com> <20200423131507.2rgrk3okh42oo6gh@master> <87r1wdzlm5.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r1wdzlm5.fsf@yhuang-dev.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 24, 2020 at 10:02:58AM +0800, Huang, Ying wrote: >Wei Yang writes: > [...] >>> >>>if "offset > si->highest_bit" is true and "offset < scan_base" is true, >>>scan_base need to be returned. >>> >> >> When this case would happen in the original code? > >In the original code, the loop can still stop. > Sorry, I don't get your point yet. In original code, there are two separate loops while (++offset <= si->highest_bit) { } while (offset < scan_base) { } And for your condition, (offset > highest_bit) && (offset < scan_base), which terminates the first loop and fits the second loop well. Not sure how this condition would stop the loop in original code? >Best Regards, >Huang, Ying > >>>Again, the new code doesn't make it easier to find this kind of issues. >>> >>>Best Regards, >>>Huang, Ying -- Wei Yang Help you, Help me