* Re: [PATCH v4 7/7] kernel.h: Split out might_sleep() and friends
[not found] <20200422125201.37618-7-andriy.shevchenko@linux.intel.com>
@ 2020-04-24 15:49 ` kbuild test robot
2020-04-24 17:45 ` kbuild test robot
1 sibling, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-04-24 15:49 UTC (permalink / raw)
To: Andy Shevchenko, Andrew Morton, linux-kernel, Steven Rostedt,
Rasmus Villemoes, Joe Perches
Cc: kbuild-all, Linux Memory Management List, Andy Shevchenko
[-- Attachment #1: Type: text/plain, Size: 4040 bytes --]
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20200423]
[cannot apply to tip/locking/core rcu/dev linus/master tip/x86/core v5.7-rc2 v5.7-rc1 v5.6 v5.7-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/drm-shmobile-Reduce-include-dependencies/20200424-044529
base: aefe184e814492e36b2ca350c1522bd71b09b520
config: mips-malta_kvm_guest_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/cpumask.h:12,
from arch/mips/include/asm/processor.h:15,
from arch/mips/include/asm/thread_info.h:16,
from include/linux/thread_info.h:39,
from include/asm-generic/current.h:5,
from ./arch/mips/include/generated/asm/current.h:1,
from include/linux/might_sleep.h:6,
from include/linux/kernel.h:14,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/compat.h:10,
from arch/mips/kernel/asm-offsets.c:12:
include/linux/bitmap.h: In function 'bitmap_equal':
>> include/linux/bitmap.h:339:6: error: implicit declaration of function 'IS_ALIGNED' [-Werror=implicit-function-declaration]
339 | IS_ALIGNED(nbits, BITMAP_MEM_ALIGNMENT))
| ^~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:100: arch/mips/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1142: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:180: sub-make] Error 2
vim +/IS_ALIGNED +339 include/linux/bitmap.h
21035965f60b050 Omar Sandoval 2018-04-02 332
^1da177e4c3f415 Linus Torvalds 2005-04-16 333 static inline int bitmap_equal(const unsigned long *src1,
3d6684f4e6a46f3 Rasmus Villemoes 2014-08-06 334 const unsigned long *src2, unsigned int nbits)
^1da177e4c3f415 Linus Torvalds 2005-04-16 335 {
4b0bc0bca83f3fb Rusty Russell 2008-12-30 336 if (small_const_nbits(nbits))
^1da177e4c3f415 Linus Torvalds 2005-04-16 337 return !((*src1 ^ *src2) & BITMAP_LAST_WORD_MASK(nbits));
21035965f60b050 Omar Sandoval 2018-04-02 338 if (__builtin_constant_p(nbits & BITMAP_MEM_MASK) &&
21035965f60b050 Omar Sandoval 2018-04-02 @339 IS_ALIGNED(nbits, BITMAP_MEM_ALIGNMENT))
7dd968163f7c12b Martin Schwidefsky 2016-05-25 340 return !memcmp(src1, src2, nbits / 8);
^1da177e4c3f415 Linus Torvalds 2005-04-16 341 return __bitmap_equal(src1, src2, nbits);
^1da177e4c3f415 Linus Torvalds 2005-04-16 342 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 343
:::::: The code at line 339 was first introduced by commit
:::::: 21035965f60b0502fc6537b232839389bb4ce664 bitmap: fix memset optimization on big-endian systems
:::::: TO: Omar Sandoval <osandov@fb.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20998 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v4 7/7] kernel.h: Split out might_sleep() and friends
[not found] <20200422125201.37618-7-andriy.shevchenko@linux.intel.com>
2020-04-24 15:49 ` [PATCH v4 7/7] kernel.h: Split out might_sleep() and friends kbuild test robot
@ 2020-04-24 17:45 ` kbuild test robot
1 sibling, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-04-24 17:45 UTC (permalink / raw)
To: Andy Shevchenko, Andrew Morton, linux-kernel, Steven Rostedt,
Rasmus Villemoes, Joe Perches
Cc: kbuild-all, Linux Memory Management List, Andy Shevchenko
[-- Attachment #1: Type: text/plain, Size: 4519 bytes --]
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20200423]
[cannot apply to tip/locking/core rcu/dev linus/master tip/x86/core v5.7-rc2 v5.7-rc1 v5.6 v5.7-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/drm-shmobile-Reduce-include-dependencies/20200424-044529
base: aefe184e814492e36b2ca350c1522bd71b09b520
config: parisc-allnoconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/asm-generic/current.h:5,
from ./arch/parisc/include/generated/asm/current.h:1,
from include/linux/might_sleep.h:6,
from include/linux/kernel.h:14,
from arch/parisc/include/asm/bug.h:5,
from include/linux/bug.h:5,
from include/linux/page-flags.h:10,
from kernel/bounds.c:10:
include/linux/thread_info.h: In function 'copy_overflow':
>> include/linux/thread_info.h:135:2: error: implicit declaration of function 'WARN' [-Werror=implicit-function-declaration]
135 | WARN(1, "Buffer overflow detected (%d < %lu)!\n", size, count);
| ^~~~
include/linux/thread_info.h: In function 'check_copy_size':
>> include/linux/thread_info.h:151:6: error: implicit declaration of function 'WARN_ON_ONCE' [-Werror=implicit-function-declaration]
151 | if (WARN_ON_ONCE(bytes > INT_MAX))
| ^~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:100: kernel/bounds.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1142: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:180: sub-make] Error 2
vim +/WARN +135 include/linux/thread_info.h
b0377fedb65280 Al Viro 2017-06-29 132
b0377fedb65280 Al Viro 2017-06-29 133 static inline void copy_overflow(int size, unsigned long count)
b0377fedb65280 Al Viro 2017-06-29 134 {
b0377fedb65280 Al Viro 2017-06-29 @135 WARN(1, "Buffer overflow detected (%d < %lu)!\n", size, count);
b0377fedb65280 Al Viro 2017-06-29 136 }
b0377fedb65280 Al Viro 2017-06-29 137
9dd819a15162f8 Kees Cook 2019-09-25 138 static __always_inline __must_check bool
b0377fedb65280 Al Viro 2017-06-29 139 check_copy_size(const void *addr, size_t bytes, bool is_source)
b0377fedb65280 Al Viro 2017-06-29 140 {
b0377fedb65280 Al Viro 2017-06-29 141 int sz = __compiletime_object_size(addr);
b0377fedb65280 Al Viro 2017-06-29 142 if (unlikely(sz >= 0 && sz < bytes)) {
b0377fedb65280 Al Viro 2017-06-29 143 if (!__builtin_constant_p(bytes))
b0377fedb65280 Al Viro 2017-06-29 144 copy_overflow(sz, bytes);
b0377fedb65280 Al Viro 2017-06-29 145 else if (is_source)
b0377fedb65280 Al Viro 2017-06-29 146 __bad_copy_from();
b0377fedb65280 Al Viro 2017-06-29 147 else
b0377fedb65280 Al Viro 2017-06-29 148 __bad_copy_to();
b0377fedb65280 Al Viro 2017-06-29 149 return false;
b0377fedb65280 Al Viro 2017-06-29 150 }
6d13de1489b6bf Kees Cook 2019-12-04 @151 if (WARN_ON_ONCE(bytes > INT_MAX))
6d13de1489b6bf Kees Cook 2019-12-04 152 return false;
b0377fedb65280 Al Viro 2017-06-29 153 check_object_size(addr, bytes, is_source);
b0377fedb65280 Al Viro 2017-06-29 154 return true;
b0377fedb65280 Al Viro 2017-06-29 155 }
b0377fedb65280 Al Viro 2017-06-29 156
:::::: The code at line 135 was first introduced by commit
:::::: b0377fedb6528087ed319b0d054d6ed82240372c copy_{to,from}_user(): consolidate object size checks
:::::: TO: Al Viro <viro@zeniv.linux.org.uk>
:::::: CC: Al Viro <viro@zeniv.linux.org.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 5611 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread