From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE76AC55191 for ; Fri, 24 Apr 2020 22:32:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73A1220728 for ; Fri, 24 Apr 2020 22:32:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73A1220728 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BA6558E0005; Fri, 24 Apr 2020 18:32:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B56338E0003; Fri, 24 Apr 2020 18:32:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6B3D8E0005; Fri, 24 Apr 2020 18:32:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 916C48E0003 for ; Fri, 24 Apr 2020 18:32:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4685468A2 for ; Fri, 24 Apr 2020 22:32:14 +0000 (UTC) X-FDA: 76744198188.08.man42_4db5f3f6ad415 X-HE-Tag: man42_4db5f3f6ad415 X-Filterd-Recvd-Size: 3298 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Apr 2020 22:32:13 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id h11so4266977plr.11 for ; Fri, 24 Apr 2020 15:32:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CTYT7xL9yF3Xv9mhQIugx9s6BA/cd6XZnpJVcb1O0IU=; b=AjDdzJOpr0QBE2zAxSFim31Q6Pk1aV9782QZLwDrM10/pqB/2kcY/5O8OwlKHkxEtG iaF4Pp/jgETiC2995Et+qOKrkCnpyIihayXbaFi9ntaU8fcu+z2yO+U1TNvzM6u6aasv wRNYstYWgiawRDYzuUnVkVrQOFApMySSI0TXLeyMqcvKxNBcInqoyVSDLcjprzrAKQ99 vQxA7rZ5vnayUPnDjciOF+2PbT2xn6t7jM58C09EbzGLLva9S82TPdD5Q0rglBU1XDCX VQFP0GoCaFcIjo2+oBMtpMDidgsrt0hJ+ejaLFQgnPVBsq1DUiEmbajYBAfwsqNj5RyV QUgg== X-Gm-Message-State: AGi0PuYx9FVwl2tTskxVqHMjWbdfiaqAj4qBnPjojwHN/ZB5ivLt41DQ Ee1LHSksuZ5BJe96PvQAOlg= X-Google-Smtp-Source: APiQypLJjYsyYI1QN9XpzlSgOnj6dDuXwttt3S4K9LN5RuJFPGbuPhITsepw8rgF04Qmxl2GV3dlGA== X-Received: by 2002:a17:902:c381:: with SMTP id g1mr11203988plg.135.1587767532903; Fri, 24 Apr 2020 15:32:12 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id j14sm5729725pjm.27.2020.04.24.15.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2020 15:32:11 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id E548F403AB; Fri, 24 Apr 2020 22:32:10 +0000 (UTC) Date: Fri, 24 Apr 2020 22:32:10 +0000 From: Luis Chamberlain To: Bart Van Assche Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/10] block: put_device() if device_add() fails Message-ID: <20200424223210.GD11244@42.do-not-panic.com> References: <20200419194529.4872-1-mcgrof@kernel.org> <20200419194529.4872-11-mcgrof@kernel.org> <85a18bcf-4bd0-a529-6c3c-46fcd23a350e@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85a18bcf-4bd0-a529-6c3c-46fcd23a350e@acm.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000246, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 19, 2020 at 04:40:45PM -0700, Bart Van Assche wrote: > On 4/19/20 12:45 PM, Luis Chamberlain wrote: > > Through code inspection I've found that we don't put_device() if > > device_add() fails, and this must be done to decrement its refcount. > > Reviewed-by: Bart Van Assche Turns out this is wrong, as bdi needs it still, we have can only remove it once all users are done, which should be at the disk_release() path. I've found this while adding the errors paths missing. Luis