From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD93C54FCB for ; Fri, 24 Apr 2020 13:33:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49A2C20767 for ; Fri, 24 Apr 2020 13:33:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tO7Lfoj3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49A2C20767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C01BD8E0005; Fri, 24 Apr 2020 09:33:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB2648E0003; Fri, 24 Apr 2020 09:33:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC7D38E0005; Fri, 24 Apr 2020 09:33:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 9173D8E0003 for ; Fri, 24 Apr 2020 09:33:45 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 515F0181AC9B6 for ; Fri, 24 Apr 2020 13:33:45 +0000 (UTC) X-FDA: 76742841210.24.pain24_20b868924d462 X-HE-Tag: pain24_20b868924d462 X-Filterd-Recvd-Size: 9507 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Apr 2020 13:33:44 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id m2so7690395lfo.6 for ; Fri, 24 Apr 2020 06:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:references:mime-version:message-id :content-transfer-encoding; bh=/2iFAIsn0NcyKcRJ0BGzhiCPxGv6zQd2IVlzakCpbTQ=; b=tO7Lfoj3rW23QbrKFJxLvukPYms8WpLxDEEcaaIctPbNmiNVSjN0bKnxgYMrD/fHVi 4jwGHvVFZreW0dChAwgIki8M0gM/hjbj+AJB8NXKL+DRx0f/+6uZfbxuqdKl4W1d2THt REi89IEKFKpkefn3BuY+1XLfiVH164XldEZFBxLoxFmY3rz81+LFzstYMC7V0hlOyW7Q axlsvsKbww9bo2wCE+/W8nYzopoaUe5YsS9ObBpGHvow8A+oXNXwF+yiqVGoSsoW+cJ2 RRpEBzh+6diFQUDjK1DK1AYw/EJSreajodjPr6sEtF1ZTxMtemSRNj9qohYqquoAIwxB 2V/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:references:mime-version :message-id:content-transfer-encoding; bh=/2iFAIsn0NcyKcRJ0BGzhiCPxGv6zQd2IVlzakCpbTQ=; b=HXZnjUm1/OaZg+GuC4MWfPRq5LEw8dUjOPofgwcCcDpW0O5Wok3rDR7tiXG3pladuN rmx5RCc3Q37kUbL/Rwekllx6bD9vfkSbdkAlhtbttvQQCrKeyKYUB8fpRb/hpYW5EbqV ftm1/V/p4zGvjmpgLORa2TM0AfBiA4DrrNPeNSPXS5aXiNdN/045BKUU0W1417j6W5dT CjGOtHNLFSmWIMI6zaZqe/9z8X3WWeOtQP6Dz2X6unYvh47LHnvr/euVbbbUdD1NxFB3 RAOpg3qIhfdcoLaIMsOKc8uRW9JXk8H4K94P3LqqO4CG2VJpEU+JnXInCZk3OiEYt9Ug T5Mw== X-Gm-Message-State: AGi0PuZtbamc3H7Ue+6xexMNuC4SzJH+taj/RU8EGztVluq8ZR33WZj7 r9p6p6jTgHtAVYX6vruFefA= X-Google-Smtp-Source: APiQypL10UtKtj5fBkwyoIycogebndhjg2/bopyM/6ziEMg9MXfmZBfhYyvP0hH8Pz0Rp5fF1sFCXw== X-Received: by 2002:ac2:5e66:: with SMTP id a6mr6486043lfr.177.1587735223183; Fri, 24 Apr 2020 06:33:43 -0700 (PDT) Received: from N-20L6PF1KTYA2 ([131.228.2.20]) by smtp.gmail.com with ESMTPSA id m29sm4304119ljc.24.2020.04.24.06.33.40 (version=TLS1_2 cipher=AES128-GCM-SHA256 bits=128/128); Fri, 24 Apr 2020 06:33:42 -0700 (PDT) Date: Fri, 24 Apr 2020 21:33:40 +0800 From: "Li Xinhai" To: "Jason Gunthorpe" Cc: "Mike Kravetz" , "linux-mm@kvack.org" , akpm , "Punit Agrawal" , Longpeng Subject: Re: [PATCH] mm/hugetlb: avoid unnecessary check on pud and pmd entry in huge_pte_offset References: <1587646154-26276-1-git-send-email-lixinhai.lxh@gmail.com>, , <20200423183835.GA13640@mellanox.com>, <202004241207494655904@gmail.com>, <20200424125753.GK13640@mellanox.com> X-Priority: 3 X-GUID: 84FD870D-5325-4347-B027-8D83890B9165 X-Has-Attach: no X-Mailer: Foxmail 7.2.13.365[cn] Mime-Version: 1.0 Message-ID: <2020042421333861801820@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: T24gMjAyMC0wNC0yNMKgYXQgMjA6NTfCoEphc29uIEd1bnRob3JwZcKgd3JvdGU6Cj5PbiBGcmks IEFwciAyNCwgMjAyMCBhdCAxMjowNzo1MFBNICswODAwLCBMaSBYaW5oYWkgd3JvdGU6Cj4+IE9u IDIwMjAtMDQtMjTCoGF0IDAyOjM4wqBKYXNvbiBHdW50aG9ycGXCoHdyb3RlOgo+PiA+T24gVGh1 LCBBcHIgMjMsIDIwMjAgYXQgMTE6MTQ6MjhBTSAtMDcwMCwgTWlrZSBLcmF2ZXR6IHdyb3RlOgo+ PiA+PiBDYyBhIGZldyBwZW9wbGUgd2hvIGhhdmUgbG9va2VkIGF0IGh1Z2VfcHRlX29mZnNldCgp IHJlY2VudGx5Lgo+PiA+Pgo+PiA+PiBPbiA0LzIzLzIwIDU6NDkgQU0sIExpIFhpbmhhaSB3cm90 ZToKPj4gPj4gPiBXaGVuIGh1Z2VfcHRlX29mZnNldCgpIGlzIGNhbGxlZCwgdGhlIHBhcmFtZXRl ciBzeiBjYW4gb25seSBiZSBQVURfU0laRQo+PiA+PiA+IG9yIFBNRF9TSVpFLgo+PiA+PiA+IElm IHN6IGlzIFBVRF9TSVpFIGFuZCBjb2RlIGNhbiByZWFjaCBwdWQsIHRoZW4gKnB1ZCBtdXN0IGJl IG5vbmUsIG9yCj4+ID4+ID4gbm9ybWFsIGh1Z2V0bGIgZW50cnksIG9yIG5vbi1wcmVzZW50ICht aWdyYXRpb24gb3IgaHdwb2lzb25lZCkgaHVnZXRsYgo+PiA+PiA+IGVudHJ5LCBhbmQgd2UgY2Fu IGRpcmVjdGx5IHJldHVybiBwdWQuCj4+ID4+ID4gV2hlbiBzeiBpcyBQTURfU0laRSwgcHVkIG11 c3QgYmUgbm9uZSBvciBwcmVzZW50LCBhbmQgaWYgY29kZSBjYW4gcmVhY2gKPj4gPj4gPiBwbWQs IHdlIGNhbiBkaXJlY3RseSByZXR1cm4gcG1kLgo+PiA+PiA+Cj4+ID4+ID4gU28sIGFmdGVyIHRo aXMgcGF0Y2gsIHRoZSBjb2RlIGlzIHNpbXBsaWZpZWQgYnkgZmlyc3QgY2hlY2sgb24gdGhlCj4+ ID4+ID4gcGFyYW1ldGVyIHN6LCBhbmQgYXZvaWQgdW5uZWNlc3NhcnkgY2hlY2tzIGluIGN1cnJl bnQgY29kZS4KPj4gPj4gPgo+PiA+PiA+IFNpZ25lZC1vZmYtYnk6IExpIFhpbmhhaSA8bGl4aW5o YWkubHhoQGdtYWlsLmNvbT4KPj4gPj4gPiBDYzogTWlrZSBLcmF2ZXR6IDxtaWtlLmtyYXZldHpA b3JhY2xlLmNvbT4KPj4gPj4gPiBDYzogQW5kcmV3IE1vcnRvbiA8YWtwbUBsaW51eC1mb3VuZGF0 aW9uLm9yZz4KPj4gPj4gPsKgIG1tL2h1Z2V0bGIuYyB8IDI0ICsrKysrKysrKy0tLS0tLS0tLS0t LS0tLQo+PiA+PiA+wqAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRp b25zKC0pCj4+ID4+ID4KPj4gPj4gPiBkaWZmIC0tZ2l0IGEvbW0vaHVnZXRsYi5jIGIvbW0vaHVn ZXRsYi5jCj4+ID4+ID4gaW5kZXggYmNhYmJlMC4uZTE0MjRmNSAxMDA2NDQKPj4gPj4gPiArKysg Yi9tbS9odWdldGxiLmMKPj4gPj4gPiBAQCAtNTM2NSw4ICs1MzY1LDggQEAgcHRlX3QgKmh1Z2Vf cHRlX29mZnNldChzdHJ1Y3QgbW1fc3RydWN0ICptbSwKPj4gPj4gPsKgIHsKPj4gPj4gPsKgIHBn ZF90ICpwZ2Q7Cj4+ID4+ID7CoCBwNGRfdCAqcDRkOwo+PiA+PiA+IC0JcHVkX3QgKnB1ZCwgcHVk X2VudHJ5Owo+PiA+PiA+IC0JcG1kX3QgKnBtZCwgcG1kX2VudHJ5Owo+PiA+PiA+ICsJcHVkX3Qg KnB1ZDsKPj4gPj4gPiArCXBtZF90ICpwbWQ7Cj4+ID4+ID7CoAo+PiA+PiA+wqAgcGdkID0gcGdk X29mZnNldChtbSwgYWRkcik7Cj4+ID4+ID7CoCBpZiAoIXBnZF9wcmVzZW50KCpwZ2QpKQo+PiA+ PiA+IEBAIC01Mzc2LDIyICs1Mzc2LDE2IEBAIHB0ZV90ICpodWdlX3B0ZV9vZmZzZXQoc3RydWN0 IG1tX3N0cnVjdCAqbW0sCj4+ID4+ID7CoCByZXR1cm4gTlVMTDsKPj4gPj4gPsKgCj4+ID4+ID7C oCBwdWQgPSBwdWRfb2Zmc2V0KHA0ZCwgYWRkcik7Cj4+ID4+ID4gLQlwdWRfZW50cnkgPSBSRUFE X09OQ0UoKnB1ZCk7Cj4+ID4+ID4gLQlpZiAoc3ogIT0gUFVEX1NJWkUgJiYgcHVkX25vbmUocHVk X2VudHJ5KSkKPj4gPj4gPiAtCXJldHVybiBOVUxMOwo+PiA+PiA+IC0JLyogaHVnZXBhZ2Ugb3Ig c3dhcD8gKi8KPj4gPj4gPiAtCWlmIChwdWRfaHVnZShwdWRfZW50cnkpIHx8ICFwdWRfcHJlc2Vu dChwdWRfZW50cnkpKQo+PiA+PiA+ICsJaWYgKHN6ID09IFBVRF9TSVpFKQo+PiA+PiA+ICsJLyog bXVzdCBiZSBwdWRfaHVnZSBvciBwdWRfbm9uZSAqLwo+PiA+PiA+wqAgcmV0dXJuIChwdGVfdCAq KXB1ZDsKPj4gPj4gPiAtCj4+ID4+ID4gLQlwbWQgPSBwbWRfb2Zmc2V0KHB1ZCwgYWRkcik7Cj4+ ID4+ID4gLQlwbWRfZW50cnkgPSBSRUFEX09OQ0UoKnBtZCk7Cj4+ID4+ID4gLQlpZiAoc3ogIT0g UE1EX1NJWkUgJiYgcG1kX25vbmUocG1kX2VudHJ5KSkKPj4gPj4gPiArCWlmICghcHVkX3ByZXNl bnQoKnB1ZCkpCj4+ID4+ID7CoCByZXR1cm4gTlVMTDsKPj4gPj4gPiAtCS8qIGh1Z2VwYWdlIG9y IHN3YXA/ICovCj4+ID4+ID4gLQlpZiAocG1kX2h1Z2UocG1kX2VudHJ5KSB8fCAhcG1kX3ByZXNl bnQocG1kX2VudHJ5KSkKPj4gPj4gPiAtCXJldHVybiAocHRlX3QgKilwbWQ7Cj4+ID4+ID4gKwkv KiBtdXN0IGhhdmUgYSB2YWxpZCBlbnRyeSBhbmQgc2l6ZSB0byBnbyBmdXJ0aGVyICovCj4+ID4+ ID7CoAo+PiA+PiA+IC0JcmV0dXJuIE5VTEw7Cj4+ID4+ID4gKwlwbWQgPSBwbWRfb2Zmc2V0KHB1 ZCwgYWRkcik7Cj4+ID4+Cj4+ID4+IENhbiB3ZSBnZXQgaGVyZSB3aXRoIHN6ID0gUE1EX1NJWkUg YW5kIHB1ZF9ub25lKCpwdWQpP8KgIFdvdWxkIHRoYXQgYmUKPj4gPj4gYW4gaXNzdWUgZm9yIHRo ZSBwbWRfb2Zmc2V0KCkgY2FsbD8KPj4gPgo+PiA+Q2VydGFpbmx5IHBtZF9vZmZzZXQoKSBtdXN0 IG9ubHkgYmUgY2FsbGVkIGlmIHRoZSBQVUQgZW50cnkgaXMKPj4gPnBvaW50aW5nIGF0IGEgcG1k IGxldmVsLgo+PiA+Cj4+ID5BRkFJSyB0aGlzIG1lYW5zIGl0IHNob3VsZCBub3QgYmUgY2FsbGVk IG9uIHB1ZF9ub25lKCksIHB1ZF9odWdlKCkgb3IKPj4gPiFwdWRfcHJlc2VudCgpIGNhc2VzLgo+ Pgo+PiBUaGUgdGVzdCBvZsKgIXB1ZF9wcmVzZW50KCpwdWQpIGFsc28gYmxvY2sgcHVkX25vbmUo KnB1ZCkKPgo+U3VyZQo+Cj4+ICwgc28gd2hlbiBzeiA9PSBQTURfU0laRSwgcG1kX29mZnNldCgp IG9ubHkgY2FsbGVkIHdpdGggYSB2YWxpZCBQVUQKPj4gZW50cnkgd2hpY2ggcG9pbnQgdG8gUE1E IHBhZ2UgdGFibGUuCj4KPkJ1dCB3aGF0IHByZXZlbnRzIHB1ZF9odWdlPwo+IAppZiBzeiA9PSBQ VURfU0laRSwgdGhlICdyZXR1cm4gKHB0ZV90KilwdWQnIGFscmFkeSBlbmQgdGhlIGZ1bmN0aW9u LCB3aGljaCBjb3ZlcgpwdWRfaHVnZSgpIGFuZCBwdWRfbm9uZSgpLCBiZWNhdXNlIHdlIHRoZSBt YXBwaW5nIGlzIGZvciBQVURfU0laRSBodWdlIHBhZ2UuCgpTbywgdGhlcmUgaXMgbm8gcG9zc2li aWxpdHkgZm9yIHBtZF9vZmZzZXQoKSBiZWVuIGNhbGxlZCB3aXRoIGludmFsaWQgcHVkIGVudHJ5 LgpCZWxvdyBpcyB0aGUgY29kZSBJIHVzZWQgZm9yIHRlc3Qgd2hpY2ggaGFzIEJVR19PTiwgdGhh dCBzaG91bGQgZ2l2ZSBtb3JlCmNsZWFyIGlkZWEgYWJvdXQgdGhlIHNlbWFudGljcyBvZiBjb2Rl IHBhdGg6CgouLi4KCXB1ZCA9IHB1ZF9vZmZzZXQocDRkLCBhZGRyKTsKCWlmIChzeiA9PSBQVURf U0laRSkgewoJCS8qIG11c3QgYmUgcHVkX2h1Z2Ugb3IgcHVkX25vbmUgKi8KCQlCVUdfT04oIXB1 ZF9odWdlKCpwdWQpICYmICFwdWRfbm9uZSgqcHVkKSk7CgkJcmV0dXJuIChwdGVfdCAqKXB1ZDsg Ly8gbm90ZSB0aGF0IHJldHVybiB2YWxpZCBwb2ludGVyIGZvciBwdWRfbm9uZSgpIGNhc2UsCgkJ CQkvLyBpbnN0ZWFkIG9mIE5VTEwsIHRoYXQgaXMgc2FtZSBzZW1hbnRpY3MgYXMgZXhpc3Rpbmcg Y29kZS4KCX0KCWlmICghcHVkX3ByZXNlbnQoKnB1ZCkpCgkJcmV0dXJuIE5VTEw7IC8vIG5vdGUg dGhhdCBvbmx5IHJldHVybiBOVUxMIGluIGNhc2UgcHVkIG5vdCBwcmVzZW50LAoJCQkJCQkJCS8v IHNhbWUgc2VtYXRpY3MgYXMgZXhpc3RpbmcgY29kZS4KCS8qIG11c3QgaGF2ZSBhIHZhbGlkIGVu dHJ5IGFuZCBzaXplIHRvIGdvIGZ1cnRoZXIgKi8KCUJVR19PTihzeiAhPSBQTURfU0laRSk7CgkK CXBtZCA9IHBtZF9vZmZzZXQocHVkLCBhZGRyKTsKCS8qIG11c3QgYmUgcG1kX2h1Z2Ugb3IgcG1k X25vbmUgKi8KCUJVR19PTighcG1kX2h1Z2UoKnBtZCkgJiYgIXBtZF9ub25lKCpwbWQpKTsKCXJl dHVybiAocHRlX3QgKilwbWQ7IC8vIG5vdGUgdGhhdCByZXR1cm4gdmFsaWQgcG9pbnRlciBmb3Ig cG1kX25vbmUoKSBjYXNlLAoJCQkvLyBpbnN0ZWFkIG9mIE5VTEwsIHRoYXQgaXMgc2FtZSBzZW1h bnRpY3MgYXMgZXhpc3RpbmcgY29kZS4KLi4uCgo+VGhpcyBBUEkgc2VlbXMga2luZCBvZiBzdHJh bmdlIHRvIGJlIGhvbmVzdC4uIFNob3VsZCBpdCBiZSB0d28KPmZ1bmN0aW9ucyBpbnN0ZWFkIG9m IGEgc3ogcGFyYW1ldGVyPwo+Cj5odWdlX3B1ZF9vZmZzZXQoKSBhbmQgaHVnZV9wbWRfb2Zmc2V0 KCkgPyAKCkkgdGhpbmsgY2hlY2tpbmcgaHVnZSBzaXplIHRoZW4gY2FsbCB0byBvbmUgb2YgdGhl c2UgdHdvIGZ1bmN0aW9ucyBhdCBjYWxsZXIKc2l0ZSB3aWxsIGludm9sdmUgbWFueSByZWR1bmRh bnQgY29kZSDCoGRvIGJyYW5jaCB3b3JrIGluIG9uZSBmdW5jdGlvbiBpcwpiZXR0ZXIuCgo+Cj5K YXNvbg==