From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A03C54FD0 for ; Thu, 23 Apr 2020 15:54:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1870020767 for ; Thu, 23 Apr 2020 15:54:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJEUhhwb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1870020767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A2A9C8E0005; Thu, 23 Apr 2020 11:54:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DADB8E0003; Thu, 23 Apr 2020 11:54:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C98B8E0005; Thu, 23 Apr 2020 11:54:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 70D0B8E0003 for ; Thu, 23 Apr 2020 11:54:42 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 262AB841A for ; Thu, 23 Apr 2020 15:54:42 +0000 (UTC) X-FDA: 76739567604.24.sink44_28fbdfca26d1c X-HE-Tag: sink44_28fbdfca26d1c X-Filterd-Recvd-Size: 5438 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Apr 2020 15:54:41 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id r4so3093550pgg.4 for ; Thu, 23 Apr 2020 08:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MgIA5EYofw58DNxlzDZEblae7CIx3GDsfyUZoxVSVbc=; b=ZJEUhhwbRJMvyWPd6sGBvXxuhWEwjl0umvJYTsf9JyqfMJ3KpJCuMIGYF5HuLxGWuy DFXzu4kPOMgPvFNVDizd90WVP4NLbgROEneM3WqSakvh+CB0/YEznDMywmN2fSHGjQhd EKM/MiZtf8CXAtITadFnkMosxxTTo31f1eOQUMvThNE5Pk8Z12bMzcEw/4Db626qjkwZ u0ht+o1VzQwWlYW/vjP/nbZMDzh5PKw19ePGd+nwG/PJooHu+3WtxbvIXtQoUct4zpwT qrkhLghJ+peLDe6ZBEzCqejU7PJJ1BjSNzCumh27O0DaNcXjF4FjYamG37FJcH79jWDn V64g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MgIA5EYofw58DNxlzDZEblae7CIx3GDsfyUZoxVSVbc=; b=TkqNd1A6rnQhN8l7qapHhNp+0cXeSZy2TidkrKEUMrREIijVDW1sVyYrmghv6UrREd i5JUd96UL43ei8gwbCq/xWUZmvxwdAT5BTgWl3C4s+i8FsWJfHK0G6SVPQGf95UDnkO8 vWCRo+ZIBX8SZgRAJ+ilKRLn6yvI3n6uPx0kPho7IyPa2GtKYz2VYCImsD4Pe0cI93mY usmSAhSbVBmH0u45jJW4qoTje+F3Apb0xg0hD6bO25U6B1bawC/bcvzbuv1F9YCT62YO F/6WSoQ4WLPU76avtZE6Tj03fWreHkt8aICugBtQISNKBo6/5GOknhOE9IaQ8lCUjD1Z ZADQ== X-Gm-Message-State: AGi0PuYcMjg0+LaPzxkggWbe3fx/IYhTbhnVgO4+ue8Hoi4D+CIBz5hC ZT5lapbYgxZGglKusmhNQ0w= X-Google-Smtp-Source: APiQypJgyU61ukAr9QfNeUXu1y6DrRSCWy7kzgRniS3lbLPrZmF6N69Sw0Ebwtg2H4CdKAVXuwlsrQ== X-Received: by 2002:a63:5511:: with SMTP id j17mr4479116pgb.4.1587657280365; Thu, 23 Apr 2020 08:54:40 -0700 (PDT) Received: from localhost (146.85.30.125.dy.iij4u.or.jp. [125.30.85.146]) by smtp.gmail.com with ESMTPSA id c15sm2409087pgk.66.2020.04.23.08.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 08:54:39 -0700 (PDT) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky Date: Fri, 24 Apr 2020 00:54:37 +0900 To: Tetsuo Handa Cc: Michal Hocko , Yafang Shao , Andrew Morton , Roman Gushchin , linux-mm , David Rientjes , Shakeel Butt , Sergey Senozhatsky , Petr Mladek , Steven Rostedt Subject: Re: [nacked] mm-oom-avoid-printk-iteration-under-rcu.patch removed from -mm tree Message-ID: <20200423155437.GB5385@jagdpanzerIV.localdomain> References: <68371d79-dfae-e9b9-38df-dbb916607a82@i-love.sakura.ne.jp> <20200420073305.GD27314@dhcp22.suse.cz> <041d4158-f3dc-a5b5-546e-dd3f71f67b5f@i-love.sakura.ne.jp> <20200422065950.GA30312@dhcp22.suse.cz> <0aa5e490-c5b8-dc5c-334e-9a8d37da215c@i-love.sakura.ne.jp> <20200423073438.GC4206@dhcp22.suse.cz> <20200423110707.GD4206@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (20/04/23 22:28), Tetsuo Handa wrote: [..] > +/* Annotation for "don't print to consoles". */ > +#define KERN_NO_CONSOLES KERN_SOH "S" > + > /* integer equivalents of KERN_ */ > #define LOGLEVEL_SCHED -2 /* Deferred messages from sched code > * are set to this special level */ > diff --git a/include/linux/printk.h b/include/linux/printk.h > index e061635e0409..da338b81c2e1 100644 > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -19,6 +19,7 @@ static inline int printk_get_level(const char *buffer) > switch (buffer[1]) { > case '0' ... '7': > case 'c': /* KERN_CONT */ > + case 'S': /* KERN_NO_CONSOLES */ > return buffer[1]; > } > } > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index 9a9b6156270b..ed51641af087 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -361,6 +361,7 @@ static int console_msg_format = MSG_FORMAT_DEFAULT; > */ > > enum log_flags { > + LOG_NO_CONSOLES = 1, /* don't print to consoles */ > LOG_NEWLINE = 2, /* text ended with a newline */ > LOG_CONT = 8, /* text is a fragment of a continuation line */ > }; > @@ -1959,6 +1960,9 @@ int vprintk_store(int facility, int level, > break; > case 'c': /* KERN_CONT */ > lflags |= LOG_CONT; > + break; > + case 'S': /* KERN_NO_CONSOLES */ > + lflags |= LOG_NO_CONSOLES; > } [..] Hmm. Any chance that those NO_CONSOLE messages overflow logbuf so then we start losing pending YES_CONSOLE messages? -ss