From: Michal Hocko <mhocko@suse.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Yafang Shao <laoar.shao@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>, linux-mm <linux-mm@kvack.org>,
David Rientjes <rientjes@google.com>,
Shakeel Butt <shakeelb@google.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [nacked] mm-oom-avoid-printk-iteration-under-rcu.patch removed from -mm tree
Date: Thu, 23 Apr 2020 16:35:50 +0200 [thread overview]
Message-ID: <20200423143550.GH4206@dhcp22.suse.cz> (raw)
In-Reply-To: <f1fa24ce-2566-e24d-daa9-f551ad98bdec@i-love.sakura.ne.jp>
On Thu 23-04-20 23:14:37, Tetsuo Handa wrote:
> On 2020/04/23 23:06, Michal Hocko wrote:
> >> Last year I proposed
> >> https://lkml.kernel.org/r/1550896930-12324-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp
> >> and Sergey Senozhatsky commented
> >>
> >> "This is a bit of a strange issue, to be honest. If OOM prints too
> >> many messages then we might want to do some work on the OOM side."
> >>
> >> . I was thinking that printing to consoles is a requirement for oom_dump_tasks .
> >>
> >> If we can agree with not printing dump_tasks() output to consoles, a trivial
> >> patch shown below will solve the problem. Those who cannot run syslog daemon
> >> in userspace might disagree, but this will be the simplest answer.
> >
> > Talk to printk people about this.
> >
>
> Already CC'ed.
In a separate thread please.
> My question for you is are you OK with "not printing dump_tasks() output
> to consoles?" .
To be honest, I do not know whether that make sense. This sounds
like something that people might have different opinions on and
therefore it should be configured from the userspace. It is a policy
which output goes where. All we should be dealing with is a log level.
But as I've said this is something for printk maintainers.
I have said I am ok with tweaking log levels in the oom report.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-04-23 14:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200131043324.wkArXTf6-%akpm@linux-foundation.org>
2020-04-17 14:33 ` Tetsuo Handa
2020-04-17 15:26 ` Michal Hocko
2020-04-18 10:13 ` Tetsuo Handa
2020-04-20 7:33 ` Michal Hocko
2020-04-22 6:40 ` Tetsuo Handa
2020-04-22 6:59 ` Michal Hocko
2020-04-23 5:34 ` Tetsuo Handa
2020-04-23 6:35 ` Yafang Shao
2020-04-23 7:34 ` Michal Hocko
2020-04-23 10:22 ` Yafang Shao
2020-04-23 11:07 ` Michal Hocko
2020-04-23 13:28 ` Tetsuo Handa
2020-04-23 14:06 ` Michal Hocko
2020-04-23 14:14 ` Tetsuo Handa
2020-04-23 14:35 ` Michal Hocko [this message]
2020-04-24 13:02 ` Steven Rostedt
2020-04-24 15:18 ` Michal Hocko
2020-04-23 15:54 ` Sergey Senozhatsky
2020-04-23 22:56 ` Tetsuo Handa
2020-04-24 0:56 ` Yafang Shao
2020-04-24 1:16 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423143550.GH4206@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox