From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA9EC55186 for ; Thu, 23 Apr 2020 11:57:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 427412098B for ; Thu, 23 Apr 2020 11:57:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 427412098B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C16178E0005; Thu, 23 Apr 2020 07:57:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC6DC8E0003; Thu, 23 Apr 2020 07:57:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADC608E0005; Thu, 23 Apr 2020 07:57:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 934958E0003 for ; Thu, 23 Apr 2020 07:57:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 50A08180AD81A for ; Thu, 23 Apr 2020 11:57:31 +0000 (UTC) X-FDA: 76738969902.22.field79_76aaf7615943 X-HE-Tag: field79_76aaf7615943 X-Filterd-Recvd-Size: 3204 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Apr 2020 11:57:30 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3251BAD0F; Thu, 23 Apr 2020 11:57:28 +0000 (UTC) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: akpm@linux-foundation.org, Christoph Lameter Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , mhocko@kernel.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND] slub: Remove userspace notifier for cache add/remove Date: Thu, 23 Apr 2020 13:57:21 +0200 Message-Id: <20200423115721.19821-1-mkoutny@suse.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Christoph Lameter I came across some unnecessary uevents once again which reminded me this. The patch seems to be lost in the leaves of the original discussion [1], so resending. [1] https://lore.kernel.org/r/alpine.DEB.2.21.2001281813130.745@www.lamet= er.com 8<--- Kmem caches are internal kernel structures so it is strange that userspace notifiers would be needed. And I am not aware of any use of these notifiers. These notifiers may just exist because in the initial slub release the sysfs code was copied from another subsystem. Signed-off-by: Christoph Lameter Acked-by: Vlastimil Babka Acked-by: Michal Koutn=C3=BD --- mm/slub.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 332d4b459a90..ae6116adf875 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5665,19 +5665,6 @@ static struct kobj_type slab_ktype =3D { .release =3D kmem_cache_release, }; =20 -static int uevent_filter(struct kset *kset, struct kobject *kobj) -{ - struct kobj_type *ktype =3D get_ktype(kobj); - - if (ktype =3D=3D &slab_ktype) - return 1; - return 0; -} - -static const struct kset_uevent_ops slab_uevent_ops =3D { - .filter =3D uevent_filter, -}; - static struct kset *slab_kset; =20 static inline struct kset *cache_kset(struct kmem_cache *s) @@ -5745,7 +5732,6 @@ static void sysfs_slab_remove_workfn(struct work_st= ruct *work) #ifdef CONFIG_MEMCG kset_unregister(s->memcg_kset); #endif - kobject_uevent(&s->kobj, KOBJ_REMOVE); out: kobject_put(&s->kobj); } @@ -5803,7 +5789,6 @@ static int sysfs_slab_add(struct kmem_cache *s) } #endif =20 - kobject_uevent(&s->kobj, KOBJ_ADD); if (!unmergeable) { /* Setup first alias */ sysfs_slab_alias(s, s->name); @@ -5884,7 +5869,7 @@ static int __init slab_sysfs_init(void) =20 mutex_lock(&slab_mutex); =20 - slab_kset =3D kset_create_and_add("slab", &slab_uevent_ops, kernel_kobj= ); + slab_kset =3D kset_create_and_add("slab", NULL, kernel_kobj); if (!slab_kset) { mutex_unlock(&slab_mutex); pr_err("Cannot register slab subsystem.\n"); --=20 2.26.0