From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22AC5C5518C for ; Wed, 22 Apr 2020 23:16:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DBF7320776 for ; Wed, 22 Apr 2020 23:16:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CrikSTmA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBF7320776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 660A58E0007; Wed, 22 Apr 2020 19:16:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EAB18E0003; Wed, 22 Apr 2020 19:16:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B2678E0007; Wed, 22 Apr 2020 19:16:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 2F3E58E0003 for ; Wed, 22 Apr 2020 19:16:44 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D53A9181AEF07 for ; Wed, 22 Apr 2020 23:16:43 +0000 (UTC) X-FDA: 76737052686.05.wire57_3ab6e980f2d32 X-HE-Tag: wire57_3ab6e980f2d32 X-Filterd-Recvd-Size: 3914 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 23:16:43 +0000 (UTC) Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 772CB20724; Wed, 22 Apr 2020 23:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587597402; bh=fGGayOuQA8eNh3azqpJ6Mnsr9UJv0qauowcJNqXgdoQ=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=CrikSTmAs4rknYwbtS6BT9f7CD49A6wmTO6Y6YJzjPrqFouCEU4qjv5YvCVvnfoSC +eJLbFg0r2cabY9PkiY7J4rUxphVaHl6EeygTj8zWIFzkehJ21FBZ8f3k9aGdsJJfP Y2gRUqYq++mD9zdaJdvjBKbK5Fv0MtoZgbcEKD9Q= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 608DE35227C1; Wed, 22 Apr 2020 16:16:42 -0700 (PDT) Date: Wed, 22 Apr 2020 16:16:42 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: Uladzislau Rezki , Andrew Morton , LKML , RCU , Steven Rostedt , Oleksiy Avramchenko , linux-mm@kvack.org Subject: Re: [PATCH v1 5/6] rcu: rename kfree_call_rcu()/__kfree_rcu() Message-ID: <20200422231642.GJ17661@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200315181840.6966-1-urezki@gmail.com> <20200315181840.6966-6-urezki@gmail.com> <20200316152541.GD190951@google.com> <20200316190144.GB10577@pc636> <20200420201527.679247f6fa76cba4331f3cd3@linux-foundation.org> <20200421120358.GA5117@pc636> <20200422230322.GA100393@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422230322.GA100393@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 22, 2020 at 07:03:22PM -0400, Joel Fernandes wrote: > On Tue, Apr 21, 2020 at 02:03:58PM +0200, Uladzislau Rezki wrote: > > Hello, Andrew. > > > > > > > I based the kfree_rcu shrinker patches on an 'rcu/kfree' branch in my git > > > > > tree: https://github.com/joelagnel/linux-kernel/tree/rcu/kfree > > > > > > > > > > For now I manually applied 5/6. All others applied cleanly. > > > > > > > > > > Updated the tree as I continue to review your patches. > > > > > > > > > > > I'm not sure what's happening here - these patches aren't yet in > > > linux-next. > > > > > Please have a look here, i explained in detail in my cover latter > > what we would like to achieve: https://lkml.org/lkml/2020/3/23/242 > > > > > A couple of thoughts: > > > > > > - Please cc linux-mm@kvack.org on this patchset and anything else > > > which impacts MM. > > > > > OK. I thought that is related to RCU, therefore i did not want to > > spam, but i included you :) Next time we will keep linux-mm@kvack.org > > in a loop. Sorry for that. > > Sorry from my side as well. Will keep linux-mm in the loop henceforth. I must confess that it came as a bit of a surprise to me as well. But what is life without a surprise or two along the way? ;-) Thanx, Paul > thanks, > > - Joel > > > > > > > > > > - It's a bit strange to create new infrastructure which has but a > > > single call site. Please tell us much more about "there was also > > > request/interest so there will be new comers" to set minds at ease. > > > > > > Who/where are these possible new callsites and when can we expect to > > > see that code? > > > > > https://lkml.org/lkml/2020/3/23/242 here i wrote motivation. Please > > check it. If you have some questions please ask. > > > > -- > > Vlad Rezki