From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411B9C55189 for ; Wed, 22 Apr 2020 13:02:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 01BFB206EC for ; Wed, 22 Apr 2020 13:02:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="N+/tBroJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01BFB206EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 965188E001D; Wed, 22 Apr 2020 09:02:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 916138E0003; Wed, 22 Apr 2020 09:02:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 852EC8E001D; Wed, 22 Apr 2020 09:02:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 6B4A08E0003 for ; Wed, 22 Apr 2020 09:02:19 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AC0E08248D52 for ; Wed, 22 Apr 2020 13:02:17 +0000 (UTC) X-FDA: 76735504314.16.robin73_4e2f4e1ceca04 X-HE-Tag: robin73_4e2f4e1ceca04 X-Filterd-Recvd-Size: 3350 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 13:02:17 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id i10so2272970wrv.10 for ; Wed, 22 Apr 2020 06:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GbOzOA2jLauEyhF5FpehUWFEOltqhf98Tx8DOW6lJE8=; b=N+/tBroJHdEXwWpg4TRd6JZ5iqncYxxac3GlyGwOO4VC8jIzaofmpNAq3H45O1mRrR e4LFNfnlvLB/Myi3Bld4upFlvockWkNqakjAdaitnB4cdFSvPeKsVeY7G2Ke74MskSci 8ehHQjN42FkaBoFCjmflXG/W99GiyXfFJ6+TE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GbOzOA2jLauEyhF5FpehUWFEOltqhf98Tx8DOW6lJE8=; b=koH8ntZiexa5yMHNOECnuGELKRi+rFtREVi+T6S2QF0CCPc7b6rGdE4jHoSBM8mFwP /vRqpaN7+Dp5PCpMadFRIPfxVgzDGx+RT2oZ8zc3NOBxOSuu1qpkj23bkO8ap+w2gJBT ylmfZgeCPxmyQUmuDClyR9YjIVvYV7+/HT3tXBhIxaqzfqBEgCZx88qGyqxxdM6gJOlH WAakJtvlzj8jcOZzoqAaZ6sTwI29CcSOSH0iFGjcrNm2nye1I+uVENYPE6WcQvOCofvj hFAKYI5/FaPdpUHHLEyeDUlzHsxxjLpuvH8MEGV7BOXF8VOTg4GXkeuA3i2agnCOtBNz BYZw== X-Gm-Message-State: AGi0Pua9aATnBKmPjSCSzHparOYfmywTH9An/YKlF6x4elHA0oEpyYjr 58JrvpSFkjjZFBGDdh+74DKyZg== X-Google-Smtp-Source: APiQypLxPS9qpvMEGBUGrSuHmOWv3he2sScnMcupm0UgoqxLdfpIFgtR7fdtjMUgdrK9Ee1PsEEWSA== X-Received: by 2002:adf:ea48:: with SMTP id j8mr25348005wrn.108.1587560535894; Wed, 22 Apr 2020 06:02:15 -0700 (PDT) Received: from localhost ([2620:10d:c092:180::1:fa01]) by smtp.gmail.com with ESMTPSA id h6sm7920287wmf.31.2020.04.22.06.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2020 06:02:15 -0700 (PDT) Date: Wed, 22 Apr 2020 14:02:14 +0100 From: Chris Down To: Yafang Shao Cc: Johannes Weiner , Andrew Morton , Michal Hocko , Linux MM , Shakeel Butt Subject: Re: [PATCH v2] mm, memcg: fix inconsistent oom event behavior Message-ID: <20200422130214.GA949935@chrisdown.name> References: <20200422110643.15725-1-laoar.shao@gmail.com> <20200422125426.GC358439@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yafang Shao writes: >That is what I did in the previous version, see also >https://lore.kernel.org/linux-mm/20200414015952.3590-1-laoar.shao@gmail.com/ Your v1 patch was significantly less complicated and self-contained, and I would ack it (whereas I wouldn't ack this because it really complicates matters for localevents). My only questions were around quantifying the issue in the changelog :-)